sh: fix sparse annotation in SH's __get_user_check()
diff mbox series

Message ID 20210123173237.91670-1-luc.vanoostenryck@gmail.com
State New, archived
Headers show
Series
  • sh: fix sparse annotation in SH's __get_user_check()
Related show

Commit Message

Luc Van Oostenryck Jan. 23, 2021, 5:32 p.m. UTC
The pointer in get_user() and friends is supposed to be a __user pointer.
But in SH's implementation of __get_user_check(), the pointer is
assigned to a local variable __gu_addr which is lacking the __user
annotation. As consequence, a warning is issued for every of its uses.

So, add the missing __user annotation (this remove ~700 warnings when
using defconfig).

Link: https://lore.kernel.org/r/202101141753.ropIZ9nh-lkp@intel.com
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
 arch/sh/include/asm/uaccess.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e

Comments

Oliver Hartkopp Jan. 25, 2021, 9:51 a.m. UTC | #1
On 23.01.21 18:32, Luc Van Oostenryck wrote:
> The pointer in get_user() and friends is supposed to be a __user pointer.
> But in SH's implementation of __get_user_check(), the pointer is
> assigned to a local variable __gu_addr which is lacking the __user
> annotation. As consequence, a warning is issued for every of its uses.
> 
> So, add the missing __user annotation (this remove ~700 warnings when
> using defconfig).

Many thanks that you were able to spot this issue, Luc!

Best regards,
Oliver

> 
> Link: https://lore.kernel.org/r/202101141753.ropIZ9nh-lkp@intel.com
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Oliver Hartkopp <socketcan@hartkopp.net>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
>   arch/sh/include/asm/uaccess.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/sh/include/asm/uaccess.h b/arch/sh/include/asm/uaccess.h
> index 73f3b48d4a34..e2623fe2ac09 100644
> --- a/arch/sh/include/asm/uaccess.h
> +++ b/arch/sh/include/asm/uaccess.h
> @@ -68,7 +68,7 @@ struct __large_struct { unsigned long buf[100]; };
>   ({									\
>   	long __gu_err = -EFAULT;					\
>   	unsigned long __gu_val = 0;					\
> -	const __typeof__(*(ptr)) *__gu_addr = (ptr);			\
> +	const __typeof__(*(ptr)) __user *__gu_addr = (ptr);		\
>   	if (likely(access_ok(__gu_addr, (size))))		\
>   		__get_user_size(__gu_val, __gu_addr, (size), __gu_err);	\
>   	(x) = (__force __typeof__(*(ptr)))__gu_val;			\
> 
> base-commit: 5c8fe583cce542aa0b84adc939ce85293de36e5e
>

Patch
diff mbox series

diff --git a/arch/sh/include/asm/uaccess.h b/arch/sh/include/asm/uaccess.h
index 73f3b48d4a34..e2623fe2ac09 100644
--- a/arch/sh/include/asm/uaccess.h
+++ b/arch/sh/include/asm/uaccess.h
@@ -68,7 +68,7 @@  struct __large_struct { unsigned long buf[100]; };
 ({									\
 	long __gu_err = -EFAULT;					\
 	unsigned long __gu_val = 0;					\
-	const __typeof__(*(ptr)) *__gu_addr = (ptr);			\
+	const __typeof__(*(ptr)) __user *__gu_addr = (ptr);		\
 	if (likely(access_ok(__gu_addr, (size))))		\
 		__get_user_size(__gu_val, __gu_addr, (size), __gu_err);	\
 	(x) = (__force __typeof__(*(ptr)))__gu_val;			\