From: Emil Renner Berthing <esmil@mailme.dk>
To: linux-usb@vger.kernel.org, netdev@vger.kernel.org
Cc: Emil Renner Berthing <kernel@esmil.dk>,
Oliver Neukum <oneukum@suse.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
linux-kernel@vger.kernel.org
Subject: [PATCH 1/2] net: usbnet: initialize tasklet using tasklet_init
Date: Sat, 23 Jan 2021 18:32:20 +0100 [thread overview]
Message-ID: <20210123173221.5855-2-esmil@mailme.dk> (raw)
In-Reply-To: <20210123173221.5855-1-esmil@mailme.dk>
From: Emil Renner Berthing <kernel@esmil.dk>
Initialize tasklet using tasklet_init() rather than open-coding it.
Signed-off-by: Emil Renner Berthing <kernel@esmil.dk>
---
drivers/net/usb/usbnet.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index 1447da1d5729..26455c76588f 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1673,8 +1673,7 @@ usbnet_probe (struct usb_interface *udev, const struct usb_device_id *prod)
skb_queue_head_init (&dev->txq);
skb_queue_head_init (&dev->done);
skb_queue_head_init(&dev->rxq_pause);
- dev->bh.func = usbnet_bh_tasklet;
- dev->bh.data = (unsigned long)&dev->delay;
+ tasklet_init(&dev->bh, usbnet_bh_tasklet, (unsigned long)&dev->delay);
INIT_WORK (&dev->kevent, usbnet_deferred_kevent);
init_usb_anchor(&dev->deferred);
timer_setup(&dev->delay, usbnet_bh, 0);
--
2.30.0
next prev parent reply other threads:[~2021-01-23 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-23 17:32 [PATCH 0/2] net: usbnet: convert to new tasklet API Emil Renner Berthing
2021-01-23 17:32 ` Emil Renner Berthing [this message]
2021-02-01 10:36 ` [PATCH 1/2] net: usbnet: initialize tasklet using tasklet_init Oliver Neukum
2021-01-23 17:32 ` [PATCH 2/2] net: usbnet: use new tasklet API Emil Renner Berthing
2021-02-01 10:36 ` Oliver Neukum
2021-01-27 2:10 ` [PATCH 0/2] net: usbnet: convert to " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210123173221.5855-2-esmil@mailme.dk \
--to=esmil@mailme.dk \
--cc=davem@davemloft.net \
--cc=kernel@esmil.dk \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).