hwmon: (dell-smm) Add XPS 15 L502X to fan control blacklist
diff mbox series

Message ID a09eea7616881d40d2db2fb5fa2770dc6166bdae.1611456351.git.tommyhebb@gmail.com
State Accepted
Commit 4008bc7d39537bb3be166d8a3129c4980e1dd7dc
Headers show
Series
  • hwmon: (dell-smm) Add XPS 15 L502X to fan control blacklist
Related show

Commit Message

Tom Hebb Jan. 24, 2021, 2:46 a.m. UTC
It has been reported[0] that the Dell XPS 15 L502X exhibits similar
freezing behavior to the other systems[1] on this blacklist. The issue
was exposed by a prior change of mine to automatically load
dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
this model to the blacklist.

[0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
[1] https://bugzilla.kernel.org/show_bug.cgi?id=195751

Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
Cc: stable@vger.kernel.org
Reported-by: Bob Hepple <bob.hepple@gmail.com>
Tested-by: Bob Hepple <bob.hepple@gmail.com>
Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
---

 drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Guenter Roeck Jan. 24, 2021, 4:46 p.m. UTC | #1
On Sat, Jan 23, 2021 at 06:46:08PM -0800, Thomas Hebb wrote:
> It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> freezing behavior to the other systems[1] on this blacklist. The issue
> was exposed by a prior change of mine to automatically load
> dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> this model to the blacklist.
> 
> [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> 
> Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> Cc: stable@vger.kernel.org
> Reported-by: Bob Hepple <bob.hepple@gmail.com>
> Tested-by: Bob Hepple <bob.hepple@gmail.com>
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>

Applied.

Thanks,
Guenter

> ---
> 
>  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index ec448f5f2dc3..73b9db9e3aab 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
>  			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
>  		},
>  	},
> +	{
> +		.ident = "Dell XPS 15 L502X",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
> +		},
> +	},
>  	{ }
>  };
>
Pali Rohár Jan. 25, 2021, 10:05 a.m. UTC | #2
On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> freezing behavior to the other systems[1] on this blacklist. The issue
> was exposed by a prior change of mine to automatically load
> dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> this model to the blacklist.
> 
> [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> 
> Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> Cc: stable@vger.kernel.org
> Reported-by: Bob Hepple <bob.hepple@gmail.com>
> Tested-by: Bob Hepple <bob.hepple@gmail.com>
> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> ---
> 
>  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index ec448f5f2dc3..73b9db9e3aab 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
>  			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
>  		},
>  	},
> +	{
> +		.ident = "Dell XPS 15 L502X",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),

Hello! Are you sure that it is required to completely disable fan
support? And not only access to fan type label for which is different
blaclist i8k_blacklist_fan_type_dmi_table?

And have you reported this issue to Dell support?

> +		},
> +	},
>  	{ }
>  };
>  
> -- 
> 2.30.0
>
Tom Hebb Jan. 25, 2021, 6:05 p.m. UTC | #3
On Mon, Jan 25, 2021 at 2:05 AM Pali Rohár <pali@kernel.org> wrote:
>
> On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> > It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> > freezing behavior to the other systems[1] on this blacklist. The issue
> > was exposed by a prior change of mine to automatically load
> > dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> > this model to the blacklist.
> >
> > [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> > [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> >
> > Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> > Cc: stable@vger.kernel.org
> > Reported-by: Bob Hepple <bob.hepple@gmail.com>
> > Tested-by: Bob Hepple <bob.hepple@gmail.com>
> > Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> > ---
> >
> >  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > index ec448f5f2dc3..73b9db9e3aab 100644
> > --- a/drivers/hwmon/dell-smm-hwmon.c
> > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
> >                       DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> >               },
> >       },
> > +     {
> > +             .ident = "Dell XPS 15 L502X",
> > +             .matches = {
> > +                     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +                     DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
>
> Hello! Are you sure that it is required to completely disable fan
> support? And not only access to fan type label for which is different
> blaclist i8k_blacklist_fan_type_dmi_table?

This is a good question. We didn't try the other list. Bob is the one with the
affected system. Could you try moving the added block of code from
i8k_blacklist_fan_support_dmi_table a few lines up to
i8k_blacklist_fan_type_dmi_table, Bob, to see if the issue reappears or if it
remains fixed?

>
> And have you reported this issue to Dell support?
>
> > +             },
> > +     },
> >       { }
> >  };
> >
> > --
> > 2.30.0
> >

(Apologies for the previous HTML copy of this reply, to those directly CCed.)

-Tom
Guenter Roeck Jan. 25, 2021, 8:19 p.m. UTC | #4
On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Rohár wrote:
> On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> > It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> > freezing behavior to the other systems[1] on this blacklist. The issue
> > was exposed by a prior change of mine to automatically load
> > dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> > this model to the blacklist.
> > 
> > [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> > [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> > 
> > Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> > Cc: stable@vger.kernel.org
> > Reported-by: Bob Hepple <bob.hepple@gmail.com>
> > Tested-by: Bob Hepple <bob.hepple@gmail.com>
> > Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> > ---
> > 
> >  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > index ec448f5f2dc3..73b9db9e3aab 100644
> > --- a/drivers/hwmon/dell-smm-hwmon.c
> > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
> >  			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> >  		},
> >  	},
> > +	{
> > +		.ident = "Dell XPS 15 L502X",
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
> 
> Hello! Are you sure that it is required to completely disable fan
> support? And not only access to fan type label for which is different
> blaclist i8k_blacklist_fan_type_dmi_table?
> 

I'll drop this patch from my branch. Please send a Reviewed-by: or Acked-by: tag
if/when I should apply it.

Thanks,
Guenter
Pali Rohár Jan. 25, 2021, 8:21 p.m. UTC | #5
On Monday 25 January 2021 12:19:38 Guenter Roeck wrote:
> On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Rohár wrote:
> > On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> > > It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> > > freezing behavior to the other systems[1] on this blacklist. The issue
> > > was exposed by a prior change of mine to automatically load
> > > dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> > > this model to the blacklist.
> > > 
> > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> > > 
> > > Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> > > Cc: stable@vger.kernel.org
> > > Reported-by: Bob Hepple <bob.hepple@gmail.com>
> > > Tested-by: Bob Hepple <bob.hepple@gmail.com>
> > > Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> > > ---
> > > 
> > >  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > > index ec448f5f2dc3..73b9db9e3aab 100644
> > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
> > >  			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> > >  		},
> > >  	},
> > > +	{
> > > +		.ident = "Dell XPS 15 L502X",
> > > +		.matches = {
> > > +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
> > 
> > Hello! Are you sure that it is required to completely disable fan
> > support? And not only access to fan type label for which is different
> > blaclist i8k_blacklist_fan_type_dmi_table?
> > 
> 
> I'll drop this patch from my branch. Please send a Reviewed-by: or Acked-by: tag
> if/when I should apply it.

Of course! We will just wait for Bob test results.

> Thanks,
> Guenter
Tom Hebb Jan. 26, 2021, 8:15 a.m. UTC | #6
Bob reports that blacklisting the fan type label is not sufficient.
See his message to me below.

On Mon, Jan 25, 2021 at 3:38 PM Bob Hepple <bob.hepple@gmail.com> wrote:
>
> Hi Tom,
>
> Big nope this end with L502x in i8k_blacklist_fan_type_dmi_table:
>
> Jan 26 09:35:47 achar kernel: psmouse serio1: TouchPad at
> isa0060/serio1/input0 lost synchronization, throwing 1 bytes>
>
> ... and lots of trackpad stall/stutters.
>
> Cheers
>
>
> Bob
>
>
>
> On Tue, 26 Jan 2021 at 08:09, Bob Hepple <bob.hepple@gmail.com> wrote:
> >
> > ... compiling now ... results in a coupla hours
> >
> > Cheers
> >
> >
> > Bob
> >
> > On Tue, 26 Jan 2021 at 04:05, Tom Hebb <tommyhebb@gmail.com> wrote:
> > >
> > > On Mon, Jan 25, 2021 at 2:05 AM Pali Rohár <pali@kernel.org> wrote:
> > > >
> > > > On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> > > > > It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> > > > > freezing behavior to the other systems[1] on this blacklist. The issue
> > > > > was exposed by a prior change of mine to automatically load
> > > > > dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> > > > > this model to the blacklist.
> > > > >
> > > > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> > > > >
> > > > > Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> > > > > Cc: stable@vger.kernel.org
> > > > > Reported-by: Bob Hepple <bob.hepple@gmail.com>
> > > > > Tested-by: Bob Hepple <bob.hepple@gmail.com>
> > > > > Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> > > > > ---
> > > > >
> > > > >  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> > > > >  1 file changed, 7 insertions(+)
> > > > >
> > > > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > > > > index ec448f5f2dc3..73b9db9e3aab 100644
> > > > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > > > @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
> > > > >                       DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> > > > >               },
> > > > >       },
> > > > > +     {
> > > > > +             .ident = "Dell XPS 15 L502X",
> > > > > +             .matches = {
> > > > > +                     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > > +                     DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
> > > >
> > > > Hello! Are you sure that it is required to completely disable fan
> > > > support? And not only access to fan type label for which is different
> > > > blaclist i8k_blacklist_fan_type_dmi_table?
> > >
> > > This is a good question. We didn't try the other list. Bob is the one with the
> > > affected system. Could you try moving the added block of code from
> > > i8k_blacklist_fan_support_dmi_table a few lines up to
> > > i8k_blacklist_fan_type_dmi_table, Bob, to see if the issue reappears or if it
> > > remains fixed?
> > >
> > > >
> > > > And have you reported this issue to Dell support?
> > > >
> > > > > +             },
> > > > > +     },
> > > > >       { }
> > > > >  };
> > > > >
> > > > > --
> > > > > 2.30.0
> > > > >
> > >
> > > (Apologies for the previous HTML copy of this reply, to those directly CCed.)
> > >
> > > -Tom
Pali Rohár Jan. 27, 2021, 9:19 a.m. UTC | #7
On Tuesday 26 January 2021 00:15:13 Tom Hebb wrote:
> Bob reports that blacklisting the fan type label is not sufficient.
> See his message to me below.

Ok! Thank you for confirmation.

And my second question which I have asked:
And have you reported this issue to Dell support?

> On Mon, Jan 25, 2021 at 3:38 PM Bob Hepple <bob.hepple@gmail.com> wrote:
> >
> > Hi Tom,
> >
> > Big nope this end with L502x in i8k_blacklist_fan_type_dmi_table:
> >
> > Jan 26 09:35:47 achar kernel: psmouse serio1: TouchPad at
> > isa0060/serio1/input0 lost synchronization, throwing 1 bytes>
> >
> > ... and lots of trackpad stall/stutters.
> >
> > Cheers
> >
> >
> > Bob
> >
> >
> >
> > On Tue, 26 Jan 2021 at 08:09, Bob Hepple <bob.hepple@gmail.com> wrote:
> > >
> > > ... compiling now ... results in a coupla hours
> > >
> > > Cheers
> > >
> > >
> > > Bob
> > >
> > > On Tue, 26 Jan 2021 at 04:05, Tom Hebb <tommyhebb@gmail.com> wrote:
> > > >
> > > > On Mon, Jan 25, 2021 at 2:05 AM Pali Rohár <pali@kernel.org> wrote:
> > > > >
> > > > > On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> > > > > > It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> > > > > > freezing behavior to the other systems[1] on this blacklist. The issue
> > > > > > was exposed by a prior change of mine to automatically load
> > > > > > dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> > > > > > this model to the blacklist.
> > > > > >
> > > > > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> > > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> > > > > >
> > > > > > Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> > > > > > Cc: stable@vger.kernel.org
> > > > > > Reported-by: Bob Hepple <bob.hepple@gmail.com>
> > > > > > Tested-by: Bob Hepple <bob.hepple@gmail.com>
> > > > > > Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> > > > > > ---
> > > > > >
> > > > > >  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> > > > > >  1 file changed, 7 insertions(+)
> > > > > >
> > > > > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > > > > > index ec448f5f2dc3..73b9db9e3aab 100644
> > > > > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > > > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > > > > @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
> > > > > >                       DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> > > > > >               },
> > > > > >       },
> > > > > > +     {
> > > > > > +             .ident = "Dell XPS 15 L502X",
> > > > > > +             .matches = {
> > > > > > +                     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > > > +                     DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
> > > > >
> > > > > Hello! Are you sure that it is required to completely disable fan
> > > > > support? And not only access to fan type label for which is different
> > > > > blaclist i8k_blacklist_fan_type_dmi_table?
> > > >
> > > > This is a good question. We didn't try the other list. Bob is the one with the
> > > > affected system. Could you try moving the added block of code from
> > > > i8k_blacklist_fan_support_dmi_table a few lines up to
> > > > i8k_blacklist_fan_type_dmi_table, Bob, to see if the issue reappears or if it
> > > > remains fixed?
> > > >
> > > > >
> > > > > And have you reported this issue to Dell support?
> > > > >
> > > > > > +             },
> > > > > > +     },
> > > > > >       { }
> > > > > >  };
> > > > > >
> > > > > > --
> > > > > > 2.30.0
> > > > > >
> > > >
> > > > (Apologies for the previous HTML copy of this reply, to those directly CCed.)
> > > >
> > > > -Tom
Bob Hepple Jan. 27, 2021, 10:40 p.m. UTC | #8
Hi Pali,

No, I have not contacted Dell about this and I'm not sure that they
would be terribly interested given that my machine is 12 years old -
but I'll have a go if I can find the right place to do it.

Do you have a good email or other Dell target to report it? I don't
have access to official Dell support as my warranty ran out about 10
years ago. Perhaps there's an existing Dell bug report that references
the original https://bugzilla.kernel.org/show_bug.cgi?id=195751 ??? I
could add my report there if someone has already informed Dell about
the other instances of the bug.

Thanks



Bob

On Wed, 27 Jan 2021 at 19:19, Pali Rohár <pali@kernel.org> wrote:
>
> On Tuesday 26 January 2021 00:15:13 Tom Hebb wrote:
> > Bob reports that blacklisting the fan type label is not sufficient.
> > See his message to me below.
>
> Ok! Thank you for confirmation.
>
> And my second question which I have asked:
> And have you reported this issue to Dell support?
>
> > On Mon, Jan 25, 2021 at 3:38 PM Bob Hepple <bob.hepple@gmail.com> wrote:
> > >
> > > Hi Tom,
> > >
> > > Big nope this end with L502x in i8k_blacklist_fan_type_dmi_table:
> > >
> > > Jan 26 09:35:47 achar kernel: psmouse serio1: TouchPad at
> > > isa0060/serio1/input0 lost synchronization, throwing 1 bytes>
> > >
> > > ... and lots of trackpad stall/stutters.
> > >
> > > Cheers
> > >
> > >
> > > Bob
> > >
> > >
> > >
> > > On Tue, 26 Jan 2021 at 08:09, Bob Hepple <bob.hepple@gmail.com> wrote:
> > > >
> > > > ... compiling now ... results in a coupla hours
> > > >
> > > > Cheers
> > > >
> > > >
> > > > Bob
> > > >
> > > > On Tue, 26 Jan 2021 at 04:05, Tom Hebb <tommyhebb@gmail.com> wrote:
> > > > >
> > > > > On Mon, Jan 25, 2021 at 2:05 AM Pali Rohár <pali@kernel.org> wrote:
> > > > > >
> > > > > > On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> > > > > > > It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> > > > > > > freezing behavior to the other systems[1] on this blacklist. The issue
> > > > > > > was exposed by a prior change of mine to automatically load
> > > > > > > dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> > > > > > > this model to the blacklist.
> > > > > > >
> > > > > > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> > > > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> > > > > > >
> > > > > > > Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> > > > > > > Cc: stable@vger.kernel.org
> > > > > > > Reported-by: Bob Hepple <bob.hepple@gmail.com>
> > > > > > > Tested-by: Bob Hepple <bob.hepple@gmail.com>
> > > > > > > Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> > > > > > > ---
> > > > > > >
> > > > > > >  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> > > > > > >  1 file changed, 7 insertions(+)
> > > > > > >
> > > > > > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > > > > > > index ec448f5f2dc3..73b9db9e3aab 100644
> > > > > > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > > > > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > > > > > @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
> > > > > > >                       DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> > > > > > >               },
> > > > > > >       },
> > > > > > > +     {
> > > > > > > +             .ident = "Dell XPS 15 L502X",
> > > > > > > +             .matches = {
> > > > > > > +                     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > > > > +                     DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
> > > > > >
> > > > > > Hello! Are you sure that it is required to completely disable fan
> > > > > > support? And not only access to fan type label for which is different
> > > > > > blaclist i8k_blacklist_fan_type_dmi_table?
> > > > >
> > > > > This is a good question. We didn't try the other list. Bob is the one with the
> > > > > affected system. Could you try moving the added block of code from
> > > > > i8k_blacklist_fan_support_dmi_table a few lines up to
> > > > > i8k_blacklist_fan_type_dmi_table, Bob, to see if the issue reappears or if it
> > > > > remains fixed?
> > > > >
> > > > > >
> > > > > > And have you reported this issue to Dell support?
> > > > > >
> > > > > > > +             },
> > > > > > > +     },
> > > > > > >       { }
> > > > > > >  };
> > > > > > >
> > > > > > > --
> > > > > > > 2.30.0
> > > > > > >
> > > > >
> > > > > (Apologies for the previous HTML copy of this reply, to those directly CCed.)
> > > > >
> > > > > -Tom
Pali Rohár Jan. 27, 2021, 10:58 p.m. UTC | #9
Hello Bob!

On Thursday 28 January 2021 08:40:36 Bob Hepple wrote:
> Hi Pali,
> 
> No, I have not contacted Dell about this and I'm not sure that they
> would be terribly interested given that my machine is 12 years old -
> but I'll have a go if I can find the right place to do it.

If it is 12 years old machine then I doubt that anybody would do any
support for it...

> Do you have a good email or other Dell target to report it?

In this post is information how to contact Dell Linux support team which
can open (internal) BIOS issue:

https://github.com/dell/libsmbios/issues/48#issuecomment-391328501

But it is possible that still only available for USA.

Mario (superm1 on github) is active also in kernel and can help with
firmware issues on new machines.

But for this your 12 years old machine is proposed blacklist quirk the
only option.

I just do not know if this issue was already fixed in new BIOS which is
available on new machines. And therefore I'm worried if these issues
would continue to appear also on other machines, or we are just
collecting list of old machines.

Just I do not want to see situation when manufacture says "it is
working, nothing needed to fix" and it would work just because of
blacklist... As such scenario would lead only to increasing blacklist
without ability to start fixing issues.

> I don't
> have access to official Dell support as my warranty ran out about 10
> years ago. Perhaps there's an existing Dell bug report that references
> the original https://bugzilla.kernel.org/show_bug.cgi?id=195751 ??? I
> could add my report there if someone has already informed Dell about
> the other instances of the bug.
> 
> Thanks
> 
> 
> 
> Bob
> 
> On Wed, 27 Jan 2021 at 19:19, Pali Rohár <pali@kernel.org> wrote:
> >
> > On Tuesday 26 January 2021 00:15:13 Tom Hebb wrote:
> > > Bob reports that blacklisting the fan type label is not sufficient.
> > > See his message to me below.
> >
> > Ok! Thank you for confirmation.
> >
> > And my second question which I have asked:
> > And have you reported this issue to Dell support?
> >
> > > On Mon, Jan 25, 2021 at 3:38 PM Bob Hepple <bob.hepple@gmail.com> wrote:
> > > >
> > > > Hi Tom,
> > > >
> > > > Big nope this end with L502x in i8k_blacklist_fan_type_dmi_table:
> > > >
> > > > Jan 26 09:35:47 achar kernel: psmouse serio1: TouchPad at
> > > > isa0060/serio1/input0 lost synchronization, throwing 1 bytes>
> > > >
> > > > ... and lots of trackpad stall/stutters.
> > > >
> > > > Cheers
> > > >
> > > >
> > > > Bob
> > > >
> > > >
> > > >
> > > > On Tue, 26 Jan 2021 at 08:09, Bob Hepple <bob.hepple@gmail.com> wrote:
> > > > >
> > > > > ... compiling now ... results in a coupla hours
> > > > >
> > > > > Cheers
> > > > >
> > > > >
> > > > > Bob
> > > > >
> > > > > On Tue, 26 Jan 2021 at 04:05, Tom Hebb <tommyhebb@gmail.com> wrote:
> > > > > >
> > > > > > On Mon, Jan 25, 2021 at 2:05 AM Pali Rohár <pali@kernel.org> wrote:
> > > > > > >
> > > > > > > On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> > > > > > > > It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> > > > > > > > freezing behavior to the other systems[1] on this blacklist. The issue
> > > > > > > > was exposed by a prior change of mine to automatically load
> > > > > > > > dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> > > > > > > > this model to the blacklist.
> > > > > > > >
> > > > > > > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> > > > > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> > > > > > > >
> > > > > > > > Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> > > > > > > > Cc: stable@vger.kernel.org
> > > > > > > > Reported-by: Bob Hepple <bob.hepple@gmail.com>
> > > > > > > > Tested-by: Bob Hepple <bob.hepple@gmail.com>
> > > > > > > > Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> > > > > > > > ---
> > > > > > > >
> > > > > > > >  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> > > > > > > >  1 file changed, 7 insertions(+)
> > > > > > > >
> > > > > > > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > > > > > > > index ec448f5f2dc3..73b9db9e3aab 100644
> > > > > > > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > > > > > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > > > > > > @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
> > > > > > > >                       DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> > > > > > > >               },
> > > > > > > >       },
> > > > > > > > +     {
> > > > > > > > +             .ident = "Dell XPS 15 L502X",
> > > > > > > > +             .matches = {
> > > > > > > > +                     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > > > > > +                     DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
> > > > > > >
> > > > > > > Hello! Are you sure that it is required to completely disable fan
> > > > > > > support? And not only access to fan type label for which is different
> > > > > > > blaclist i8k_blacklist_fan_type_dmi_table?
> > > > > >
> > > > > > This is a good question. We didn't try the other list. Bob is the one with the
> > > > > > affected system. Could you try moving the added block of code from
> > > > > > i8k_blacklist_fan_support_dmi_table a few lines up to
> > > > > > i8k_blacklist_fan_type_dmi_table, Bob, to see if the issue reappears or if it
> > > > > > remains fixed?
> > > > > >
> > > > > > >
> > > > > > > And have you reported this issue to Dell support?
> > > > > > >
> > > > > > > > +             },
> > > > > > > > +     },
> > > > > > > >       { }
> > > > > > > >  };
> > > > > > > >
> > > > > > > > --
> > > > > > > > 2.30.0
> > > > > > > >
> > > > > >
> > > > > > (Apologies for the previous HTML copy of this reply, to those directly CCed.)
> > > > > >
> > > > > > -Tom
Pali Rohár Jan. 27, 2021, 11 p.m. UTC | #10
On Monday 25 January 2021 21:21:30 Pali Rohár wrote:
> On Monday 25 January 2021 12:19:38 Guenter Roeck wrote:
> > On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Rohár wrote:
> > > On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> > > > It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> > > > freezing behavior to the other systems[1] on this blacklist. The issue
> > > > was exposed by a prior change of mine to automatically load
> > > > dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> > > > this model to the blacklist.
> > > > 
> > > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> > > > 
> > > > Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> > > > Cc: stable@vger.kernel.org
> > > > Reported-by: Bob Hepple <bob.hepple@gmail.com>
> > > > Tested-by: Bob Hepple <bob.hepple@gmail.com>
> > > > Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> > > > ---
> > > > 
> > > >  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> > > >  1 file changed, 7 insertions(+)
> > > > 
> > > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > > > index ec448f5f2dc3..73b9db9e3aab 100644
> > > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > > @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
> > > >  			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> > > >  		},
> > > >  	},
> > > > +	{
> > > > +		.ident = "Dell XPS 15 L502X",
> > > > +		.matches = {
> > > > +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
> > > 
> > > Hello! Are you sure that it is required to completely disable fan
> > > support? And not only access to fan type label for which is different
> > > blaclist i8k_blacklist_fan_type_dmi_table?
> > > 
> > 
> > I'll drop this patch from my branch. Please send a Reviewed-by: or Acked-by: tag
> > if/when I should apply it.
> 
> Of course! We will just wait for Bob test results.

Guenter, now we have all needed information, fix is really needed in
this form. So you can add my:

Reviewed-by: Pali Rohár <pali@kernel.org>
Tom Hebb Jan. 28, 2021, 12:35 a.m. UTC | #11
On Wed, Jan 27, 2021 at 2:58 PM Pali Rohár <pali@kernel.org> wrote:
>
> Hello Bob!
>
> On Thursday 28 January 2021 08:40:36 Bob Hepple wrote:
> > Hi Pali,
> >
> > No, I have not contacted Dell about this and I'm not sure that they
> > would be terribly interested given that my machine is 12 years old -
> > but I'll have a go if I can find the right place to do it.
>
> If it is 12 years old machine then I doubt that anybody would do any
> support for it...
>
> > Do you have a good email or other Dell target to report it?
>
> In this post is information how to contact Dell Linux support team which
> can open (internal) BIOS issue:
>
> https://github.com/dell/libsmbios/issues/48#issuecomment-391328501
>
> But it is possible that still only available for USA.
>
> Mario (superm1 on github) is active also in kernel and can help with
> firmware issues on new machines.
>
> But for this your 12 years old machine is proposed blacklist quirk the
> only option.
>
> I just do not know if this issue was already fixed in new BIOS which is
> available on new machines. And therefore I'm worried if these issues
> would continue to appear also on other machines, or we are just
> collecting list of old machines.

My XPS 13 9350 from 2015 does not exhibit this issue, FWIW. I think we
would be seeing a lot more reports like this if new BIOSes were also
affected.


> Just I do not want to see situation when manufacture says "it is
> working, nothing needed to fix" and it would work just because of
> blacklist... As such scenario would lead only to increasing blacklist
> without ability to start fixing issues.
>
> > I don't
> > have access to official Dell support as my warranty ran out about 10
> > years ago. Perhaps there's an existing Dell bug report that references
> > the original https://bugzilla.kernel.org/show_bug.cgi?id=195751 ??? I
> > could add my report there if someone has already informed Dell about
> > the other instances of the bug.
> >
> > Thanks
> >
> >
> >
> > Bob
> >
> > On Wed, 27 Jan 2021 at 19:19, Pali Rohár <pali@kernel.org> wrote:
> > >
> > > On Tuesday 26 January 2021 00:15:13 Tom Hebb wrote:
> > > > Bob reports that blacklisting the fan type label is not sufficient.
> > > > See his message to me below.
> > >
> > > Ok! Thank you for confirmation.
> > >
> > > And my second question which I have asked:
> > > And have you reported this issue to Dell support?
> > >
> > > > On Mon, Jan 25, 2021 at 3:38 PM Bob Hepple <bob.hepple@gmail.com> wrote:
> > > > >
> > > > > Hi Tom,
> > > > >
> > > > > Big nope this end with L502x in i8k_blacklist_fan_type_dmi_table:
> > > > >
> > > > > Jan 26 09:35:47 achar kernel: psmouse serio1: TouchPad at
> > > > > isa0060/serio1/input0 lost synchronization, throwing 1 bytes>
> > > > >
> > > > > ... and lots of trackpad stall/stutters.
> > > > >
> > > > > Cheers
> > > > >
> > > > >
> > > > > Bob
> > > > >
> > > > >
> > > > >
> > > > > On Tue, 26 Jan 2021 at 08:09, Bob Hepple <bob.hepple@gmail.com> wrote:
> > > > > >
> > > > > > ... compiling now ... results in a coupla hours
> > > > > >
> > > > > > Cheers
> > > > > >
> > > > > >
> > > > > > Bob
> > > > > >
> > > > > > On Tue, 26 Jan 2021 at 04:05, Tom Hebb <tommyhebb@gmail.com> wrote:
> > > > > > >
> > > > > > > On Mon, Jan 25, 2021 at 2:05 AM Pali Rohár <pali@kernel.org> wrote:
> > > > > > > >
> > > > > > > > On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> > > > > > > > > It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> > > > > > > > > freezing behavior to the other systems[1] on this blacklist. The issue
> > > > > > > > > was exposed by a prior change of mine to automatically load
> > > > > > > > > dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> > > > > > > > > this model to the blacklist.
> > > > > > > > >
> > > > > > > > > [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> > > > > > > > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> > > > > > > > >
> > > > > > > > > Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> > > > > > > > > Cc: stable@vger.kernel.org
> > > > > > > > > Reported-by: Bob Hepple <bob.hepple@gmail.com>
> > > > > > > > > Tested-by: Bob Hepple <bob.hepple@gmail.com>
> > > > > > > > > Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> > > > > > > > > ---
> > > > > > > > >
> > > > > > > > >  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> > > > > > > > >  1 file changed, 7 insertions(+)
> > > > > > > > >
> > > > > > > > > diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> > > > > > > > > index ec448f5f2dc3..73b9db9e3aab 100644
> > > > > > > > > --- a/drivers/hwmon/dell-smm-hwmon.c
> > > > > > > > > +++ b/drivers/hwmon/dell-smm-hwmon.c
> > > > > > > > > @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
> > > > > > > > >                       DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> > > > > > > > >               },
> > > > > > > > >       },
> > > > > > > > > +     {
> > > > > > > > > +             .ident = "Dell XPS 15 L502X",
> > > > > > > > > +             .matches = {
> > > > > > > > > +                     DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > > > > > > > > +                     DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
> > > > > > > >
> > > > > > > > Hello! Are you sure that it is required to completely disable fan
> > > > > > > > support? And not only access to fan type label for which is different
> > > > > > > > blaclist i8k_blacklist_fan_type_dmi_table?
> > > > > > >
> > > > > > > This is a good question. We didn't try the other list. Bob is the one with the
> > > > > > > affected system. Could you try moving the added block of code from
> > > > > > > i8k_blacklist_fan_support_dmi_table a few lines up to
> > > > > > > i8k_blacklist_fan_type_dmi_table, Bob, to see if the issue reappears or if it
> > > > > > > remains fixed?
> > > > > > >
> > > > > > > >
> > > > > > > > And have you reported this issue to Dell support?
> > > > > > > >
> > > > > > > > > +             },
> > > > > > > > > +     },
> > > > > > > > >       { }
> > > > > > > > >  };
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > 2.30.0
> > > > > > > > >
> > > > > > >
> > > > > > > (Apologies for the previous HTML copy of this reply, to those directly CCed.)
> > > > > > >
> > > > > > > -Tom
Guenter Roeck Jan. 28, 2021, 1:46 a.m. UTC | #12
On 1/27/21 3:00 PM, Pali Rohár wrote:
> On Monday 25 January 2021 21:21:30 Pali Rohár wrote:
>> On Monday 25 January 2021 12:19:38 Guenter Roeck wrote:
>>> On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Rohár wrote:
>>>> On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
>>>>> It has been reported[0] that the Dell XPS 15 L502X exhibits similar
>>>>> freezing behavior to the other systems[1] on this blacklist. The issue
>>>>> was exposed by a prior change of mine to automatically load
>>>>> dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
>>>>> this model to the blacklist.
>>>>>
>>>>> [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
>>>>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
>>>>>
>>>>> Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
>>>>> Cc: stable@vger.kernel.org
>>>>> Reported-by: Bob Hepple <bob.hepple@gmail.com>
>>>>> Tested-by: Bob Hepple <bob.hepple@gmail.com>
>>>>> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
>>>>> ---
>>>>>
>>>>>  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
>>>>>  1 file changed, 7 insertions(+)
>>>>>
>>>>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
>>>>> index ec448f5f2dc3..73b9db9e3aab 100644
>>>>> --- a/drivers/hwmon/dell-smm-hwmon.c
>>>>> +++ b/drivers/hwmon/dell-smm-hwmon.c
>>>>> @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
>>>>>  			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
>>>>>  		},
>>>>>  	},
>>>>> +	{
>>>>> +		.ident = "Dell XPS 15 L502X",
>>>>> +		.matches = {
>>>>> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
>>>>> +			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
>>>>
>>>> Hello! Are you sure that it is required to completely disable fan
>>>> support? And not only access to fan type label for which is different
>>>> blaclist i8k_blacklist_fan_type_dmi_table?
>>>>
>>>
>>> I'll drop this patch from my branch. Please send a Reviewed-by: or Acked-by: tag
>>> if/when I should apply it.
>>
>> Of course! We will just wait for Bob test results.
> 
> Guenter, now we have all needed information, fix is really needed in
> this form. So you can add my:
> 
> Reviewed-by: Pali Rohár <pali@kernel.org>
> 

Applied (again)

Thanks,
Guenter
Bob Hepple Jan. 28, 2021, 5:08 a.m. UTC | #13
I've posted something on the Dell Community site as I can't get to the
proper support pages (expired warranty).

https://www.dell.com/community/XPS/Linux-kernel-regression-in-fan-control-dell-smm-hwmon-c-on-XPS/m-p/7794672#M77826

I have read that the Dell Social Networks people forward this sort of
stuff to the Dell Developers ...

Cheers

Bob

On Thu, 28 Jan 2021 at 11:46, Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 1/27/21 3:00 PM, Pali Rohár wrote:
> > On Monday 25 January 2021 21:21:30 Pali Rohár wrote:
> >> On Monday 25 January 2021 12:19:38 Guenter Roeck wrote:
> >>> On Mon, Jan 25, 2021 at 11:05:40AM +0100, Pali Rohár wrote:
> >>>> On Saturday 23 January 2021 18:46:08 Thomas Hebb wrote:
> >>>>> It has been reported[0] that the Dell XPS 15 L502X exhibits similar
> >>>>> freezing behavior to the other systems[1] on this blacklist. The issue
> >>>>> was exposed by a prior change of mine to automatically load
> >>>>> dell_smm_hwmon on a wider set of XPS models. To fix the regression, add
> >>>>> this model to the blacklist.
> >>>>>
> >>>>> [0] https://bugzilla.kernel.org/show_bug.cgi?id=211081
> >>>>> [1] https://bugzilla.kernel.org/show_bug.cgi?id=195751
> >>>>>
> >>>>> Fixes: b8a13e5e8f37 ("hwmon: (dell-smm) Use one DMI match for all XPS models")
> >>>>> Cc: stable@vger.kernel.org
> >>>>> Reported-by: Bob Hepple <bob.hepple@gmail.com>
> >>>>> Tested-by: Bob Hepple <bob.hepple@gmail.com>
> >>>>> Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
> >>>>> ---
> >>>>>
> >>>>>  drivers/hwmon/dell-smm-hwmon.c | 7 +++++++
> >>>>>  1 file changed, 7 insertions(+)
> >>>>>
> >>>>> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> >>>>> index ec448f5f2dc3..73b9db9e3aab 100644
> >>>>> --- a/drivers/hwmon/dell-smm-hwmon.c
> >>>>> +++ b/drivers/hwmon/dell-smm-hwmon.c
> >>>>> @@ -1159,6 +1159,13 @@ static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
> >>>>>                   DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
> >>>>>           },
> >>>>>   },
> >>>>> + {
> >>>>> +         .ident = "Dell XPS 15 L502X",
> >>>>> +         .matches = {
> >>>>> +                 DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> >>>>> +                 DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
> >>>>
> >>>> Hello! Are you sure that it is required to completely disable fan
> >>>> support? And not only access to fan type label for which is different
> >>>> blaclist i8k_blacklist_fan_type_dmi_table?
> >>>>
> >>>
> >>> I'll drop this patch from my branch. Please send a Reviewed-by: or Acked-by: tag
> >>> if/when I should apply it.
> >>
> >> Of course! We will just wait for Bob test results.
> >
> > Guenter, now we have all needed information, fix is really needed in
> > this form. So you can add my:
> >
> > Reviewed-by: Pali Rohár <pali@kernel.org>
> >
>
> Applied (again)
>
> Thanks,
> Guenter

Patch
diff mbox series

diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
index ec448f5f2dc3..73b9db9e3aab 100644
--- a/drivers/hwmon/dell-smm-hwmon.c
+++ b/drivers/hwmon/dell-smm-hwmon.c
@@ -1159,6 +1159,13 @@  static struct dmi_system_id i8k_blacklist_fan_support_dmi_table[] __initdata = {
 			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS13 9333"),
 		},
 	},
+	{
+		.ident = "Dell XPS 15 L502X",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Dell System XPS L502X"),
+		},
+	},
 	{ }
 };