linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <stefanc@marvell.com>
To: <netdev@vger.kernel.org>
Cc: <thomas.petazzoni@bootlin.com>, <davem@davemloft.net>,
	<nadavh@marvell.com>, <ymarkman@marvell.com>,
	<linux-kernel@vger.kernel.org>, <stefanc@marvell.com>,
	<kuba@kernel.org>, <linux@armlinux.org.uk>, <mw@semihalf.com>,
	<andrew@lunn.ch>, <rmk+kernel@armlinux.org.uk>,
	<atenart@kernel.org>
Subject: [PATCH v3 RFC net-next 12/19] net: mvpp2: enable global flow control
Date: Mon, 25 Jan 2021 19:07:59 +0200	[thread overview]
Message-ID: <1611594486-29431-13-git-send-email-stefanc@marvell.com> (raw)
In-Reply-To: <1611594486-29431-1-git-send-email-stefanc@marvell.com>

From: Stefan Chulski <stefanc@marvell.com>

This patch enables global flow control in FW and in the phylink validate mask.

Signed-off-by: Stefan Chulski <stefanc@marvell.com>
---
 drivers/net/ethernet/marvell/mvpp2/mvpp2.h      |  3 +++
 drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 20 +++++++++++++++++++-
 2 files changed, 22 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
index f34e260..e9625fb 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2.h
@@ -1022,6 +1022,9 @@ struct mvpp2 {
 	/* CM3 SRAM pool */
 	struct gen_pool *sram_pool;
 
+	/* Global TX Flow Control config */
+	bool global_tx_fc;
+
 	bool custom_dma_mask;
 
 	/* Spinlocks for CM3 shared memory configuration */
diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
index 64534f0..4d55344 100644
--- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
+++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c
@@ -5963,6 +5963,11 @@ static void mvpp2_phylink_validate(struct phylink_config *config,
 	phylink_set(mask, Autoneg);
 	phylink_set_port_modes(mask);
 
+	if (port->priv->global_tx_fc) {
+		phylink_set(mask, Pause);
+		phylink_set(mask, Asym_Pause);
+	}
+
 	switch (state->interface) {
 	case PHY_INTERFACE_MODE_10GBASER:
 	case PHY_INTERFACE_MODE_XAUI:
@@ -6981,7 +6986,7 @@ static int mvpp2_probe(struct platform_device *pdev)
 	struct resource *res;
 	void __iomem *base;
 	int i, shared;
-	int err;
+	int err, val;
 
 	priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
 	if (!priv)
@@ -7035,6 +7040,10 @@ static int mvpp2_probe(struct platform_device *pdev)
 			return err;
 		else if (err)
 			dev_warn(&pdev->dev, "Fail to alloc CM3 SRAM\n");
+
+		/* Enable global Flow Control only if handler to SRAM not NULL */
+		if (priv->cm3_base)
+			priv->global_tx_fc = true;
 	}
 
 	if (priv->hw_version != MVPP21 && dev_of_node(&pdev->dev)) {
@@ -7205,6 +7214,15 @@ static int mvpp2_probe(struct platform_device *pdev)
 		goto err_port_probe;
 	}
 
+	/* Enable global flow control. In this stage global
+	 * flow control enabled, but still disabled per port.
+	 */
+	if (priv->global_tx_fc && priv->hw_version != MVPP21) {
+		val = mvpp2_cm3_read(priv, MSS_FC_COM_REG);
+		val |= FLOW_CONTROL_ENABLE_BIT;
+		mvpp2_cm3_write(priv, MSS_FC_COM_REG, val);
+	}
+
 	mvpp2_dbgfs_init(priv, pdev->name);
 
 	platform_set_drvdata(pdev, priv);
-- 
1.9.1


  parent reply	other threads:[~2021-01-25 17:17 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 17:07 [PATCH v3 RFC net-next 00/19] net: mvpp2: Add TX Flow Control support stefanc
2021-01-25 17:07 ` [PATCH v3 RFC net-next 01/19] doc: marvell: add cm3-mem device tree bindings description stefanc
2021-01-25 17:07 ` [PATCH v3 RFC net-next 02/19] dts: marvell: add CM3 SRAM memory to cp115 ethernet device tree stefanc
2021-01-25 17:07 ` [PATCH v3 RFC net-next 03/19] net: mvpp2: add CM3 SRAM memory map stefanc
2021-01-25 17:07 ` [PATCH v3 RFC net-next 04/19] doc: marvell: add PPv2.3 description to marvell-pp2.txt stefanc
2021-01-25 17:07 ` [PATCH v3 RFC net-next 05/19] net: mvpp2: add PPv23 version definition stefanc
2021-01-25 17:07 ` [PATCH v3 RFC net-next 06/19] net: mvpp2: always compare hw-version vs MVPP21 stefanc
2021-01-25 17:07 ` [PATCH v3 RFC net-next 07/19] net: mvpp2: increase BM pool size to 2048 buffers stefanc
2021-01-25 17:07 ` [PATCH v3 RFC net-next 08/19] net: mvpp2: increase RXQ size to 1024 descriptors stefanc
2021-01-25 17:07 ` [PATCH v3 RFC net-next 09/19] net: mvpp2: add FCA periodic timer configurations stefanc
2021-01-25 17:07 ` [PATCH v3 RFC net-next 10/19] net: mvpp2: add FCA RXQ non occupied descriptor threshold stefanc
2021-01-25 17:07 ` [PATCH v3 RFC net-next 11/19] net: mvpp2: add spinlock for FW FCA configuration path stefanc
2021-01-25 17:07 ` stefanc [this message]
2021-01-25 17:08 ` [PATCH v3 RFC net-next 13/19] net: mvpp2: add RXQ flow control configurations stefanc
2021-01-25 17:08 ` [PATCH v3 RFC net-next 14/19] net: mvpp2: add ethtool flow control configuration support stefanc
2021-01-25 17:08 ` [PATCH v3 RFC net-next 15/19] net: mvpp2: add BM protection underrun feature support stefanc
2021-01-25 17:08 ` [PATCH v3 RFC net-next 16/19] net: mvpp2: add PPv23 RX FIFO flow control stefanc
2021-01-25 17:08 ` [PATCH v3 RFC net-next 17/19] net: mvpp2: set 802.3x GoP Flow Control mode stefanc
2021-01-25 17:08 ` [PATCH v3 RFC net-next 18/19] net: mvpp2: limit minimum ring size to 1024 descriptors stefanc
2021-01-25 17:08 ` [PATCH v3 RFC net-next 19/19] net: mvpp2: add TX FC firmware check stefanc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1611594486-29431-13-git-send-email-stefanc@marvell.com \
    --to=stefanc@marvell.com \
    --cc=andrew@lunn.ch \
    --cc=atenart@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mw@semihalf.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=ymarkman@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).