From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org,
Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
Doug Ledford <dledford@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-rdma@vger.kernel.org
Subject: [PATCH 19/20] RDMA/hw/hfi1/verbs: Demote non-conforming doc header and fix a misspelling
Date: Tue, 26 Jan 2021 12:47:31 +0000 [thread overview]
Message-ID: <20210126124732.3320971-20-lee.jones@linaro.org> (raw)
In-Reply-To: <20210126124732.3320971-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
drivers/infiniband/hw/hfi1/verbs.c:741: warning: Function parameter or member 'qp' not described in 'update_tx_opstats'
drivers/infiniband/hw/hfi1/verbs.c:1160: warning: Function parameter or member 'pkey' not described in 'egress_pkey_check'
drivers/infiniband/hw/hfi1/verbs.c:1160: warning: Excess function parameter 'bkey' description in 'egress_pkey_check'
drivers/infiniband/hw/hfi1/verbs.c:1217: warning: Function parameter or member 'qp' not described in 'get_send_routine'
drivers/infiniband/hw/hfi1/verbs.c:1217: warning: Function parameter or member 'ps' not described in 'get_send_routine'
Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/infiniband/hw/hfi1/verbs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
index 3591923abebb9..0dd4bb0a5a7e6 100644
--- a/drivers/infiniband/hw/hfi1/verbs.c
+++ b/drivers/infiniband/hw/hfi1/verbs.c
@@ -729,7 +729,7 @@ static noinline int build_verbs_ulp_payload(
/**
* update_tx_opstats - record stats by opcode
- * @qp; the qp
+ * @qp: the qp
* @ps: transmit packet state
* @plen: the plen in dwords
*
@@ -1145,7 +1145,7 @@ static inline int egress_pkey_matches_entry(u16 pkey, u16 ent)
* egress_pkey_check - check P_KEY of a packet
* @ppd: Physical IB port data
* @slid: SLID for packet
- * @bkey: PKEY for header
+ * @pkey: PKEY for header
* @sc5: SC for packet
* @s_pkey_index: It will be used for look up optimization for kernel contexts
* only. If it is negative value, then it means user contexts is calling this
@@ -1206,7 +1206,7 @@ int egress_pkey_check(struct hfi1_pportdata *ppd, u32 slid, u16 pkey,
return 1;
}
-/**
+/*
* get_send_routine - choose an egress routine
*
* Choose an egress routine based on QP type
--
2.25.1
next prev parent reply other threads:[~2021-01-26 13:01 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 12:47 [PATCH 00/20] [Set 3] Rid W=1 warnings from Infiniband Lee Jones
2021-01-26 12:47 ` [PATCH 01/20] RDMA/hw/hfi1/intr: Fix some kernel-doc formatting issues Lee Jones
2021-01-26 12:47 ` [PATCH 02/20] RDMA/sw/rdmavt/srq: Fix a couple of kernel-doc issues Lee Jones
2021-01-26 12:47 ` [PATCH 03/20] RDMA/hw/hfi1/iowait: Demote half-completed kernel-doc and fix formatting issue in another Lee Jones
2021-01-26 12:47 ` [PATCH 04/20] RDMA/hw/hfi1/mad: Demote half-completed kernel-doc header fix another Lee Jones
2021-01-26 12:47 ` [PATCH 05/20] RDMA/hw/hfi1/msix: Add description for 'name' and remove superfluous param 'idx' Lee Jones
2021-01-26 12:47 ` [PATCH 06/20] RDMA/sw/rdmavt/mad: Fix misspelling of 'rvt_process_mad()'s 'in_mad_size' param Lee Jones
2021-01-26 12:47 ` [PATCH 07/20] RDMA/sw/rdmavt/qp: Fix kernel-doc formatting problem Lee Jones
2021-01-26 12:47 ` [PATCH 08/20] RDMA/hw/hfi1/netdev_rx: Fix misdocumentation of the 'start_id' param Lee Jones
2021-01-26 12:47 ` [PATCH 09/20] RDMA/hw/hfi1/pcie: Demote kernel-doc abuses Lee Jones
2021-01-26 12:47 ` [PATCH 10/20] RDMA/hw/hfi1/pio_copy: Provide entry for 'pio_copy()'s 'dd' param Lee Jones
2021-01-26 12:47 ` [PATCH 11/20] RDMA/hw/hfi1/rc: Fix a few function documentation issues Lee Jones
2021-01-26 12:47 ` [PATCH 12/20] RDMA/hw/hfi1/qp: Fix some formatting issues and demote kernel-doc abuse Lee Jones
2021-01-26 12:47 ` [PATCH 13/20] RDMA/hw/hfi1/ruc: Fix a small formatting and description issues Lee Jones
2021-01-26 12:47 ` [PATCH 14/20] RDMA/hw/hfi1/sdma: Fix misnaming of 'sdma_send_txlist()'s 'count_out' param Lee Jones
2021-01-26 12:47 ` [PATCH 15/20] RDMA/hw/hfi1/tid_rdma: Fix a plethora of kernel-doc issues Lee Jones
2021-01-26 12:47 ` [PATCH 16/20] RDMA/hw/hfi1/uc: Fix a little doc-rot Lee Jones
2021-01-26 12:47 ` [PATCH 17/20] RDMA/hw/hfi1/ud: Fix a little more doc-rot Lee Jones
2021-01-26 12:47 ` [PATCH 18/20] RDMA/hw/hfi1/user_exp_rcv: Demote half-documented and kernel-doc abuses Lee Jones
2021-01-26 12:47 ` Lee Jones [this message]
2021-01-26 12:47 ` [PATCH 20/20] RDMA/hw/hfi1/rc: Demote incorrectly populated kernel-doc header Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210126124732.3320971-20-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=dennis.dalessandro@cornelisnetworks.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mike.marciniszyn@cornelisnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).