From: Barry Song <song.bao.hua@hisilicon.com>
To: <tglx@linutronix.de>, <dmitry.torokhov@gmail.com>,
<maz@kernel.org>, <gregkh@linuxfoundation.org>,
<linux-input@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <linuxarm@openeuler.org>, Barry Song <song.bao.hua@hisilicon.com>
Subject: [PATCH v4 12/12] Input: tca6416-keypad - request_irq by IRQF_NO_AUTOEN and remove disable_irq
Date: Fri, 29 Jan 2021 11:35:38 +1300 [thread overview]
Message-ID: <20210128223538.20272-13-song.bao.hua@hisilicon.com> (raw)
In-Reply-To: <20210128223538.20272-1-song.bao.hua@hisilicon.com>
disable_irq() after request_irq() still has a time gap in which
interrupts can come. request_irq() with IRQF_NO_AUTOEN flag will
disable IRQ auto-enable because of requesting.
Signed-off-by: Barry Song <song.bao.hua@hisilicon.com>
---
drivers/input/keyboard/tca6416-keypad.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/tca6416-keypad.c b/drivers/input/keyboard/tca6416-keypad.c
index 9b0f9665dcb0..2a9755910065 100644
--- a/drivers/input/keyboard/tca6416-keypad.c
+++ b/drivers/input/keyboard/tca6416-keypad.c
@@ -274,7 +274,7 @@ static int tca6416_keypad_probe(struct i2c_client *client,
error = request_threaded_irq(chip->irqnum, NULL,
tca6416_keys_isr,
IRQF_TRIGGER_FALLING |
- IRQF_ONESHOT,
+ IRQF_ONESHOT | IRQF_NO_AUTOEN,
"tca6416-keypad", chip);
if (error) {
dev_dbg(&client->dev,
@@ -282,7 +282,6 @@ static int tca6416_keypad_probe(struct i2c_client *client,
chip->irqnum, error);
goto fail1;
}
- disable_irq(chip->irqnum);
}
error = input_register_device(input);
--
2.25.1
prev parent reply other threads:[~2021-01-28 22:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 22:35 [PATCH v4 00/12] add IRQF_NO_AUTOEN for request_irq Barry Song
2021-01-28 22:35 ` [PATCH v4 01/12] genirq: " Barry Song
2021-02-09 21:32 ` Song Bao Hua (Barry Song)
2021-01-28 22:35 ` [PATCH v4 02/12] Input: ar1021 - request_irq by IRQF_NO_AUTOEN and remove disable_irq Barry Song
2021-01-28 22:35 ` [PATCH v4 03/12] Input: atmel_mxt_ts " Barry Song
2021-01-28 22:35 ` [PATCH v4 04/12] Input: melfas_mip4 " Barry Song
2021-01-28 22:35 ` [PATCH v4 05/12] Input: bu21029_ts - request_irq by IRQF_NO_AUTOEN and remove irq_set_status_flags Barry Song
2021-01-28 22:35 ` [PATCH v4 06/12] Input: stmfts " Barry Song
2021-01-28 22:35 ` [PATCH v4 07/12] Input: zinitix " Barry Song
2021-01-28 22:35 ` [PATCH v4 08/12] Input: mms114 - request_irq by IRQF_NO_AUTOEN and remove disable_irq Barry Song
2021-01-28 22:35 ` [PATCH v4 09/12] Input: wm831x-ts " Barry Song
2021-01-28 22:35 ` [PATCH v4 10/12] Input: cyttsp " Barry Song
2021-01-28 22:35 ` [PATCH v4 11/12] Input: tegra-kbc " Barry Song
2021-01-28 22:35 ` Barry Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128223538.20272-13-song.bao.hua@hisilicon.com \
--to=song.bao.hua@hisilicon.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@openeuler.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).