From: Kyle Tso <kyletso@google.com>
To: linux@roeck-us.net, heikki.krogerus@linux.intel.com,
gregkh@linuxfoundation.org, hdegoede@redhat.com,
robh+dt@kernel.org
Cc: badhri@google.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Kyle Tso <kyletso@google.com>
Subject: [PATCH v2 3/3] usb: typec: tcpm: Get Sink VDO from fwnode
Date: Sun, 31 Jan 2021 23:18:32 +0800 [thread overview]
Message-ID: <20210131151832.215931-4-kyletso@google.com> (raw)
In-Reply-To: <20210131151832.215931-1-kyletso@google.com>
Commit a079973f462a ("usb: typec: tcpm: Remove tcpc_config
configuration mechanism") removed the tcpc_config which includes the
Sink VDO and it is not yet added back with fwnode. Add it now.
Signed-off-by: Kyle Tso <kyletso@google.com>
---
Changes since v1:
- updated the commit message
drivers/usb/typec/tcpm/tcpm.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index 403a483645dd..84c8a52f8af1 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -5677,6 +5677,18 @@ static int tcpm_fw_get_caps(struct tcpm_port *port,
port->new_source_frs_current = frs_current;
}
+ ret = fwnode_property_read_u32_array(fwnode, "sink-vdos", NULL, 0);
+ if (ret <= 0 && ret != -EINVAL) {
+ return -EINVAL;
+ } else if (ret > 0) {
+ port->nr_snk_vdo = min(ret, VDO_MAX_OBJECTS);
+ ret = fwnode_property_read_u32_array(fwnode, "sink-vdos",
+ port->snk_vdo,
+ port->nr_snk_vdo);
+ if (ret < 0)
+ return -EINVAL;
+ }
+
return 0;
}
--
2.30.0.365.g02bc693789-goog
next prev parent reply other threads:[~2021-01-31 15:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 15:18 [PATCH v2 0/3] common SVDM version and VDO from dt Kyle Tso
2021-01-31 15:18 ` [PATCH v2 1/3] usb: typec: Determine common SVDM Versions Kyle Tso
[not found] ` <8737f4b9-0202-aaf8-f461-93e82624ef0d@roeck-us.net>
2021-02-01 6:00 ` Kyle Tso
2021-01-31 15:18 ` [PATCH v2 2/3] dt-bindings: connector: Add SVDM VDO properties Kyle Tso
2021-01-31 15:18 ` Kyle Tso [this message]
2021-01-31 16:02 ` [PATCH v2 3/3] usb: typec: tcpm: Get Sink VDO from fwnode Guenter Roeck
2021-02-01 5:11 ` Kyle Tso
2021-02-01 5:44 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210131151832.215931-4-kyletso@google.com \
--to=kyletso@google.com \
--cc=badhri@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).