From: Zhiyuan Dai <daizhiyuan@phytium.com.cn>
To: catalin.marinas@arm.com, will@kernel.org
Cc: Dave.Martin@arm.com, broonie@kernel.org, mark.rutland@arm.com,
linux-kernel@vger.kernel.org,
Zhiyuan Dai <daizhiyuan@phytium.com.cn>
Subject: [PATCH] arm64/kernel: minor coding style tweaks
Date: Wed, 3 Feb 2021 13:19:12 +0800 [thread overview]
Message-ID: <1612329552-17977-1-git-send-email-daizhiyuan@phytium.com.cn> (raw)
Fixed two coding style issues in kernel/trap.c
1. spaces required around that '='
2. Missing a blank line after declarations
Signed-off-by: Zhiyuan Dai <daizhiyuan@phytium.com.cn>
---
arch/arm64/kernel/traps.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c
index 6895ce7..4001a39 100644
--- a/arch/arm64/kernel/traps.c
+++ b/arch/arm64/kernel/traps.c
@@ -45,7 +45,7 @@
#include <asm/system_misc.h>
#include <asm/sysreg.h>
-static const char *handler[]= {
+static const char *handler[] = {
"Synchronous Abort",
"IRQ",
"FIQ",
@@ -318,6 +318,7 @@ static int call_undef_hook(struct pt_regs *regs)
} else if (compat_thumb_mode(regs)) {
/* 16-bit Thumb instruction */
__le16 instr_le;
+
if (get_user(instr_le, (__le16 __user *)pc))
goto exit;
instr = le16_to_cpu(instr_le);
@@ -332,6 +333,7 @@ static int call_undef_hook(struct pt_regs *regs)
} else {
/* 32-bit ARM instruction */
__le32 instr_le;
+
if (get_user(instr_le, (__le32 __user *)pc))
goto exit;
instr = le32_to_cpu(instr_le);
--
1.8.3.1
next reply other threads:[~2021-02-03 5:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-03 5:19 Zhiyuan Dai [this message]
2021-02-03 11:31 ` [PATCH] arm64/kernel: minor coding style tweaks Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1612329552-17977-1-git-send-email-daizhiyuan@phytium.com.cn \
--to=daizhiyuan@phytium.com.cn \
--cc=Dave.Martin@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).