From: <alexandru.tachici@analog.com>
To: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>
Cc: <jic23@kernel.org>, <robh+dt@kernel.org>
Subject: [PATCH v2 2/2] dt-bindings: iio: adc: ad7124: add config nodes
Date: Thu, 4 Feb 2021 13:35:51 +0200 [thread overview]
Message-ID: <20210204113551.68744-3-alexandru.tachici@analog.com> (raw)
In-Reply-To: <20210204113551.68744-1-alexandru.tachici@analog.com>
From: Alexandru Tachici <alexandru.tachici@analog.com>
Document use of configurations in device-tree bindings.
Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
---
.../bindings/iio/adc/adi,ad7124.yaml | 72 +++++++++++++++----
1 file changed, 57 insertions(+), 15 deletions(-)
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7124.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7124.yaml
index fb3d0dae9bae..330064461d0a 100644
--- a/Documentation/devicetree/bindings/iio/adc/adi,ad7124.yaml
+++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7124.yaml
@@ -62,20 +62,19 @@ required:
- interrupts
patternProperties:
- "^channel@([0-9]|1[0-5])$":
- $ref: "adc.yaml"
+ "^config@(2[0-7])$":
type: object
description: |
- Represents the external channels which are connected to the ADC.
+ Represents a channel configuration.
+ See Documentation/devicetree/bindings/iio/adc/adc.txt.
properties:
reg:
description: |
- The channel number. It can have up to 8 channels on ad7124-4
- and 16 channels on ad7124-8, numbered from 0 to 15.
+ The config number. It can have up to 8 configuration.
items:
- minimum: 0
- maximum: 15
+ minimum: 20
+ maximum: 27
adi,reference-select:
description: |
@@ -88,8 +87,6 @@ patternProperties:
$ref: /schemas/types.yaml#/definitions/uint32
enum: [0, 1, 3]
- diff-channels: true
-
bipolar: true
adi,buffered-positive:
@@ -100,6 +97,35 @@ patternProperties:
description: Enable buffered mode for negative input.
type: boolean
+ additionalProperties: false
+
+ "^channel@([0-9]|1[0-5])$":
+ type: object
+ description: |
+ Represents the external channels which are connected to the ADC.
+ See Documentation/devicetree/bindings/iio/adc/adc.txt.
+
+ properties:
+ reg:
+ description: |
+ The channel number. It can have up to 8 channels on ad7124-4
+ and 16 channels on ad7124-8, numbered from 0 to 15.
+ items:
+ minimum: 0
+ maximum: 15
+
+ diff-channels: true
+
+ adi,configuration:
+ description: |
+ The devices has 8 configuration and ad7124-8 support up to 16 unipolar channels.
+ Each channel can be assigned one configuration. Some channels will be sharing the
+ same configuration.
+ allOf:
+ - $ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 20
+ maximum: 27
+
required:
- reg
- diff-channels
@@ -127,30 +153,46 @@ examples:
#address-cells = <1>;
#size-cells = <0>;
- channel@0 {
- reg = <0>;
- diff-channels = <0 1>;
+ config@20 {
+ reg = <20>;
adi,reference-select = <0>;
adi,buffered-positive;
};
- channel@1 {
- reg = <1>;
+ config@21 {
+ reg = <21>;
bipolar;
- diff-channels = <2 3>;
adi,reference-select = <0>;
adi,buffered-positive;
adi,buffered-negative;
};
+ config@22 {
+ reg = <22>;
+ };
+
+ channel@0 {
+ reg = <0>;
+ diff-channels = <0 1>;
+ adi,configuration = <20>;
+ };
+
+ channel@1 {
+ reg = <1>;
+ diff-channels = <2 3>;
+ adi,configuration = <21>;
+ };
+
channel@2 {
reg = <2>;
diff-channels = <4 5>;
+ adi,configuration = <22>;
};
channel@3 {
reg = <3>;
diff-channels = <6 7>;
+ adi,configuration = <22>;
};
};
};
--
2.20.1
next prev parent reply other threads:[~2021-02-04 11:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-04 11:35 [PATCH v2 0/2] iio: adc: ad7124: allow 16 channels alexandru.tachici
2021-02-04 11:35 ` [PATCH v2 1/2] " alexandru.tachici
2021-02-06 15:36 ` Jonathan Cameron
2021-02-04 11:35 ` alexandru.tachici [this message]
2021-02-04 15:20 ` [PATCH v2 2/2] dt-bindings: iio: adc: ad7124: add config nodes Rob Herring
2021-02-06 15:26 ` Jonathan Cameron
2021-02-08 16:06 ` Rob Herring
2021-02-06 15:30 ` [PATCH v2 0/2] iio: adc: ad7124: allow 16 channels Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210204113551.68744-3-alexandru.tachici@analog.com \
--to=alexandru.tachici@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).