From: Yafang Shao <laoar.shao@gmail.com>
To: andriy.shevchenko@linux.intel.com, david@redhat.com,
vbabka@suse.cz, willy@infradead.org, cl@linux.com,
linmiaohe@huawei.com, penberg@kernel.org, rientjes@google.com,
iamjoonsoo.kim@lge.com, akpm@linux-foundation.org,
pmladek@suse.com, rostedt@goodmis.org,
sergey.senozhatsky@gmail.com, joe@perches.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Yafang Shao <laoar.shao@gmail.com>
Subject: [PATCH v3 1/3] mm, slub: use pGp to print page flags
Date: Mon, 8 Feb 2021 18:14:37 +0800 [thread overview]
Message-ID: <20210208101439.55474-2-laoar.shao@gmail.com> (raw)
In-Reply-To: <20210208101439.55474-1-laoar.shao@gmail.com>
As pGp has been already introduced in printk, we'd better use it to make
the output human readable.
Before this change, the output is,
[ 6155.716018] INFO: Slab 0x000000004027dd4f objects=33 used=3 fp=0x000000008cd1579c flags=0x17ffffc0010200
While after this change, the output is,
[ 8846.517809] INFO: Slab 0x00000000f42a2c60 objects=33 used=3 fp=0x0000000060d32ca8 flags=0x17ffffc0010200(slab|head)
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Vlastimil Babka <vbabka@suse.cz>
Acked-by: David Rientjes <rientjes@google.com>
Acked-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
---
mm/slub.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 34dcc09e2ec9..87ff086e68a4 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -638,8 +638,9 @@ void print_tracking(struct kmem_cache *s, void *object)
static void print_page_info(struct page *page)
{
- pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=0x%04lx\n",
- page, page->objects, page->inuse, page->freelist, page->flags);
+ pr_err("INFO: Slab 0x%p objects=%u used=%u fp=0x%p flags=%#lx(%pGp)\n",
+ page, page->objects, page->inuse, page->freelist,
+ page->flags, &page->flags);
}
--
2.17.1
next prev parent reply other threads:[~2021-02-08 10:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 10:14 [PATCH v3 0/3] mm, vsprintf: introduce new format to dump full information of page flags Yafang Shao
2021-02-08 10:14 ` Yafang Shao [this message]
2021-02-08 12:21 ` [PATCH v3 1/3] mm, slub: use pGp to print " Matthew Wilcox
2021-02-09 1:04 ` Miaohe Lin
2021-02-08 10:14 ` [PATCH v3 2/3] mm, slub: don't combine pr_err with INFO Yafang Shao
2021-02-08 16:33 ` Vlastimil Babka
2021-02-08 17:26 ` Matthew Wilcox
2021-02-08 17:59 ` Vlastimil Babka
2021-02-09 1:06 ` Miaohe Lin
2021-02-08 10:14 ` [PATCH v3 3/3] vsprintf: introduce new format to dump full information of page flags Yafang Shao
2021-02-08 12:20 ` [PATCH v3 0/3] mm, " Matthew Wilcox
2021-02-08 13:25 ` Andy Shevchenko
2021-02-08 14:02 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208101439.55474-2-laoar.shao@gmail.com \
--to=laoar.shao@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=cl@linux.com \
--cc=david@redhat.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=joe@perches.com \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=pmladek@suse.com \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).