[RFC/PATCH,v2,08/16] mfd: bcm2835-pm: Add support for BCM2711
diff mbox series

Message ID 20210209125912.3398-9-nsaenzjulienne@suse.de
State New, archived
Headers show
Series
  • Raspberry PI 4 V3D enablement
Related show

Commit Message

Nicolas Saenz Julienne Feb. 9, 2021, 12:59 p.m. UTC
In BCM2711 the new Argon ASB took over V3D. The old ASB is still present
with the ISP and H264 bits, and V3D is in the same place in the new ASB
as the old one.

As per the devicetree bindings, BCM2711 will provide both the old and
new ASB resources, so get both of them and pass them into
'bcm2835-power,' which will take care of selecting which one to use
accordingly.

Since the Argon ASB's resources were being provided prior to formalizing
the bindings[1], also support the old firmwares that didn't use
'reg-names.'

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

[1] See: 7dbe8c62ceeb ("ARM: dts: Add minimal Raspberry Pi 4 support")

---

Changes since v1:
 - Use reg-names
 - Correct ASB names

 drivers/mfd/bcm2835-pm.c       | 25 +++++++++++++++++++++++--
 include/linux/mfd/bcm2835-pm.h |  1 +
 2 files changed, 24 insertions(+), 2 deletions(-)

Patch
diff mbox series

diff --git a/drivers/mfd/bcm2835-pm.c b/drivers/mfd/bcm2835-pm.c
index 182ccdc2a06b..26666ad11f12 100644
--- a/drivers/mfd/bcm2835-pm.c
+++ b/drivers/mfd/bcm2835-pm.c
@@ -6,6 +6,7 @@ 
  * the WDT and power drivers.
  */
 
+#include <linux/bits.h>
 #include <linux/delay.h>
 #include <linux/io.h>
 #include <linux/mfd/bcm2835-pm.h>
@@ -17,6 +18,9 @@ 
 #include <linux/types.h>
 #include <linux/watchdog.h>
 
+#define BCM2835		BIT(1)
+#define BCM2711		BIT(2)
+
 static const struct mfd_cell bcm2835_pm_devs[] = {
 	{ .name = "bcm2835-wdt" },
 };
@@ -28,6 +32,8 @@  static const struct mfd_cell bcm2835_power_devs[] = {
 static int bcm2835_pm_get_pdata(struct platform_device *pdev,
 				struct bcm2835_pm *pm)
 {
+	bool is_bcm2711 = (uintptr_t)device_get_match_data(pm->dev) & BCM2711;
+
 	/* If no 'reg-names' property is found we can assume we're using old
 	 * firmware.
 	 */
@@ -41,6 +47,10 @@  static int bcm2835_pm_get_pdata(struct platform_device *pdev,
 		pm->rpivid_asb = devm_platform_ioremap_resource(pdev, 1);
 		if (IS_ERR(pm->rpivid_asb))
 			pm->rpivid_asb = NULL;
+
+		pm->argon_asb = devm_platform_ioremap_resource(pdev, 2);
+		if (IS_ERR(pm->argon_asb))
+			pm->argon_asb = NULL;
 	} else {
 		pm->base = devm_platform_ioremap_resource_byname(pdev, "pm");
 		if (IS_ERR(pm->base))
@@ -50,6 +60,16 @@  static int bcm2835_pm_get_pdata(struct platform_device *pdev,
 								       "rpivid_asb");
 		if (IS_ERR(pm->base))
 			pm->rpivid_asb = NULL;
+
+		pm->argon_asb = devm_platform_ioremap_resource_byname(pdev,
+								      "argon_asb");
+		if (IS_ERR(pm->base))
+			pm->argon_asb = NULL;
+
+		if (pm->argon_asb && !is_bcm2711) {
+			dev_err(pm->dev, "Argon ASB support only present in BCM2711\n");
+			return -EINVAL;
+		}
 	}
 
 	return 0;
@@ -90,8 +110,9 @@  static int bcm2835_pm_probe(struct platform_device *pdev)
 }
 
 static const struct of_device_id bcm2835_pm_of_match[] = {
-	{ .compatible = "brcm,bcm2835-pm-wdt", },
-	{ .compatible = "brcm,bcm2835-pm", },
+	{ .compatible = "brcm,bcm2835-pm-wdt", .data = (void *)BCM2835},
+	{ .compatible = "brcm,bcm2835-pm", .data = (void *)BCM2835},
+	{ .compatible = "brcm,bcm2711-pm", .data = (void *)BCM2711},
 	{},
 };
 MODULE_DEVICE_TABLE(of, bcm2835_pm_of_match);
diff --git a/include/linux/mfd/bcm2835-pm.h b/include/linux/mfd/bcm2835-pm.h
index ed4bd548db09..89fb2b5cdc1a 100644
--- a/include/linux/mfd/bcm2835-pm.h
+++ b/include/linux/mfd/bcm2835-pm.h
@@ -9,6 +9,7 @@  struct bcm2835_pm {
 	struct device *dev;
 	void __iomem *base;
 	void __iomem *rpivid_asb;
+	void __iomem *argon_asb;
 };
 
 #endif /* BCM2835_MFD_PM_H */