From: Nikita Shubin <nikita.shubin@maquefel.me>
To: unlisted-recipients:; (no To-header on input)
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Nikita Shubin <nikita.shubin@maquefel.me>,
Linus Walleij <linus.walleij@linaro.org>,
Alexander Sverdlin <alexander.sverdlin@gmail.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v6 4/7] gpio: ep93xx: drop to_irq binding
Date: Tue, 9 Feb 2021 16:31:07 +0300 [thread overview]
Message-ID: <20210209133110.7383-5-nikita.shubin@maquefel.me> (raw)
In-Reply-To: <20210209133110.7383-1-nikita.shubin@maquefel.me>
As ->to_irq is redefined in gpiochip_add_irqchip, having it defined in
driver is useless, so let's drop it.
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail.com>
Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
---
drivers/gpio/gpio-ep93xx.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpio/gpio-ep93xx.c b/drivers/gpio/gpio-ep93xx.c
index 3dea4ce929ab..a69bf3100f99 100644
--- a/drivers/gpio/gpio-ep93xx.c
+++ b/drivers/gpio/gpio-ep93xx.c
@@ -318,11 +318,6 @@ static int ep93xx_gpio_set_config(struct gpio_chip *gc, unsigned offset,
return 0;
}
-static int ep93xx_gpio_f_to_irq(struct gpio_chip *gc, unsigned offset)
-{
- return EP93XX_GPIO_F_IRQ_BASE + offset;
-}
-
static void ep93xx_init_irq_chip(struct device *dev, struct irq_chip *ic)
{
ic->irq_ack = ep93xx_gpio_irq_ack;
@@ -415,7 +410,6 @@ static int ep93xx_gpio_add_bank(struct ep93xx_gpio_chip *egc,
}
girq->default_type = IRQ_TYPE_NONE;
girq->handler = handle_level_irq;
- gc->to_irq = ep93xx_gpio_f_to_irq;
girq->first = EP93XX_GPIO_F_IRQ_BASE;
}
--
2.26.2
next prev parent reply other threads:[~2021-02-09 13:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 13:31 [PATCH v6 0/7] gpio: ep93xx: fixes series patch Nikita Shubin
2021-02-09 13:31 ` [PATCH v6 1/7] gpio: ep93xx: fix BUG_ON port F usage Nikita Shubin
2021-02-09 14:00 ` Andy Shevchenko
2021-02-09 13:31 ` [PATCH v6 2/7] gpio: ep93xx: Fix single irqchip with multi gpiochips Nikita Shubin
2021-02-09 22:03 ` Alexander Sverdlin
2021-02-09 13:31 ` [PATCH v6 3/7] gpio: ep93xx: Fix wrong irq numbers in port F Nikita Shubin
2021-02-09 13:31 ` Nikita Shubin [this message]
2021-02-09 13:31 ` [PATCH v6 5/7] gpio: ep93xx: Fix typo s/hierarchial/hierarchical Nikita Shubin
2021-02-09 13:31 ` [PATCH v6 6/7] gpio: ep93xx: refactor ep93xx_gpio_add_bank Nikita Shubin
2021-02-09 13:31 ` [PATCH v6 7/7] gpio: ep93xx: refactor base IRQ number Nikita Shubin
2021-02-09 14:02 ` [PATCH v6 0/7] gpio: ep93xx: fixes series patch Andy Shevchenko
2021-02-10 13:50 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210209133110.7383-5-nikita.shubin@maquefel.me \
--to=nikita.shubin@maquefel.me \
--cc=alexander.sverdlin@gmail.com \
--cc=andy.shevchenko@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).