From: Alex Elder <elder@linaro.org>
To: davem@davemloft.net, kuba@kernel.org
Cc: elder@kernel.org, evgreen@chromium.org,
bjorn.andersson@linaro.org, cpratapa@codeaurora.org,
subashab@codeaurora.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next 2/5] net: ipa: don't report EPROBE_DEFER error
Date: Wed, 10 Feb 2021 16:33:17 -0600 [thread overview]
Message-ID: <20210210223320.11269-3-elder@linaro.org> (raw)
In-Reply-To: <20210210223320.11269-1-elder@linaro.org>
When initializing the IPA core clock and interconnects, it's
possible we'll get an EPROBE_DEFER error. This isn't really an
error, it's just means we need to be re-probed later.
Check the return code when initializing these, and if it's
EPROBE_DEFER, skip printing the error message.
Signed-off-by: Alex Elder <elder@linaro.org>
---
drivers/net/ipa/ipa_clock.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ipa/ipa_clock.c b/drivers/net/ipa/ipa_clock.c
index 354675a643db5..9c845f9bb318e 100644
--- a/drivers/net/ipa/ipa_clock.c
+++ b/drivers/net/ipa/ipa_clock.c
@@ -68,8 +68,9 @@ static int ipa_interconnect_init_one(struct device *dev,
if (IS_ERR(path)) {
int ret = PTR_ERR(path);
- dev_err(dev, "error %d getting %s interconnect\n", ret,
- data->name);
+ if (ret != -EPROBE_DEFER)
+ dev_err(dev, "error %d getting %s interconnect\n", ret,
+ data->name);
return ret;
}
@@ -281,7 +282,10 @@ ipa_clock_init(struct device *dev, const struct ipa_clock_data *data)
clk = clk_get(dev, "core");
if (IS_ERR(clk)) {
- dev_err(dev, "error %ld getting core clock\n", PTR_ERR(clk));
+ ret = PTR_ERR(clk);
+ if (ret != -EPROBE_DEFER)
+ dev_err(dev, "error %d getting core clock\n", ret);
+
return ERR_CAST(clk);
}
--
2.20.1
next prev parent reply other threads:[~2021-02-10 22:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 22:33 [PATCH net-next 0/5] net: ipa: some more cleanup Alex Elder
2021-02-10 22:33 ` [PATCH net-next 1/5] net: ipa: use a separate pointer for adjusted GSI memory Alex Elder
2021-02-10 22:33 ` Alex Elder [this message]
2021-02-10 22:33 ` [PATCH net-next 3/5] net: ipa: fix register write command validation Alex Elder
2021-02-10 22:33 ` [PATCH net-next 4/5] net: ipa: introduce ipa_table_hash_support() Alex Elder
2021-02-10 22:33 ` [PATCH net-next 5/5] net: ipa: introduce gsi_channel_initialized() Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210210223320.11269-3-elder@linaro.org \
--to=elder@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=evgreen@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).