From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com
Cc: linux-rpi-kernel@lists.infradead.org, phil@raspberrypi.com,
wahrenst@gmx.net, mripard@kernel.org, eric@anholt.net,
robh@kernel.org
Subject: [PATCH v3 09/15] soc: bcm: bcm2835-power: Bypass power_on/off() calls
Date: Wed, 17 Feb 2021 12:48:04 +0100 [thread overview]
Message-ID: <20210217114811.22069-10-nsaenzjulienne@suse.de> (raw)
In-Reply-To: <20210217114811.22069-1-nsaenzjulienne@suse.de>
Bypass power_on/power_off() when running on BCM2711 as they are not
needed.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
Changes since v2:
- Correct names
drivers/soc/bcm/bcm2835-power.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/soc/bcm/bcm2835-power.c b/drivers/soc/bcm/bcm2835-power.c
index eea31f75dc64..b65a39cc2788 100644
--- a/drivers/soc/bcm/bcm2835-power.c
+++ b/drivers/soc/bcm/bcm2835-power.c
@@ -197,6 +197,10 @@ static int bcm2835_power_power_off(struct bcm2835_power_domain *pd, u32 pm_reg)
{
struct bcm2835_power *power = pd->power;
+ /* We don't run this on BCM2711 */
+ if (power->rpivid_asb)
+ return 0;
+
/* Enable functional isolation */
PM_WRITE(pm_reg, PM_READ(pm_reg) & ~PM_ISFUNC);
@@ -218,6 +222,10 @@ static int bcm2835_power_power_on(struct bcm2835_power_domain *pd, u32 pm_reg)
int inrush;
bool powok;
+ /* We don't run this on BCM2711 */
+ if (power->rpivid_asb)
+ return 0;
+
/* If it was already powered on by the fw, leave it that way. */
if (PM_READ(pm_reg) & PM_POWUP)
return 0;
--
2.30.0
next prev parent reply other threads:[~2021-02-17 11:53 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 11:47 [PATCH v3 00/15] Raspberry PI 4 V3D enablement Nicolas Saenz Julienne
2021-02-17 11:47 ` [PATCH v3 01/15] dt-bindings: soc: bcm: bcm2835-pm: Convert bindings to DT schema Nicolas Saenz Julienne
2021-03-05 22:28 ` Rob Herring
2021-02-17 11:47 ` [PATCH v3 02/15] dt-bindings: soc: bcm: bcm2835-pm: Introduce reg-names Nicolas Saenz Julienne
2021-03-05 22:28 ` Rob Herring
2021-02-17 11:47 ` [PATCH v3 03/15] dt-bindings: soc: bcm: bcm2835-pm: Add support for bcm2711 Nicolas Saenz Julienne
2021-02-17 11:47 ` [PATCH v3 04/15] ARM: dts: bcm2835/bcm2711: Introduce reg-names in watchdog node Nicolas Saenz Julienne
2021-02-17 11:48 ` [PATCH v3 05/15] ARM: dts: bcm2711: Use proper compatible in PM/Watchdog node Nicolas Saenz Julienne
2021-02-17 11:48 ` [PATCH v3 06/15] mfd: bcm2835-pm: Use 'reg-names' to get resources Nicolas Saenz Julienne
2021-02-17 11:48 ` [PATCH v3 07/15] mfd: bcm2835-pm: Add support for BCM2711 Nicolas Saenz Julienne
2021-02-17 11:48 ` [PATCH v3 08/15] soc: bcm: bcm2835-power: Add support for BCM2711's RPiVid ASB Nicolas Saenz Julienne
2021-02-17 11:48 ` Nicolas Saenz Julienne [this message]
2021-02-17 11:48 ` [PATCH v3 10/15] dt-bindings: gpu: v3d: Add BCM2711's compatible Nicolas Saenz Julienne
2021-02-17 11:48 ` [PATCH v3 11/15] drm/v3d: Get rid of pm code Nicolas Saenz Julienne
2021-02-17 11:48 ` [PATCH v3 12/15] drm/v3d: Add support for bcm2711 Nicolas Saenz Julienne
2021-02-17 11:48 ` [PATCH v3 13/15] ARM: dts: bcm2711: Enable V3D Nicolas Saenz Julienne
2021-02-17 11:48 ` [PATCH v3 14/15] ARM: configs: Enable DRM_V3D Nicolas Saenz Julienne
2021-02-17 11:48 ` [PATCH v3 15/15] arm64: config: " Nicolas Saenz Julienne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210217114811.22069-10-nsaenzjulienne@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mripard@kernel.org \
--cc=phil@raspberrypi.com \
--cc=rjui@broadcom.com \
--cc=robh@kernel.org \
--cc=sbranden@broadcom.com \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).