[v3] drivers: hv: Fix whitespace errors
diff mbox series

Message ID 20210219171311.421961-1-vasanth3g@gmail.com
State Accepted
Commit f850a4cad27c3cfeb89fd28c768d5e6821bf178f
Headers show
Series
  • [v3] drivers: hv: Fix whitespace errors
Related show

Commit Message

Vasanth Feb. 19, 2021, 5:13 p.m. UTC
Fixed checkpatch warning and errors on hv driver.

Signed-off-by: Vasanth <vasanth3g@gmail.com>
---

changes in v2:
*  Added commit message
*  Revised Subject

 drivers/hv/channel.c    | 2 +-
 drivers/hv/connection.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Michael Kelley Feb. 19, 2021, 5:30 p.m. UTC | #1
From: Vasanth <vasanth3g@gmail.com> Sent: Friday, February 19, 2021 9:13 AM
> To: KY Srinivasan <kys@microsoft.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>; Stephen Hemminger
> <sthemmin@microsoft.com>; wei.liu@kernel.org; linux-hyperv@vger.kernel.org; linux-
> kernel@vger.kernel.org; Vasanth <vasanth3g@gmail.com>
> Subject: [PATCH v3] drivers: hv: Fix whitespace errors
> 
> Fixed checkpatch warning and errors on hv driver.
> 
> Signed-off-by: Vasanth <vasanth3g@gmail.com>
> ---
> 
> changes in v2:
> *  Added commit message
> *  Revised Subject
> 
>  drivers/hv/channel.c    | 2 +-
>  drivers/hv/connection.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
> index 6fb0c76bfbf8..587234065e37 100644
> --- a/drivers/hv/channel.c
> +++ b/drivers/hv/channel.c
> @@ -385,7 +385,7 @@ static int create_gpadl_header(enum hv_gpadl_type type, void
> *kbuffer,
>   * @kbuffer: from kmalloc or vmalloc
>   * @size: page-size multiple
>   * @send_offset: the offset (in bytes) where the send ring buffer starts,
> - * 		 should be 0 for BUFFER type gpadl
> + *              should be 0 for BUFFER type gpadl
>   * @gpadl_handle: some funky thing
>   */
>  static int __vmbus_establish_gpadl(struct vmbus_channel *channel,
> diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
> index 11170d9a2e1a..3760cbb6ffaf 100644
> --- a/drivers/hv/connection.c
> +++ b/drivers/hv/connection.c
> @@ -28,7 +28,7 @@ struct vmbus_connection vmbus_connection = {
>  	.conn_state		= DISCONNECTED,
>  	.next_gpadl_handle	= ATOMIC_INIT(0xE1E10),
> 
> -	.ready_for_suspend_event= COMPLETION_INITIALIZER(
> +	.ready_for_suspend_event = COMPLETION_INITIALIZER(
>  				  vmbus_connection.ready_for_suspend_event),
>  	.ready_for_resume_event	= COMPLETION_INITIALIZER(
>  				  vmbus_connection.ready_for_resume_event),
> --
> 2.25.1

Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Wei Liu March 2, 2021, 7:06 p.m. UTC | #2
On Fri, Feb 19, 2021 at 05:30:36PM +0000, Michael Kelley wrote:
> From: Vasanth <vasanth3g@gmail.com> Sent: Friday, February 19, 2021 9:13 AM
> > To: KY Srinivasan <kys@microsoft.com>
> > Cc: Haiyang Zhang <haiyangz@microsoft.com>; Stephen Hemminger
> > <sthemmin@microsoft.com>; wei.liu@kernel.org; linux-hyperv@vger.kernel.org; linux-
> > kernel@vger.kernel.org; Vasanth <vasanth3g@gmail.com>
> > Subject: [PATCH v3] drivers: hv: Fix whitespace errors
> > 
> > Fixed checkpatch warning and errors on hv driver.
> > 
> > Signed-off-by: Vasanth <vasanth3g@gmail.com>

Vasanth, normally people put their full name in the SoB. Do you want to
do that too?

There is no need to resend. Just let me know what you think.


> > ---
> 
> Reviewed-by: Michael Kelley <mikelley@microsoft.com>

Thanks Michael.

I will pick up this patch within this week.

Wei.

Patch
diff mbox series

diff --git a/drivers/hv/channel.c b/drivers/hv/channel.c
index 6fb0c76bfbf8..587234065e37 100644
--- a/drivers/hv/channel.c
+++ b/drivers/hv/channel.c
@@ -385,7 +385,7 @@  static int create_gpadl_header(enum hv_gpadl_type type, void *kbuffer,
  * @kbuffer: from kmalloc or vmalloc
  * @size: page-size multiple
  * @send_offset: the offset (in bytes) where the send ring buffer starts,
- * 		 should be 0 for BUFFER type gpadl
+ *              should be 0 for BUFFER type gpadl
  * @gpadl_handle: some funky thing
  */
 static int __vmbus_establish_gpadl(struct vmbus_channel *channel,
diff --git a/drivers/hv/connection.c b/drivers/hv/connection.c
index 11170d9a2e1a..3760cbb6ffaf 100644
--- a/drivers/hv/connection.c
+++ b/drivers/hv/connection.c
@@ -28,7 +28,7 @@  struct vmbus_connection vmbus_connection = {
 	.conn_state		= DISCONNECTED,
 	.next_gpadl_handle	= ATOMIC_INIT(0xE1E10),
 
-	.ready_for_suspend_event= COMPLETION_INITIALIZER(
+	.ready_for_suspend_event = COMPLETION_INITIALIZER(
 				  vmbus_connection.ready_for_suspend_event),
 	.ready_for_resume_event	= COMPLETION_INITIALIZER(
 				  vmbus_connection.ready_for_resume_event),