From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: alsa-devel@alsa-project.org
Cc: tiwai@suse.de, broonie@kernel.org, linux-kernel@vger.kernel.org,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Timur Tabi <timur@kernel.org>,
Nicolin Chen <nicoleotsuka@gmail.com>,
Xiubo Li <Xiubo.Lee@gmail.com>,
Fabio Estevam <festevam@gmail.com>,
Shengjiu Wang <shengjiu.wang@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linuxppc-dev@lists.ozlabs.org (open list:FREESCALE SOC SOUND
DRIVERS)
Subject: [PATCH 8/9] ASoC: fsl: mpc8610: remove useless assignment
Date: Fri, 19 Feb 2021 17:29:36 -0600 [thread overview]
Message-ID: <20210219232937.6440-9-pierre-louis.bossart@linux.intel.com> (raw)
In-Reply-To: <20210219232937.6440-1-pierre-louis.bossart@linux.intel.com>
cppcheck warning:
sound/soc/fsl/mpc8610_hpcd.c:333:6: style: Redundant initialization
for 'ret'. The initialized value is overwritten before it is
read. [redundantInitialization]
ret = fsl_asoc_get_dma_channel(np, "fsl,playback-dma",
^
sound/soc/fsl/mpc8610_hpcd.c:193:10: note: ret is initialized
int ret = -ENODEV;
^
sound/soc/fsl/mpc8610_hpcd.c:333:6: note: ret is overwritten
ret = fsl_asoc_get_dma_channel(np, "fsl,playback-dma",
^
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
---
sound/soc/fsl/mpc8610_hpcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
index eccc833390d4..58b9ca3c4da0 100644
--- a/sound/soc/fsl/mpc8610_hpcd.c
+++ b/sound/soc/fsl/mpc8610_hpcd.c
@@ -190,7 +190,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
struct device_node *codec_np = NULL;
struct mpc8610_hpcd_data *machine_data;
struct snd_soc_dai_link_component *comp;
- int ret = -ENODEV;
+ int ret;
const char *sprop;
const u32 *iprop;
--
2.25.1
next prev parent reply other threads:[~2021-02-19 23:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 23:29 [PATCH 0/9] ASoC: fsl: remove cppcheck warnings Pierre-Louis Bossart
2021-02-19 23:29 ` [PATCH 1/9] ASoC: fsl: fsl_asrc: remove useless assignment Pierre-Louis Bossart
2021-02-19 23:29 ` [PATCH 2/9] ASoC: fsl: fsl_dma: remove unused variable Pierre-Louis Bossart
2021-02-19 23:29 ` [PATCH 3/9] ASoC: fsl: fsl_easrc: remove useless assignments Pierre-Louis Bossart
2021-02-19 23:29 ` [PATCH 4/9] ASoC: fsl: fsl_esai: clarify expression Pierre-Louis Bossart
2021-02-19 23:29 ` [PATCH 5/9] ASoC: fsl: fsl_ssi: remove unnecessary tests Pierre-Louis Bossart
2021-02-19 23:29 ` [PATCH 6/9] ASoC: fsl: imx-hdmi: remove unused structure members Pierre-Louis Bossart
2021-02-19 23:29 ` [PATCH 7/9] ASoC: fsl: mpc5200: signed parameter in snprintf format Pierre-Louis Bossart
2021-02-19 23:29 ` Pierre-Louis Bossart [this message]
2021-02-19 23:29 ` [PATCH 9/9] ASoC: fsl: p1022_ds: remove useless assignment Pierre-Louis Bossart
2021-03-01 23:34 ` [PATCH 0/9] ASoC: fsl: remove cppcheck warnings Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210219232937.6440-9-pierre-louis.bossart@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=Xiubo.Lee@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=festevam@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nicoleotsuka@gmail.com \
--cc=perex@perex.cz \
--cc=shengjiu.wang@gmail.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).