phy: ti: j721e-wiz: add missing call to of_node_put()
diff mbox series

Message ID 1614244674-66556-1-git-send-email-yang.lee@linux.alibaba.com
State Accepted
Commit f26fde369c3d59e5711ff35a08c244888db137bb
Headers show
Series
  • phy: ti: j721e-wiz: add missing call to of_node_put()
Related show

Commit Message

Yang Li Feb. 25, 2021, 9:17 a.m. UTC
In one of the error paths of the for_each_child_of_node() loop in
of_property_read_u32, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/phy/ti/phy-j721e-wiz.c:786:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 795.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 drivers/phy/ti/phy-j721e-wiz.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Vinod Koul March 2, 2021, 12:40 p.m. UTC | #1
On 25-02-21, 17:17, Yang Li wrote:
> In one of the error paths of the for_each_child_of_node() loop in
> of_property_read_u32, add missing call to of_node_put().
> 
> Fix the following coccicheck warning:
> ./drivers/phy/ti/phy-j721e-wiz.c:786:1-23: WARNING: Function
> "for_each_child_of_node" should have of_node_put() before return around
> line 795.

Applied, thanks

Patch
diff mbox series

diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c
index c9cfafe..448d8d1 100644
--- a/drivers/phy/ti/phy-j721e-wiz.c
+++ b/drivers/phy/ti/phy-j721e-wiz.c
@@ -789,6 +789,7 @@  static int wiz_get_lane_phy_types(struct device *dev, struct wiz *wiz)
 
 		ret = of_property_read_u32(subnode, "reg", &reg);
 		if (ret) {
+			of_node_put(subnode);
 			dev_err(dev,
 				"%s: Reading \"reg\" from \"%s\" failed: %d\n",
 				__func__, subnode->name, ret);