linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@dabbelt.com>
To: akpm@linux-foundation.org, atishp@atishpatra.org
Cc: peterz@infradead.org, srikar@linux.vnet.ibm.com,
	valentin.schneider@arm.com, vbabka@suse.cz, mpe@ellerman.id.au,
	Palmer Dabbelt <palmerdabbelt@google.com>,
	linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	kernel-team@android.com
Subject: [PATCH 2/2] topology: Guard node_reclaim_distance with CONFIFG_NUMA
Date: Fri, 26 Feb 2021 12:17:21 -0800	[thread overview]
Message-ID: <20210226201721.510177-2-palmer@dabbelt.com> (raw)
In-Reply-To: <20210226201721.510177-1-palmer@dabbelt.com>

From: Palmer Dabbelt <palmerdabbelt@google.com>

This is only defined (and useful) for CONFIG_NUMA, but isn't
conditionally declared.  This makes users a bit more of a headache to
track down.

Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
---
 include/linux/topology.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/topology.h b/include/linux/topology.h
index 7634cd737061..15f02281bdf0 100644
--- a/include/linux/topology.h
+++ b/include/linux/topology.h
@@ -73,7 +73,9 @@ int arch_update_cpu_topology(void);
  * *improves* if allowed to reclaim memory and load balance tasks
  * between NUMA nodes 2-hops apart.
  */
+#ifdef CONFIG_NUMA
 extern int __read_mostly node_reclaim_distance;
+#endif
 
 #ifndef PENALTY_FOR_NODE_WITH_CPUS
 #define PENALTY_FOR_NODE_WITH_CPUS	(1)
-- 
2.30.1.766.gb4fecdf3b7-goog


  reply	other threads:[~2021-02-26 20:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26 20:17 [PATCH 1/2] mm: Guard a use of node_reclaim_distance with CONFIFG_NUMA Palmer Dabbelt
2021-02-26 20:17 ` Palmer Dabbelt [this message]
2021-02-26 20:37 ` Andrew Morton
2021-02-27  1:31   ` Hugh Dickins
2021-02-27  3:05     ` Palmer Dabbelt
2021-02-27  3:41       ` Hugh Dickins
2021-02-27  4:14         ` Palmer Dabbelt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210226201721.510177-2-palmer@dabbelt.com \
    --to=palmer@dabbelt.com \
    --cc=akpm@linux-foundation.org \
    --cc=atishp@atishpatra.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpe@ellerman.id.au \
    --cc=palmerdabbelt@google.com \
    --cc=peterz@infradead.org \
    --cc=srikar@linux.vnet.ibm.com \
    --cc=valentin.schneider@arm.com \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).