From: Huang Jianan <huangjianan@oppo.com>
To: linux-f2fs-devel@lists.sourceforge.net
Cc: huangjianan@oppo.com, guoweichao@oppo.com, zhangshiming@oppo.com,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/3] f2fs: fix last_lblock check in check_swap_activate_fast
Date: Sat, 27 Feb 2021 20:02:30 +0800 [thread overview]
Message-ID: <20210227120231.136559-2-huangjianan@oppo.com> (raw)
In-Reply-To: <20210227120231.136559-1-huangjianan@oppo.com>
Because page_no < sis->max guarantees that the while loop break out
normally, the wrong check contidion here doesn't cause a problem.
Signed-off-by: Huang Jianan <huangjianan@oppo.com>
Signed-off-by: Guo Weichao <guoweichao@oppo.com>
---
fs/f2fs/data.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index a1498a1a345c..4dbc1cafc55d 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -3804,7 +3804,7 @@ static int check_swap_activate_fast(struct swap_info_struct *sis,
last_lblock = bytes_to_blks(inode, i_size_read(inode));
len = i_size_read(inode);
- while (cur_lblock <= last_lblock && cur_lblock < sis->max) {
+ while (cur_lblock + 1 <= last_lblock && cur_lblock < sis->max) {
struct f2fs_map_blocks map;
pgoff_t next_pgofs;
--
2.25.1
next prev parent reply other threads:[~2021-02-27 12:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-27 12:02 [PATCH 1/3] f2fs: remove unnecessary IS_SWAPFILE check Huang Jianan
2021-02-27 12:02 ` Huang Jianan [this message]
2021-03-01 2:01 ` [f2fs-dev] [PATCH 2/3] f2fs: fix last_lblock check in check_swap_activate_fast Chao Yu
2021-02-27 12:02 ` [PATCH 3/3] f2fs: check if swapfile is section-alligned Huang Jianan
2021-03-01 2:41 ` [f2fs-dev] " Chao Yu
2021-03-02 4:20 ` Jaegeuk Kim
2021-03-02 4:25 ` Jaegeuk Kim
2021-03-01 1:58 ` [f2fs-dev] [PATCH 1/3] f2fs: remove unnecessary IS_SWAPFILE check Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210227120231.136559-2-huangjianan@oppo.com \
--to=huangjianan@oppo.com \
--cc=guoweichao@oppo.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=zhangshiming@oppo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).