[v2] MIPS: select CPU_MIPS64 for remaining MIPS64 CPUs
diff mbox series

Message ID 20210227230236.3234498-1-Jason@zx2c4.com
State Accepted
Commit 5a4fa44f5e1bca67577de631f94d76448f60f4c6
Headers show
Series
  • [v2] MIPS: select CPU_MIPS64 for remaining MIPS64 CPUs
Related show

Commit Message

Jason A. Donenfeld Feb. 27, 2021, 11:02 p.m. UTC
CPU_MIPS64 is supposed to be selected for CPUs that implement a revision
of the MIPS64 ISA. While it contains the generic ones, it forgot about
Octeon and Loongson in its list, which are indeed MIPS64 processors.
This commit adds these missing CPUs to the auto-selection list.

Cc: Maciej W. Rozycki <macro@orcam.me.uk>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Ralf Baechle <ralf@linux-mips.org>
Cc: George Cherian <gcherian@marvell.com>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
---
 arch/mips/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Bogendoerfer March 1, 2021, 2:49 p.m. UTC | #1
On Sun, Feb 28, 2021 at 12:02:36AM +0100, Jason A. Donenfeld wrote:
> CPU_MIPS64 is supposed to be selected for CPUs that implement a revision
> of the MIPS64 ISA. While it contains the generic ones, it forgot about
> Octeon and Loongson in its list, which are indeed MIPS64 processors.
> This commit adds these missing CPUs to the auto-selection list.
> 
> Cc: Maciej W. Rozycki <macro@orcam.me.uk>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Cc: George Cherian <gcherian@marvell.com>
> Cc: Huacai Chen <chenhuacai@kernel.org>
> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com>
> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com>
> ---
>  arch/mips/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

applied to mips-next.

Thomas.
Jason A. Donenfeld March 1, 2021, 4:27 p.m. UTC | #2
Hey Thomas,

Would you mind sending this for 5.12 in an rc at some point, rather
than waiting for 5.13? I'd like to see this backported to 5.10 and 5.4
for OpenWRT.

Thanks,
Jason
Thomas Bogendoerfer March 2, 2021, 11:03 p.m. UTC | #3
On Mon, Mar 01, 2021 at 05:27:46PM +0100, Jason A. Donenfeld wrote:
> Hey Thomas,
> 
> Would you mind sending this for 5.12 in an rc at some point, rather
> than waiting for 5.13? I'd like to see this backported to 5.10 and 5.4
> for OpenWRT.

why is this so important for OpenWRT ? Just to select CRYPTO_POLY1305_MIPS ?

Thomas.
Jason A. Donenfeld March 3, 2021, 12:05 a.m. UTC | #4
On 3/3/21, Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote:
> On Mon, Mar 01, 2021 at 05:27:46PM +0100, Jason A. Donenfeld wrote:
>> Hey Thomas,
>>
>> Would you mind sending this for 5.12 in an rc at some point, rather
>> than waiting for 5.13? I'd like to see this backported to 5.10 and 5.4
>> for OpenWRT.
>
> why is this so important for OpenWRT ? Just to select CRYPTO_POLY1305_MIPS
> ?

Yes. The performance boost on Octeon is significant for WireGuard users.

And it becomes incredibly frustrating to bifurcate packaging into
"mips64 where the config is right" vs "mips64 where the config is
borked." This saves us a lot of trouble.

Plus the patch is trivial.

Patch
diff mbox series

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index d89efba3d8a4..3e0e8f1d2e82 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -2118,7 +2118,7 @@  config CPU_MIPS32
 config CPU_MIPS64
 	bool
 	default y if CPU_MIPS64_R1 || CPU_MIPS64_R2 || CPU_MIPS64_R5 || \
-		     CPU_MIPS64_R6
+		     CPU_MIPS64_R6 || CPU_LOONGSON64 || CPU_CAVIUM_OCTEON
 
 #
 # These indicate the revision of the architecture