[2/3] spi: spi-nxp-fspi: Add driver support for imx8dxl
diff mbox series

Message ID 20210301103230.1816168-3-kuldeep.singh@nxp.com
State Accepted
Commit c791e3c31cb209e6f25a5f3767707d16c1a6069a
Headers show
Series
  • NXP Flexspi driver patches
Related show

Commit Message

Kuldeep Singh March 1, 2021, 10:32 a.m. UTC
From: Han Xu <han.xu@nxp.com>

Add driver support for imx8dxl which support read through IP bus only
and disable AHB bus due to an IC errata. Use the pre-defined quirk
FSPI_QUIRK_USE_IP_ONLY directly in device-type data to disable AHB read.

Signed-off-by: Han Xu <han.xu@nxp.com>
Signed-off-by: Kuldeep Singh <kuldeep.singh@nxp.com>
---
Hi Mark,
This patch is dependent on
https://patchwork.kernel.org/project/spi-devel-general/patch/1614593046-23832-1-git-send-email-kuldeep.singh@nxp.com/

 drivers/spi/spi-nxp-fspi.c | 9 +++++++++
 1 file changed, 9 insertions(+)

Comments

Mark Brown March 1, 2021, 1:25 p.m. UTC | #1
On Mon, Mar 01, 2021 at 04:02:29PM +0530, Kuldeep Singh wrote:

> This patch is dependent on
> https://patchwork.kernel.org/project/spi-devel-general/patch/1614593046-23832-1-git-send-email-kuldeep.singh@nxp.com/

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

That's a DT binding YAML conversion patch, why would there be a
dependency on it?

> 
>  drivers/spi/spi-nxp-fspi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

This needs a DT binding update adding the new compatible.
Kuldeep Singh March 1, 2021, 4:39 p.m. UTC | #2
Hi Mark,

> -----Original Message-----
> From: Mark Brown <broonie@kernel.org>
> Sent: Monday, March 1, 2021 6:56 PM
> To: Kuldeep Singh <kuldeep.singh@nxp.com>
> Cc: linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org; Ashish Kumar
> <ashish.kumar@nxp.com>; Han Xu <han.xu@nxp.com>
> Subject: [EXT] Re: [PATCH 2/3] spi: spi-nxp-fspi: Add driver support for imx8dxl
> 
> On Mon, Mar 01, 2021 at 04:02:29PM +0530, Kuldeep Singh wrote:
> 
> > This patch is dependent on
> > https://patchwork.kernel.org/project/spi-devel-general/patch/161459304
> > 6-23832-1-git-send-email-kuldeep.singh@nxp.com/
> 
> Please include human readable descriptions of things like commits and issues
> being discussed in e-mail in your mails, this makes them much easier for
> humans to read especially when they have no internet access.
> I do frequently catch up on my mail on flights or while otherwise travelling so
> this is even more pressing for me than just being about making things a bit
> easier to read.
> 
> That's a DT binding YAML conversion patch, why would there be a
> dependency on it?

I have converted bindings to yaml version in the patch and also added imx8dxl compatible along-with the conversion. Please see the difference in compatible entries from txt to yaml conversion[1].
Kindly let me know do I need to submit different patch for adding new compatible or ok to include in the conversion patch itself?

[1]
Documentation/devicetree/bindings/spi/nxp,spi-nxp-fspi.yaml
+properties:
+  compatible:
+    enum:
+      - nxp,lx2160a-fspi
+      - nxp,imx8qxp-fspi
+      - nxp,imx8mm-fspi
+      - nxp,imx8dxl-fspi

Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
-Required properties:
-  - compatible : Should be "nxp,lx2160a-fspi"
-			    "nxp,imx8qxp-fspi"
-			    "nxp,imx8mm-fspi"

> 
> >
> >  drivers/spi/spi-nxp-fspi.c | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> 
> This needs a DT binding update adding the new compatible.

Please see above for comments.

Thanks
Kuldeep
Mark Brown March 1, 2021, 5:11 p.m. UTC | #3
On Mon, Mar 01, 2021 at 04:39:18PM +0000, Kuldeep Singh wrote:

> > That's a DT binding YAML conversion patch, why would there be a
> > dependency on it?

> I have converted bindings to yaml version in the patch and also added imx8dxl compatible along-with the conversion. Please see the difference in compatible entries from txt to yaml conversion[1].
> Kindly let me know do I need to submit different patch for adding new compatible or ok to include in the conversion patch itself?

Your YAML binding conversion should have been a standalone patch only
doing that conversion, the new compatible should have been split out and
gone first - each patch should only do one thing as covered in
submitting-patches.rst.  As things stand the changelog for the
conversion is misleading since it doesn't mention the new compatible.

Please fix your mail client to word wrap within paragraphs at something
substantially less than 80 columns.  Doing this makes your messages much
easier to read and reply to.
Kuldeep Singh March 2, 2021, 5:19 a.m. UTC | #4
> > I have converted bindings to yaml version in the patch and also added
> imx8dxl compatible along-with the conversion. Please see the difference in
> compatible entries from txt to yaml conversion[1].
> > Kindly let me know do I need to submit different patch for adding new
> compatible or ok to include in the conversion patch itself?
> 
> Your YAML binding conversion should have been a standalone patch only
> doing that conversion, the new compatible should have been split out and
> gone first - each patch should only do one thing as covered in submitting-
> patches.rst.  As things stand the changelog for the conversion is misleading
> since it doesn't mention the new compatible.

Thanks Mark for mentioning.
I will send compatible adding patch with this series and post yaml conversion later.

Regards
Kuldeep

Patch
diff mbox series

diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
index 829391e20e92..80a9278d91ed 100644
--- a/drivers/spi/spi-nxp-fspi.c
+++ b/drivers/spi/spi-nxp-fspi.c
@@ -346,6 +346,14 @@  static const struct nxp_fspi_devtype_data imx8qxp_data = {
 	.little_endian = true,  /* little-endian    */
 };
 
+static const struct nxp_fspi_devtype_data imx8dxl_data = {
+	.rxfifo = SZ_512,       /* (64  * 64 bits)  */
+	.txfifo = SZ_1K,        /* (128 * 64 bits)  */
+	.ahb_buf_size = SZ_2K,  /* (256 * 64 bits)  */
+	.quirks = FSPI_QUIRK_USE_IP_ONLY,
+	.little_endian = true,  /* little-endian    */
+};
+
 struct nxp_fspi {
 	void __iomem *iobase;
 	void __iomem *ahb_addr;
@@ -1168,6 +1176,7 @@  static const struct of_device_id nxp_fspi_dt_ids[] = {
 	{ .compatible = "nxp,lx2160a-fspi", .data = (void *)&lx2160a_data, },
 	{ .compatible = "nxp,imx8mm-fspi", .data = (void *)&imx8mm_data, },
 	{ .compatible = "nxp,imx8qxp-fspi", .data = (void *)&imx8qxp_data, },
+	{ .compatible = "nxp,imx8dxl-fspi", .data = (void *)&imx8dxl_data, },
 	{ /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, nxp_fspi_dt_ids);