回复: [PATCH] hwmon: (nct6883) Support NCT6886d
diff mbox series

Message ID HK0PR03MB370088B1CE476C57A14D439783999@HK0PR03MB3700.apcprd03.prod.outlook.com
State New, archived
Headers show
Series
  • 回复: [PATCH] hwmon: (nct6883) Support NCT6886d
Related show

Commit Message

Jiqi JQ9 Li March 2, 2021, 6:21 a.m. UTC
Sorry, Please ignore this email as some typos. 

-----邮件原件-----
发件人: Jiqi JQ9 Li <lijq9@lenovo.com> 
发送时间: 2021年3月2日 14:12
收件人: jdelvare@suse.com; linux@roeck-us.net; linux-hwmon@vger.kernel.org; linux-kernel@vger.kernel.org
抄送: Mark RH Pearson <markpearson@lenovo.com>; Jiqi JQ9 Li <lijq9@lenovo.com>
主题: [PATCH] hwmon: (nct6883) Support NCT6886d

Add support for NCT6886d chip used in the Lenovo P620.

Signed-off-by: Jiqi Li <lijq9@lenovo.com>
Reviewed-by: Mark Pearson <markpearson@lenovo.com>
---
 drivers/hwmon/nct6683.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

--
2.18.2

Comments

Guenter Roeck March 2, 2021, 6:45 p.m. UTC | #1
On 3/1/21 10:21 PM, Jiqi JQ9 Li wrote:
> Sorry, Please ignore this email as some typos. 
> 

No problem. I seem to be missing the typos, though.

Thanks,
Guenter

> -----邮件原件-----
> 发件人: Jiqi JQ9 Li <lijq9@lenovo.com> 
> 发送时间: 2021年3月2日 14:12
> 收件人: jdelvare@suse.com; linux@roeck-us.net; linux-hwmon@vger.kernel.org; linux-kernel@vger.kernel.org
> 抄送: Mark RH Pearson <markpearson@lenovo.com>; Jiqi JQ9 Li <lijq9@lenovo.com>
> 主题: [PATCH] hwmon: (nct6883) Support NCT6886d
> 
> Add support for NCT6886d chip used in the Lenovo P620.
> 
> Signed-off-by: Jiqi Li <lijq9@lenovo.com>
> Reviewed-by: Mark Pearson <markpearson@lenovo.com>
> ---
>  drivers/hwmon/nct6683.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c index a23047a3bfe2..3de7bd146965 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -12,6 +12,7 @@
>   *
>   * Chip        #vin    #fan    #pwm    #temp  chip ID
>   * nct6683d     21(1)   16      8       32(1) 0xc730
> + * nct6686d     21(1)   16      8       32(1) 0xd440
>   * nct6687d     21(1)   16      8       32(1) 0xd590
>   *
>   * Notes:
> @@ -33,7 +34,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  
> -enum kinds { nct6683, nct6687 };
> +enum kinds { nct6683, nct6686, nct6687 };
>  
>  static bool force;
>  module_param(force, bool, 0);
> @@ -41,11 +42,13 @@ MODULE_PARM_DESC(force, "Set to one to enable support for unknown vendors");
>  
>  static const char * const nct6683_device_names[] = {
>  	"nct6683",
> +	"nct6686",
>  	"nct6687",
>  };
>  
>  static const char * const nct6683_chip_names[] = {
>  	"NCT6683D",
> +	"NCT6686D",
>  	"NCT6687D",
>  };
>  
> @@ -66,6 +69,7 @@ static const char * const nct6683_chip_names[] = {
>  
>  #define SIO_NCT6681_ID		0xb270	/* for later */
>  #define SIO_NCT6683_ID		0xc730
> +#define SIO_NCT6686_ID		0xd440
>  #define SIO_NCT6687_ID		0xd590
>  #define SIO_ID_MASK		0xFFF0
>  
> @@ -1362,6 +1366,9 @@ static int __init nct6683_find(int sioaddr, struct nct6683_sio_data *sio_data)
>  	case SIO_NCT6683_ID:
>  		sio_data->kind = nct6683;
>  		break;
> +	case SIO_NCT6686_ID:
> +		sio_data->kind = nct6686;
> +		break;
>  	case SIO_NCT6687_ID:
>  		sio_data->kind = nct6687;
>  		break;
> --
> 2.18.2
>
Jiqi JQ9 Li March 3, 2021, 3:09 a.m. UTC | #2
Thanks, I will re-send another email about this patch. Please check it.

Regards,
Jiqi

-----邮件原件-----
发件人: Guenter Roeck <groeck7@gmail.com> 代表 Guenter Roeck
发送时间: 2021年3月3日 2:46
收件人: Jiqi JQ9 Li <lijq9@lenovo.com>; jdelvare@suse.com; linux-hwmon@vger.kernel.org; linux-kernel@vger.kernel.org
抄送: Mark RH Pearson <markpearson@lenovo.com>
主题: [External] Re: 回复: [PATCH] hwmon: (nct6883) Support NCT6886d

On 3/1/21 10:21 PM, Jiqi JQ9 Li wrote:
> Sorry, Please ignore this email as some typos. 
> 

No problem. I seem to be missing the typos, though.

Thanks,
Guenter

> -----邮件原件-----
> 发件人: Jiqi JQ9 Li <lijq9@lenovo.com> 
> 发送时间: 2021年3月2日 14:12
> 收件人: jdelvare@suse.com; linux@roeck-us.net; linux-hwmon@vger.kernel.org; linux-kernel@vger.kernel.org
> 抄送: Mark RH Pearson <markpearson@lenovo.com>; Jiqi JQ9 Li <lijq9@lenovo.com>
> 主题: [PATCH] hwmon: (nct6883) Support NCT6886d
> 
> Add support for NCT6886d chip used in the Lenovo P620.
> 
> Signed-off-by: Jiqi Li <lijq9@lenovo.com>
> Reviewed-by: Mark Pearson <markpearson@lenovo.com>
> ---
>  drivers/hwmon/nct6683.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c index a23047a3bfe2..3de7bd146965 100644
> --- a/drivers/hwmon/nct6683.c
> +++ b/drivers/hwmon/nct6683.c
> @@ -12,6 +12,7 @@
>   *
>   * Chip        #vin    #fan    #pwm    #temp  chip ID
>   * nct6683d     21(1)   16      8       32(1) 0xc730
> + * nct6686d     21(1)   16      8       32(1) 0xd440
>   * nct6687d     21(1)   16      8       32(1) 0xd590
>   *
>   * Notes:
> @@ -33,7 +34,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/slab.h>
>  
> -enum kinds { nct6683, nct6687 };
> +enum kinds { nct6683, nct6686, nct6687 };
>  
>  static bool force;
>  module_param(force, bool, 0);
> @@ -41,11 +42,13 @@ MODULE_PARM_DESC(force, "Set to one to enable support for unknown vendors");
>  
>  static const char * const nct6683_device_names[] = {
>  	"nct6683",
> +	"nct6686",
>  	"nct6687",
>  };
>  
>  static const char * const nct6683_chip_names[] = {
>  	"NCT6683D",
> +	"NCT6686D",
>  	"NCT6687D",
>  };
>  
> @@ -66,6 +69,7 @@ static const char * const nct6683_chip_names[] = {
>  
>  #define SIO_NCT6681_ID		0xb270	/* for later */
>  #define SIO_NCT6683_ID		0xc730
> +#define SIO_NCT6686_ID		0xd440
>  #define SIO_NCT6687_ID		0xd590
>  #define SIO_ID_MASK		0xFFF0
>  
> @@ -1362,6 +1366,9 @@ static int __init nct6683_find(int sioaddr, struct nct6683_sio_data *sio_data)
>  	case SIO_NCT6683_ID:
>  		sio_data->kind = nct6683;
>  		break;
> +	case SIO_NCT6686_ID:
> +		sio_data->kind = nct6686;
> +		break;
>  	case SIO_NCT6687_ID:
>  		sio_data->kind = nct6687;
>  		break;
> --
> 2.18.2
>

Patch
diff mbox series

diff --git a/drivers/hwmon/nct6683.c b/drivers/hwmon/nct6683.c index a23047a3bfe2..3de7bd146965 100644
--- a/drivers/hwmon/nct6683.c
+++ b/drivers/hwmon/nct6683.c
@@ -12,6 +12,7 @@ 
  *
  * Chip        #vin    #fan    #pwm    #temp  chip ID
  * nct6683d     21(1)   16      8       32(1) 0xc730
+ * nct6686d     21(1)   16      8       32(1) 0xd440
  * nct6687d     21(1)   16      8       32(1) 0xd590
  *
  * Notes:
@@ -33,7 +34,7 @@ 
 #include <linux/platform_device.h>
 #include <linux/slab.h>
 
-enum kinds { nct6683, nct6687 };
+enum kinds { nct6683, nct6686, nct6687 };
 
 static bool force;
 module_param(force, bool, 0);
@@ -41,11 +42,13 @@  MODULE_PARM_DESC(force, "Set to one to enable support for unknown vendors");
 
 static const char * const nct6683_device_names[] = {
 	"nct6683",
+	"nct6686",
 	"nct6687",
 };
 
 static const char * const nct6683_chip_names[] = {
 	"NCT6683D",
+	"NCT6686D",
 	"NCT6687D",
 };
 
@@ -66,6 +69,7 @@  static const char * const nct6683_chip_names[] = {
 
 #define SIO_NCT6681_ID		0xb270	/* for later */
 #define SIO_NCT6683_ID		0xc730
+#define SIO_NCT6686_ID		0xd440
 #define SIO_NCT6687_ID		0xd590
 #define SIO_ID_MASK		0xFFF0
 
@@ -1362,6 +1366,9 @@  static int __init nct6683_find(int sioaddr, struct nct6683_sio_data *sio_data)
 	case SIO_NCT6683_ID:
 		sio_data->kind = nct6683;
 		break;
+	case SIO_NCT6686_ID:
+		sio_data->kind = nct6686;
+		break;
 	case SIO_NCT6687_ID:
 		sio_data->kind = nct6687;
 		break;