coda: switch to vmemdup_user()
diff mbox series

Message ID 1614675899-88091-1-git-send-email-yang.lee@linux.alibaba.com
State New, archived
Headers show
Series
  • coda: switch to vmemdup_user()
Related show

Commit Message

Yang Li March 2, 2021, 9:04 a.m. UTC
Replace opencoded alloc and copy with vmemdup_user()

fixed the following coccicheck:
./fs/coda/psdev.c:125:10-18: WARNING opportunity for vmemdup_user

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 fs/coda/psdev.c | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

Patch
diff mbox series

diff --git a/fs/coda/psdev.c b/fs/coda/psdev.c
index 240669f..8d38e92 100644
--- a/fs/coda/psdev.c
+++ b/fs/coda/psdev.c
@@ -122,14 +122,9 @@  static ssize_t coda_psdev_write(struct file *file, const char __user *buf,
 				hdr.opcode, hdr.unique);
 		        nbytes = size;
 		}
-		dcbuf = kvmalloc(nbytes, GFP_KERNEL);
-		if (!dcbuf) {
-			retval = -ENOMEM;
-			goto out;
-		}
-		if (copy_from_user(dcbuf, buf, nbytes)) {
-			kvfree(dcbuf);
-			retval = -EFAULT;
+		dcbuf = vmemdup_user(buf, nbytes)
+		if (IS_ERR(dcbuf)) {
+			r = PTR_ERR(dcbuf);
 			goto out;
 		}