From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org,
VMware Graphics <linux-graphics-maintainer@vmware.com>,
Roland Scheidegger <sroland@vmware.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org, Zack Rusin <zackr@vmware.com>
Subject: [PATCH 41/53] drm/vmwgfx/vmwgfx_cmdbuf: Fix a bunch of missing or incorrectly formatted/named params
Date: Wed, 3 Mar 2021 13:43:07 +0000 [thread overview]
Message-ID: <20210303134319.3160762-42-lee.jones@linaro.org> (raw)
In-Reply-To: <20210303134319.3160762-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:58: warning: Function parameter or member 'block_submission' not described in 'vmw_cmdbuf_context'
drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:109: warning: cannot understand function prototype: 'struct vmw_cmdbuf_man '
drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:164: warning: Function parameter or member 'handle' not described in 'vmw_cmdbuf_header'
drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:257: warning: Function parameter or member 'header' not described in '__vmw_cmdbuf_header_free'
drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:380: warning: Function parameter or member 'notempty' not described in 'vmw_cmdbuf_ctx_process'
drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1168: warning: Function parameter or member 'context' not described in 'vmw_cmdbuf_preempt'
drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c:1193: warning: Function parameter or member 'context' not described in 'vmw_cmdbuf_startstop'
Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>
Cc: Roland Scheidegger <sroland@vmware.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Zack Rusin <zackr@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210115181313.3431493-38-lee.jones@linaro.org
---
drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c
index 45fbc41440f1e..3158924ffa852 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_cmdbuf.c
@@ -48,6 +48,7 @@
* @hw_submitted: List of command buffers submitted to hardware.
* @preempted: List of preempted command buffers.
* @num_hw_submitted: Number of buffers currently being processed by hardware
+ * @block_submission: Identifies a block command submission.
*/
struct vmw_cmdbuf_context {
struct list_head submitted;
@@ -58,7 +59,7 @@ struct vmw_cmdbuf_context {
};
/**
- * struct vmw_cmdbuf_man: - Command buffer manager
+ * struct vmw_cmdbuf_man - Command buffer manager
*
* @cur_mutex: Mutex protecting the command buffer used for incremental small
* kernel command submissions, @cur.
@@ -143,7 +144,7 @@ struct vmw_cmdbuf_man {
* @cb_context: The device command buffer context.
* @list: List head for attaching to the manager lists.
* @node: The range manager node.
- * @handle. The DMA address of @cb_header. Handed to the device on command
+ * @handle: The DMA address of @cb_header. Handed to the device on command
* buffer submission.
* @cmd: Pointer to the command buffer space of this buffer.
* @size: Size of the command buffer space of this buffer.
@@ -249,7 +250,7 @@ static void vmw_cmdbuf_header_inline_free(struct vmw_cmdbuf_header *header)
* __vmw_cmdbuf_header_free - Free a struct vmw_cmdbuf_header and its
* associated structures.
*
- * header: Pointer to the header to free.
+ * @header: Pointer to the header to free.
*
* For internal use. Must be called with man::lock held.
*/
@@ -365,10 +366,11 @@ static void vmw_cmdbuf_ctx_submit(struct vmw_cmdbuf_man *man,
}
/**
- * vmw_cmdbuf_ctx_submit: Process a command buffer context.
+ * vmw_cmdbuf_ctx_process - Process a command buffer context.
*
* @man: The command buffer manager.
* @ctx: The command buffer context.
+ * @notempty: Pass back count of non-empty command submitted lists.
*
* Submit command buffers to hardware if possible, and process finished
* buffers. Typically freeing them, but on preemption or error take
@@ -1161,6 +1163,7 @@ static int vmw_cmdbuf_send_device_command(struct vmw_cmdbuf_man *man,
* context.
*
* @man: The command buffer manager.
+ * @context: Device context to pass command through.
*
* Synchronously sends a preempt command.
*/
@@ -1184,6 +1187,7 @@ static int vmw_cmdbuf_preempt(struct vmw_cmdbuf_man *man, u32 context)
* context.
*
* @man: The command buffer manager.
+ * @context: Device context to start/stop.
* @enable: Whether to enable or disable the context.
*
* Synchronously sends a device start / stop context command.
--
2.27.0
next prev parent reply other threads:[~2021-03-03 18:11 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 13:42 [RESEND 00/53] Rid GPU from W=1 warnings Lee Jones
2021-03-03 13:42 ` [PATCH 01/53] drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc Lee Jones
2021-03-03 13:42 ` [PATCH 02/53] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' Lee Jones
2021-03-03 13:42 ` [PATCH 03/53] drm/msm/dp/dp_display: Remove unused variable 'hpd' Lee Jones
2021-03-03 13:42 ` [PATCH 04/53] drm/amd/display/dc/bios/command_table: Remove unused variable Lee Jones
2021-03-03 15:22 ` Alex Deucher
2021-03-03 13:42 ` [PATCH 05/53] include: drm: drm_atomic: Make use of 'new_plane_state' Lee Jones
2021-03-03 13:42 ` [PATCH 06/53] drm/nouveau/nvkm/subdev/volt/gk20a: Demote non-conformant kernel-doc headers Lee Jones
2021-03-03 13:42 ` [PATCH 07/53] drm/amd/display/dc/bios/command_table: Remove unused variable and associated comment Lee Jones
2021-03-03 15:22 ` Alex Deucher
2021-03-03 13:42 ` [PATCH 08/53] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap Lee Jones
2021-03-03 13:46 ` Christian König
2021-03-03 13:42 ` [PATCH 09/53] drm/amd/display/dc/calcs/dce_calcs: Remove some large variables from the stack Lee Jones
2021-03-03 13:42 ` [PATCH 10/53] drm/amd/display/dc/dce/dce_aux: Remove duplicate line causing 'field overwritten' issue Lee Jones
2021-03-03 15:24 ` Alex Deucher
2021-03-03 13:42 ` [PATCH 11/53] drm/amd/display/dc/dce80/dce80_resource: Make local functions static Lee Jones
2021-03-03 13:42 ` [PATCH 12/53] drm/nouveau/nvkm/engine/gr/gf100: Demote non-conformant kernel-doc header Lee Jones
2021-03-03 13:42 ` [PATCH 13/53] drm/nouveau/nouveau_bo: Remove unused variables 'dev' Lee Jones
2021-03-03 13:42 ` [PATCH 14/53] drm/nouveau/nouveau_display: Remove set but unused variable 'width' Lee Jones
2021-03-03 13:42 ` [PATCH 15/53] drm/nouveau/dispnv04/crtc: Demote non-conforming kernel-doc headers Lee Jones
2021-03-03 13:42 ` [PATCH 16/53] drm/nouveau/dispnv50/disp: Remove unused variable 'ret' from function returning void Lee Jones
2021-03-03 13:42 ` [PATCH 17/53] drm/nouveau/dispnv50/headc57d: Make local function 'headc57d_olut' static Lee Jones
2021-03-03 16:52 ` Lyude Paul
2021-03-03 13:42 ` [PATCH 18/53] drm/nouveau/nv50_display: Remove superfluous prototype for local static functions Lee Jones
2021-03-03 13:42 ` [PATCH 19/53] drm/nouveau/dispnv50/disp: Include header containing our prototypes Lee Jones
2021-03-03 13:42 ` [PATCH 20/53] drm/nouveau/nouveau_ioc32: File headers are not good candidates for kernel-doc Lee Jones
2021-03-03 13:42 ` [PATCH 21/53] drm/nouveau/nouveau_svm: Remove unused variable 'ret' from void function Lee Jones
2021-03-03 13:42 ` [PATCH 22/53] drm/nouveau/nouveau_ioc32: Demote kernel-doc abuse to standard comment block Lee Jones
2021-03-03 13:42 ` [PATCH 23/53] drm/vmwgfx/vmwgfx_execbuf: Fix some kernel-doc related issues Lee Jones
2021-03-03 13:42 ` [PATCH 24/53] drm/vmwgfx/vmwgfx_kms: Remove unused variable 'ret' from 'vmw_du_primary_plane_atomic_check()' Lee Jones
2021-03-03 13:42 ` [PATCH 25/53] drm/vmwgfx/vmwgfx_kms: Mark vmw_{cursor,primary}_plane_formats as __maybe_unused Lee Jones
2021-03-03 13:42 ` [PATCH 26/53] drm/vmwgfx/vmwgfx_drv: Fix some kernel-doc misdemeanours Lee Jones
2021-03-03 13:42 ` [PATCH 27/53] drm/vmwgfx/vmwgfx_ioctl: Provide missing '@' sign required by kernel-doc Lee Jones
2021-03-03 13:42 ` [PATCH 28/53] drm/vmwgfx/vmwgfx_resource: Fix worthy function headers demote some others Lee Jones
2021-03-03 13:42 ` [PATCH 29/53] drm/vmwgfx/vmwgfx_ttm_buffer: Supply some missing parameter descriptions Lee Jones
2021-03-03 13:42 ` [PATCH 30/53] drm/vmwgfx/vmwgfx_fifo: Demote non-conformant kernel-doc header Lee Jones
2021-03-03 13:42 ` [PATCH 31/53] drm/vmwgfx/vmwgfx_ldu: Supply descriptions for 'state' function parameter Lee Jones
2021-03-03 13:42 ` [PATCH 32/53] drm/vmwgfx/vmwgfx_kms: Update worthy function headers and demote others Lee Jones
2021-03-03 13:42 ` [PATCH 33/53] drm/vmwgfx/vmwgfx_overlay: Demote kernel-doc abuses to standard comment blocks Lee Jones
2021-03-03 13:43 ` [PATCH 34/53] drm/vmwgfx/vmwgfx_fence: Add, remove and demote various documentation params/headers Lee Jones
2021-03-03 13:43 ` [PATCH 35/53] drm/vmwgfx/vmwgfx_bo: Remove superfluous param description and supply another Lee Jones
2021-03-03 13:43 ` [PATCH 36/53] drm/vmwgfx/vmwgfx_context: Demote kernel-doc abuses Lee Jones
2021-03-03 13:43 ` [PATCH 37/53] drm/vmwgfx/vmwgfx_scrn: Demote unworthy kernel-doc headers and update others Lee Jones
2021-03-03 13:43 ` [PATCH 38/53] drm/vmwgfx/vmwgfx_surface: Fix some kernel-doc related issues Lee Jones
2021-03-03 13:43 ` [PATCH 39/53] drm/vmwgfx/vmwgfx_cmdbuf_res: Rename param description and remove another Lee Jones
2021-03-03 13:43 ` [PATCH 40/53] drm/vmwgfx/vmwgfx_shader: Demote kernel-doc abuses and fix-up worthy headers Lee Jones
2021-03-03 13:43 ` Lee Jones [this message]
2021-03-03 13:43 ` [PATCH 42/53] drm/vmwgfx/vmwgfx_cmdbuf_res: Remove unused variable 'ret' Lee Jones
2021-03-03 13:43 ` [PATCH 43/53] drm/vmwgfx/vmwgfx_stdu: Add some missing param/member descriptions Lee Jones
2021-03-03 13:43 ` [PATCH 44/53] drm/vmwgfx/vmwgfx_cmdbuf: Fix misnaming of 'headers' should be plural Lee Jones
2021-03-03 13:43 ` [PATCH 45/53] drm/vmwgfx/vmwgfx_cotable: Fix a couple of simple documentation problems Lee Jones
2021-03-03 13:43 ` [PATCH 46/53] drm/vmwgfx/vmwgfx_so: Add description for 'vmw_view's 'rcu' member Lee Jones
2021-03-03 13:43 ` [PATCH 47/53] drm/vmwgfx/vmwgfx_binding: Provide some missing param descriptions and remove others Lee Jones
2021-03-03 13:43 ` [PATCH 48/53] drm/vmwgfx/vmwgfx_msg: Fix misspelling of 'msg' Lee Jones
2021-03-03 13:43 ` [PATCH 49/53] drm/vmwgfx/vmwgfx_blit: Add description for 'vmw_bo_cpu_blit's 'diff' param Lee Jones
2021-03-03 13:43 ` [PATCH 50/53] drm/vmwgfx/vmwgfx_validation: Add some missing struct member/function param descriptions Lee Jones
2021-03-03 13:43 ` [PATCH 51/53] drm/vmwgfx/ttm_object: Demote half-assed headers and fix-up another Lee Jones
2021-03-03 13:43 ` [PATCH 52/53] drm/vmwgfx/vmwgfx_thp: Add description for 'vmw_thp_manager's member 'manager' Lee Jones
2021-03-03 13:43 ` [PATCH 53/53] drm/vmwgfx/ttm_object: Reorder header to immediately precede its struct Lee Jones
2021-03-05 15:33 ` [RESEND 00/53] Rid GPU from W=1 warnings Roland Scheidegger
2021-03-08 9:19 ` Lee Jones
2021-03-11 13:31 ` Daniel Vetter
2021-03-11 13:51 ` Lee Jones
2021-03-17 8:17 ` Lee Jones
2021-03-17 20:32 ` Daniel Vetter
2021-03-18 13:18 ` Daniel Vetter
2021-03-19 8:24 ` Lee Jones
2021-03-19 17:55 ` Daniel Vetter
2021-03-22 8:39 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210303134319.3160762-42-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sroland@vmware.com \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).