[23/30] scsi: qla2xxx: qla_gs: Fix some incorrect formatting/spelling issues
diff mbox series

Message ID 20210303144631.3175331-24-lee.jones@linaro.org
State New, archived
Headers show
Series
  • Rid W=1 warnings in SCSI
Related show

Commit Message

Lee Jones March 3, 2021, 2:46 p.m. UTC
Fixes the following W=1 kernel build warning(s):

 drivers/scsi/qla2xxx/qla_gs.c:1259: warning: expecting prototype for qla2x00_snd_rft_id(). Prototype was for qla2x00_sns_rft_id() instead
 drivers/scsi/qla2xxx/qla_gs.c:1492: warning: expecting prototype for qla2x00_prep_ct_req(). Prototype was for qla2x00_prep_ct_fdmi_req() instead
 drivers/scsi/qla2xxx/qla_gs.c:1596: warning: expecting prototype for perform HBA attributes registration(). Prototype was for qla2x00_hba_attributes() instead
 drivers/scsi/qla2xxx/qla_gs.c:1851: warning: expecting prototype for perform Port attributes registration(). Prototype was for qla2x00_port_attributes() instead
 drivers/scsi/qla2xxx/qla_gs.c:2284: warning: expecting prototype for perform RPRT registration(). Prototype was for qla2x00_fdmi_rprt() instead

Cc: Nilesh Javali <njavali@marvell.com>
Cc: GR-QLogic-Storage-Upstream@marvell.com
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 drivers/scsi/qla2xxx/qla_gs.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Nilesh Javali March 3, 2021, 4:13 p.m. UTC | #1
> -----Original Message-----
> From: Lee Jones <lee.jones@linaro.org>
> Sent: Wednesday, March 3, 2021 8:16 PM
> To: lee.jones@linaro.org
> Cc: linux-kernel@vger.kernel.org; Nilesh Javali <njavali@marvell.com>; GR-
> QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@marvell.com>;
> James E.J. Bottomley <jejb@linux.ibm.com>; Martin K. Petersen
> <martin.petersen@oracle.com>; linux-scsi@vger.kernel.org
> Subject: [EXT] [PATCH 23/30] scsi: qla2xxx: qla_gs: Fix some incorrect
> formatting/spelling issues
> 
> External Email
> 
> ----------------------------------------------------------------------
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/scsi/qla2xxx/qla_gs.c:1259: warning: expecting prototype for
> qla2x00_snd_rft_id(). Prototype was for qla2x00_sns_rft_id() instead
>  drivers/scsi/qla2xxx/qla_gs.c:1492: warning: expecting prototype for
> qla2x00_prep_ct_req(). Prototype was for qla2x00_prep_ct_fdmi_req()
> instead
>  drivers/scsi/qla2xxx/qla_gs.c:1596: warning: expecting prototype for
> perform HBA attributes registration(). Prototype was for
> qla2x00_hba_attributes() instead
>  drivers/scsi/qla2xxx/qla_gs.c:1851: warning: expecting prototype for
> perform Port attributes registration(). Prototype was for
> qla2x00_port_attributes() instead
>  drivers/scsi/qla2xxx/qla_gs.c:2284: warning: expecting prototype for
> perform RPRT registration(). Prototype was for qla2x00_fdmi_rprt() instead
> 
> Cc: Nilesh Javali <njavali@marvell.com>
> Cc: GR-QLogic-Storage-Upstream@marvell.com
> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/scsi/qla2xxx/qla_gs.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
> index 517d358b0031a..8e126afe61b11 100644
> --- a/drivers/scsi/qla2xxx/qla_gs.c
> +++ b/drivers/scsi/qla2xxx/qla_gs.c
> @@ -1247,7 +1247,7 @@ qla2x00_sns_gnn_id(scsi_qla_host_t *vha,
> sw_info_t *list)
>  }
> 
>  /**
> - * qla2x00_snd_rft_id() - SNS Register FC-4 TYPEs (RFT_ID) supported by the
> HBA.
> + * qla2x00_sns_rft_id() - SNS Register FC-4 TYPEs (RFT_ID) supported by the
> HBA.
>   * @vha: HA context
>   *
>   * This command uses the old Exectute SNS Command mailbox routine.
> @@ -1479,7 +1479,7 @@ qla2x00_update_ms_fdmi_iocb(scsi_qla_host_t
> *vha, uint32_t req_size)
>  }
> 
>  /**
> - * qla2x00_prep_ct_req() - Prepare common CT request fields for SNS query.
> + * qla2x00_prep_ct_fdmi_req() - Prepare common CT request fields for SNS
> query.
>   * @p: CT request buffer
>   * @cmd: GS command
>   * @rsp_size: response size in bytes
> @@ -1582,7 +1582,7 @@ qla25xx_fdmi_port_speed_currently(struct
> qla_hw_data *ha)
>  }
> 
>  /**
> - * qla2x00_hba_attributes() perform HBA attributes registration
> + * qla2x00_hba_attributes() - perform HBA attributes registration
>   * @vha: HA context
>   * @entries: number of entries to use
>   * @callopt: Option to issue extended or standard FDMI
> @@ -1837,7 +1837,7 @@ qla2x00_hba_attributes(scsi_qla_host_t *vha, void
> *entries,
>  }
> 
>  /**
> - * qla2x00_port_attributes() perform Port attributes registration
> + * qla2x00_port_attributes() - perform Port attributes registration
>   * @vha: HA context
>   * @entries: number of entries to use
>   * @callopt: Option to issue extended or standard FDMI
> @@ -2272,7 +2272,7 @@ qla2x00_fdmi_dhba(scsi_qla_host_t *vha)
>  }
> 
>  /**
> - * qla2x00_fdmi_rprt() perform RPRT registration
> + * qla2x00_fdmi_rprt() - perform RPRT registration
>   * @vha: HA context
>   * @callopt: Option to issue extended or standard FDMI
>   *           command parameter
> --
> 2.27.0

Lee,

Thanks for the patch.
Ack-by: Nilesh Javali <njavali@marvell.com>

Patch
diff mbox series

diff --git a/drivers/scsi/qla2xxx/qla_gs.c b/drivers/scsi/qla2xxx/qla_gs.c
index 517d358b0031a..8e126afe61b11 100644
--- a/drivers/scsi/qla2xxx/qla_gs.c
+++ b/drivers/scsi/qla2xxx/qla_gs.c
@@ -1247,7 +1247,7 @@  qla2x00_sns_gnn_id(scsi_qla_host_t *vha, sw_info_t *list)
 }
 
 /**
- * qla2x00_snd_rft_id() - SNS Register FC-4 TYPEs (RFT_ID) supported by the HBA.
+ * qla2x00_sns_rft_id() - SNS Register FC-4 TYPEs (RFT_ID) supported by the HBA.
  * @vha: HA context
  *
  * This command uses the old Exectute SNS Command mailbox routine.
@@ -1479,7 +1479,7 @@  qla2x00_update_ms_fdmi_iocb(scsi_qla_host_t *vha, uint32_t req_size)
 }
 
 /**
- * qla2x00_prep_ct_req() - Prepare common CT request fields for SNS query.
+ * qla2x00_prep_ct_fdmi_req() - Prepare common CT request fields for SNS query.
  * @p: CT request buffer
  * @cmd: GS command
  * @rsp_size: response size in bytes
@@ -1582,7 +1582,7 @@  qla25xx_fdmi_port_speed_currently(struct qla_hw_data *ha)
 }
 
 /**
- * qla2x00_hba_attributes() perform HBA attributes registration
+ * qla2x00_hba_attributes() - perform HBA attributes registration
  * @vha: HA context
  * @entries: number of entries to use
  * @callopt: Option to issue extended or standard FDMI
@@ -1837,7 +1837,7 @@  qla2x00_hba_attributes(scsi_qla_host_t *vha, void *entries,
 }
 
 /**
- * qla2x00_port_attributes() perform Port attributes registration
+ * qla2x00_port_attributes() - perform Port attributes registration
  * @vha: HA context
  * @entries: number of entries to use
  * @callopt: Option to issue extended or standard FDMI
@@ -2272,7 +2272,7 @@  qla2x00_fdmi_dhba(scsi_qla_host_t *vha)
 }
 
 /**
- * qla2x00_fdmi_rprt() perform RPRT registration
+ * qla2x00_fdmi_rprt() - perform RPRT registration
  * @vha: HA context
  * @callopt: Option to issue extended or standard FDMI
  *           command parameter