efi/apple-properties: Handle device properties with software node API
diff mbox series

Message ID 20210304082837.22262-1-heikki.krogerus@linux.intel.com
State New, archived
Headers show
Series
  • efi/apple-properties: Handle device properties with software node API
Related show

Commit Message

Heikki Krogerus March 4, 2021, 8:28 a.m. UTC
The old device property API is going to be removed.
Replacing the device_add_properties() call with the software
node API equivalent, device_create_managed_software_node().

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 drivers/firmware/efi/apple-properties.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Lukas Wunner March 4, 2021, 9:44 a.m. UTC | #1
On Thu, Mar 04, 2021 at 11:28:37AM +0300, Heikki Krogerus wrote:
> The old device property API is going to be removed.
> Replacing the device_add_properties() call with the software
> node API equivalent, device_create_managed_software_node().
> 
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

Acked-by: Lukas Wunner <lukas@wunner.de>
Ard Biesheuvel March 7, 2021, 5:08 p.m. UTC | #2
On Thu, 4 Mar 2021 at 10:46, Lukas Wunner <lukas@wunner.de> wrote:
>
> On Thu, Mar 04, 2021 at 11:28:37AM +0300, Heikki Krogerus wrote:
> > The old device property API is going to be removed.
> > Replacing the device_add_properties() call with the software
> > node API equivalent, device_create_managed_software_node().
> >
> > Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
>
> Acked-by: Lukas Wunner <lukas@wunner.de>

Queued in efi/next

Thanks all.

Patch
diff mbox series

diff --git a/drivers/firmware/efi/apple-properties.c b/drivers/firmware/efi/apple-properties.c
index e1926483ae2fd..4c3201e290e29 100644
--- a/drivers/firmware/efi/apple-properties.c
+++ b/drivers/firmware/efi/apple-properties.c
@@ -157,7 +157,7 @@  static int __init unmarshal_devices(struct properties_header *properties)
 		if (!entry[0].name)
 			goto skip_device;
 
-		ret = device_add_properties(dev, entry); /* makes deep copy */
+		ret = device_create_managed_software_node(dev, entry, NULL);
 		if (ret)
 			dev_err(dev, "error %d assigning properties\n", ret);