interconnect: core: fix error return code of icc_link_destroy()
diff mbox series

Message ID 20210306132857.17020-1-baijiaju1990@gmail.com
State Accepted
Commit 715ea61532e731c62392221238906704e63d75b6
Headers show
Series
  • interconnect: core: fix error return code of icc_link_destroy()
Related show

Commit Message

Jia-Ju Bai March 6, 2021, 1:28 p.m. UTC
When krealloc() fails and new is NULL, no error return code of
icc_link_destroy() is assigned.
To fix this bug, ret is assigned with -ENOMEM hen new is NULL.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
 drivers/interconnect/core.c | 2 ++
 1 file changed, 2 insertions(+)

Patch
diff mbox series

diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
index 5ad519c9f239..8a1e70e00876 100644
--- a/drivers/interconnect/core.c
+++ b/drivers/interconnect/core.c
@@ -942,6 +942,8 @@  int icc_link_destroy(struct icc_node *src, struct icc_node *dst)
 		       GFP_KERNEL);
 	if (new)
 		src->links = new;
+	else
+		ret = -ENOMEM;
 
 out:
 	mutex_unlock(&icc_lock);