From: Syed Nayyar Waris <syednwaris@gmail.com>
To: bgolaszewski@baylibre.com
Cc: andriy.shevchenko@linux.intel.com, vilhelm.gray@gmail.com,
michal.simek@xilinx.com, arnd@arndb.de, rrichter@marvell.com,
linus.walleij@linaro.org, bgolaszewski@baylibre.com,
yamada.masahiro@socionext.com, akpm@linux-foundation.org,
rui.zhang@intel.com, daniel.lezcano@linaro.org,
amit.kucheria@verdurent.com, linux-arch@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org
Subject: [PATCH v3 2/3] gpio: thunderx: Utilize for_each_set_nbits macro
Date: Sat, 6 Mar 2021 19:35:53 +0530 [thread overview]
Message-ID: <ba0f16c62a3993a43ce747a0d7c342477b99778f.1615038553.git.syednwaris@gmail.com> (raw)
In-Reply-To: <cover.1615038553.git.syednwaris@gmail.com>
This patch reimplements the thunderx_gpio_set_multiple function in
drivers/gpio/gpio-thunderx.c to use the new for_each_set_nbits macro.
Instead of looping for each bank in thunderx_gpio_set_multiple
function, now we can skip bank which is not set and save cycles.
Cc: Robert Richter <rrichter@marvell.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Syed Nayyar Waris <syednwaris@gmail.com>
Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
drivers/gpio/gpio-thunderx.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/gpio/gpio-thunderx.c b/drivers/gpio/gpio-thunderx.c
index 9f66deab46ea..4349e7393a1d 100644
--- a/drivers/gpio/gpio-thunderx.c
+++ b/drivers/gpio/gpio-thunderx.c
@@ -16,7 +16,7 @@
#include <linux/pci.h>
#include <linux/spinlock.h>
#include <asm-generic/msi.h>
-
+#include "gpiolib.h"
#define GPIO_RX_DAT 0x0
#define GPIO_TX_SET 0x8
@@ -275,12 +275,15 @@ static void thunderx_gpio_set_multiple(struct gpio_chip *chip,
unsigned long *bits)
{
int bank;
- u64 set_bits, clear_bits;
+ unsigned long set_bits, clear_bits, gpio_mask;
+ unsigned long offset;
+
struct thunderx_gpio *txgpio = gpiochip_get_data(chip);
- for (bank = 0; bank <= chip->ngpio / 64; bank++) {
- set_bits = bits[bank] & mask[bank];
- clear_bits = ~bits[bank] & mask[bank];
+ for_each_set_nbits(offset, gpio_mask, mask, chip->ngpio, 64) {
+ bank = offset / 64;
+ set_bits = bits[bank] & gpio_mask;
+ clear_bits = ~bits[bank] & gpio_mask;
writeq(set_bits, txgpio->register_base + (bank * GPIO_2ND_BANK) + GPIO_TX_SET);
writeq(clear_bits, txgpio->register_base + (bank * GPIO_2ND_BANK) + GPIO_TX_CLR);
}
--
2.29.0
next prev parent reply other threads:[~2021-03-06 14:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-06 14:01 [PATCH v3 0/3] Introduce the for_each_set_nbits macro Syed Nayyar Waris
2021-03-06 14:03 ` [PATCH v3 1/3] gpiolib: " Syed Nayyar Waris
2021-03-06 14:05 ` Syed Nayyar Waris [this message]
2021-03-06 14:06 ` [PATCH v3 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value Syed Nayyar Waris
2021-03-08 7:13 ` Michal Simek
2021-03-26 17:27 ` Bartosz Golaszewski
2021-03-31 15:26 ` Srinivas Neeli
2021-04-01 11:15 ` Syed Nayyar Waris
2021-04-01 12:51 ` Bartosz Golaszewski
2021-03-26 17:57 ` Andy Shevchenko
2021-04-02 9:40 ` Syed Nayyar Waris
2021-03-26 18:02 ` Andy Shevchenko
2021-03-26 22:12 ` Syed Nayyar Waris
[not found] ` <CAHp75VfDZbJjCOEGdHc=-D6W8_7m2=CinXj-itwn6hvoVqdWYQ@mail.gmail.com>
2021-03-27 12:02 ` William Breathitt Gray
2021-03-27 16:35 ` Andy Shevchenko
2021-04-01 17:50 ` Syed Nayyar Waris
2021-03-29 15:24 ` Andy Shevchenko
2021-04-01 17:47 ` Syed Nayyar Waris
2021-04-02 10:07 ` Syed Nayyar Waris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba0f16c62a3993a43ce747a0d7c342477b99778f.1615038553.git.syednwaris@gmail.com \
--to=syednwaris@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amit.kucheria@verdurent.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bgolaszewski@baylibre.com \
--cc=daniel.lezcano@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=rrichter@marvell.com \
--cc=rui.zhang@intel.com \
--cc=vilhelm.gray@gmail.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).