usb: gadget: legacy: fix error return code of msg_bind()
diff mbox series

Message ID 20210307084915.22022-1-baijiaju1990@gmail.com
State Accepted
Commit f2b6ebf61e8fcd0b1f03a084d39742b1f6113ac4
Headers show
Series
  • usb: gadget: legacy: fix error return code of msg_bind()
Related show

Commit Message

Jia-Ju Bai March 7, 2021, 8:49 a.m. UTC
When usb_otg_descriptor_alloc() returns NULL to usb_desc, no error
return code of msg_bind() is assigned.
To fix this bug, status is assigned with -ENOMEM in this case.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn
Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>>
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
 drivers/usb/gadget/legacy/mass_storage.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Greg KH March 23, 2021, 11:35 a.m. UTC | #1
On Sun, Mar 07, 2021 at 12:49:15AM -0800, Jia-Ju Bai wrote:
> When usb_otg_descriptor_alloc() returns NULL to usb_desc, no error
> return code of msg_bind() is assigned.
> To fix this bug, status is assigned with -ENOMEM in this case.
> 
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn
> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>>

These lines are not written correctly :(

Please fix up and resend.

thanks,

greg k-h
Jia-Ju Bai March 23, 2021, 12:37 p.m. UTC | #2
On 2021/3/23 19:35, Greg KH wrote:
> On Sun, Mar 07, 2021 at 12:49:15AM -0800, Jia-Ju Bai wrote:
>> When usb_otg_descriptor_alloc() returns NULL to usb_desc, no error
>> return code of msg_bind() is assigned.
>> To fix this bug, status is assigned with -ENOMEM in this case.
>>
>> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn
>> Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>>
> These lines are not written correctly :(
>
> Please fix up and resend.

Sorry for the mistake.
I will fix it and send a V2 patch.


Best wishes,
Jia-Ju Bai

Patch
diff mbox series

diff --git a/drivers/usb/gadget/legacy/mass_storage.c b/drivers/usb/gadget/legacy/mass_storage.c
index 9ed22c5fb7fe..ac1741126619 100644
--- a/drivers/usb/gadget/legacy/mass_storage.c
+++ b/drivers/usb/gadget/legacy/mass_storage.c
@@ -175,8 +175,10 @@  static int msg_bind(struct usb_composite_dev *cdev)
 		struct usb_descriptor_header *usb_desc;
 
 		usb_desc = usb_otg_descriptor_alloc(cdev->gadget);
-		if (!usb_desc)
+		if (!usb_desc) {
+			status = -ENOMEM;
 			goto fail_string_ids;
+		}
 		usb_otg_descriptor_init(cdev->gadget, usb_desc);
 		otg_desc[0] = usb_desc;
 		otg_desc[1] = NULL;