[1/2] dt-bindings: panel/kingdisplay,kd035g6-54nt: Remove spi-cs-high
diff mbox series

Message ID 20210307192830.208245-1-paul@crapouillou.net
State Accepted
Commit 85a217750ccc1f360f14c4ddca6970388369420e
Headers show
Series
  • [1/2] dt-bindings: panel/kingdisplay,kd035g6-54nt: Remove spi-cs-high
Related show

Commit Message

Paul Cercueil March 7, 2021, 7:28 p.m. UTC
The NT39016 panel is a fun beast, even though the documentation states
that the CS line is active-low, it will work just fine if the CS line is
configured as active-high, but it won't work if the CS line is forced
low or forced high.

Since it did actually work with the spi-cs-high property, this is not a
bugfix, but we should nonetheless remove that property from the example
to match the documentation.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
---
 .../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml         | 1 -
 1 file changed, 1 deletion(-)

Comments

Rob Herring March 8, 2021, 11:01 p.m. UTC | #1
On Sun, 07 Mar 2021 19:28:29 +0000, Paul Cercueil wrote:
> The NT39016 panel is a fun beast, even though the documentation states
> that the CS line is active-low, it will work just fine if the CS line is
> configured as active-high, but it won't work if the CS line is forced
> low or forced high.
> 
> Since it did actually work with the spi-cs-high property, this is not a
> bugfix, but we should nonetheless remove that property from the example
> to match the documentation.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  .../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml         | 1 -
>  1 file changed, 1 deletion(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Thomas Bogendoerfer March 12, 2021, 3 p.m. UTC | #2
On Sun, Mar 07, 2021 at 07:28:29PM +0000, Paul Cercueil wrote:
> The NT39016 panel is a fun beast, even though the documentation states
> that the CS line is active-low, it will work just fine if the CS line is
> configured as active-high, but it won't work if the CS line is forced
> low or forced high.
> 
> Since it did actually work with the spi-cs-high property, this is not a
> bugfix, but we should nonetheless remove that property from the example
> to match the documentation.
> 
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> ---
>  .../bindings/display/panel/kingdisplay,kd035g6-54nt.yaml         | 1 -
>  1 file changed, 1 deletion(-)

applied to mips-next.

Thomas.

Patch
diff mbox series

diff --git a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
index 6960036975fa..c45c92a3d41f 100644
--- a/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
+++ b/Documentation/devicetree/bindings/display/panel/kingdisplay,kd035g6-54nt.yaml
@@ -47,7 +47,6 @@  examples:
 
             spi-max-frequency = <3125000>;
             spi-3wire;
-            spi-cs-high;
 
             reset-gpios = <&gpe 2 GPIO_ACTIVE_LOW>;