[v2] tracing/tools: Remove unneeded semicolon
diff mbox series

Message ID 20210308022459.59881-1-vulab@iscas.ac.cn
State Accepted
Commit 421d9d1bea6545543c00ffba4c83f369510de9a1
Headers show
Series
  • [v2] tracing/tools: Remove unneeded semicolon
Related show

Commit Message

Xu Wang March 8, 2021, 2:24 a.m. UTC
fix semicolon.cocci warning:
tools/tracing/latency/latency-collector.c:1021:2-3: Unneeded semicolon

Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
Changes since v2:
- Fix another instance of superfluous semicolon.
---
 tools/tracing/latency/latency-collector.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Viktor Rosendahl March 8, 2021, 11:40 a.m. UTC | #1
On Mon, 2021-03-08 at 02:24 +0000, Xu Wang wrote:
> fix semicolon.cocci warning:
> tools/tracing/latency/latency-collector.c:1021:2-3: Unneeded semicolon
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>

Reviewed-by: Viktor Rosendahl <Viktor.Rosendahl@bmw.de>

> ---
> Changes since v2:
> - Fix another instance of superfluous semicolon.
> ---
>  tools/tracing/latency/latency-collector.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/tracing/latency/latency-collector.c
> b/tools/tracing/latency/latency-collector.c
> index b69de9263ee6..3a2e6bb781a8 100644
> --- a/tools/tracing/latency/latency-collector.c
> +++ b/tools/tracing/latency/latency-collector.c
> @@ -1018,7 +1018,7 @@ static long go_to_sleep(const struct entry *req)
>  		cond_timedwait(&printstate.cond, &printstate.mutex, &future);
>  		if (time_has_passed(&future))
>  			break;
> -	};
> +	}
>  
>  	if (printstate_has_new_req_arrived(req))
>  		delay = -1;
> @@ -1941,7 +1941,7 @@ static void scan_arguments(int argc, char *argv[])
>  			if (value < 0) {
>  				warnx("TIME must be >= 0\n");
>  				show_usage();
> -				;
> +				exit(0);
>  			}
>  			trace_enable = true;
>  			use_random_sleep = true;

best regards,

Viktor

Patch
diff mbox series

diff --git a/tools/tracing/latency/latency-collector.c b/tools/tracing/latency/latency-collector.c
index b69de9263ee6..3a2e6bb781a8 100644
--- a/tools/tracing/latency/latency-collector.c
+++ b/tools/tracing/latency/latency-collector.c
@@ -1018,7 +1018,7 @@  static long go_to_sleep(const struct entry *req)
 		cond_timedwait(&printstate.cond, &printstate.mutex, &future);
 		if (time_has_passed(&future))
 			break;
-	};
+	}
 
 	if (printstate_has_new_req_arrived(req))
 		delay = -1;
@@ -1941,7 +1941,7 @@  static void scan_arguments(int argc, char *argv[])
 			if (value < 0) {
 				warnx("TIME must be >= 0\n");
 				show_usage();
-				;
+				exit(0);
 			}
 			trace_enable = true;
 			use_random_sleep = true;