From: Bartosz Golaszewski <brgl@bgdev.pl>
To: "Joel Becker" <jlbec@evilplan.org>,
"Christoph Hellwig" <hch@lst.de>, "Shuah Khan" <shuah@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Kent Gibson" <warthog618@gmail.com>,
"Jonathan Corbet" <corbet@lwn.net>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org,
Bartosz Golaszewski <bgolaszewski@baylibre.com>
Subject: [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags
Date: Mon, 15 Mar 2021 10:13:51 +0100 [thread overview]
Message-ID: <20210315091400.13772-3-brgl@bgdev.pl> (raw)
In-Reply-To: <20210315091400.13772-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
For better readability and maintenance: use the (1UL << bit) for flag
definitions.
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
---
fs/configfs/configfs_internal.h | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/configfs/configfs_internal.h b/fs/configfs/configfs_internal.h
index 9a3aed249692..b495c9f043d4 100644
--- a/fs/configfs/configfs_internal.h
+++ b/fs/configfs/configfs_internal.h
@@ -46,16 +46,16 @@ struct configfs_dirent {
struct configfs_fragment *s_frag;
};
-#define CONFIGFS_ROOT 0x0001
-#define CONFIGFS_DIR 0x0002
-#define CONFIGFS_ITEM_ATTR 0x0004
-#define CONFIGFS_ITEM_BIN_ATTR 0x0008
-#define CONFIGFS_ITEM_LINK 0x0020
-#define CONFIGFS_USET_DIR 0x0040
-#define CONFIGFS_USET_DEFAULT 0x0080
-#define CONFIGFS_USET_DROPPING 0x0100
-#define CONFIGFS_USET_IN_MKDIR 0x0200
-#define CONFIGFS_USET_CREATING 0x0400
+#define CONFIGFS_ROOT (1UL << 0)
+#define CONFIGFS_DIR (1UL << 1)
+#define CONFIGFS_ITEM_ATTR (1UL << 2)
+#define CONFIGFS_ITEM_BIN_ATTR (1UL << 3)
+#define CONFIGFS_ITEM_LINK (1UL << 5)
+#define CONFIGFS_USET_DIR (1UL << 6)
+#define CONFIGFS_USET_DEFAULT (1UL << 7)
+#define CONFIGFS_USET_DROPPING (1UL << 8)
+#define CONFIGFS_USET_IN_MKDIR (1UL << 9)
+#define CONFIGFS_USET_CREATING (1UL << 10)
#define CONFIGFS_NOT_PINNED (CONFIGFS_ITEM_ATTR | CONFIGFS_ITEM_BIN_ATTR)
extern struct mutex configfs_symlink_mutex;
--
2.30.1
next prev parent reply other threads:[~2021-03-15 9:15 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 9:13 [PATCH v5 00/11] gpio: implement the configfs testing module Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 01/11] configfs: increase the item name length Bartosz Golaszewski
2021-03-15 9:13 ` Bartosz Golaszewski [this message]
2021-03-15 15:31 ` [PATCH v5 02/11] configfs: use (1UL << bit) for internal flags David Laight
2021-03-15 16:36 ` Andy Shevchenko
2021-03-15 9:13 ` [PATCH v5 03/11] configfs: implement committable items Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 04/11] samples: configfs: add a committable group Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 05/11] lib: bitmap: remove the 'extern' keyword from function declarations Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 06/11] lib: bitmap: order includes alphabetically Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 07/11] lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc() Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 08/11] gpio: sim: new testing module Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 09/11] selftests: gpio: provide a helper for reading chip info Bartosz Golaszewski
2021-03-15 9:13 ` [PATCH v5 10/11] selftests: gpio: add a helper for reading GPIO line names Bartosz Golaszewski
2021-03-15 9:14 ` [PATCH v5 11/11] selftests: gpio: add test cases for gpio-sim Bartosz Golaszewski
2021-03-22 14:32 ` [PATCH v5 00/11] gpio: implement the configfs testing module Bartosz Golaszewski
2021-03-23 16:17 ` Andy Shevchenko
2021-03-25 9:29 ` Linus Walleij
2021-03-26 14:00 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210315091400.13772-3-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=corbet@lwn.net \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=jlbec@evilplan.org \
--cc=linus.walleij@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=warthog618@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).