media/pci: Assign value when defining variables
diff mbox series

Message ID 20210317030804.963-1-zuoqilin1@163.com
State Accepted
Commit 79f382b9a9d84cd099b79cf92aa9f73d0aa64481
Headers show
Series
  • media/pci: Assign value when defining variables
Related show

Commit Message

Zuo Qi Lin March 17, 2021, 3:08 a.m. UTC
From: zuoqilin <zuoqilin@yulong.com>

When defining variables and assigning values can be done at the same time.

Signed-off-by: zuoqilin <zuoqilin@yulong.com>
---
 drivers/media/pci/pt1/pt1.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Hans Verkuil March 21, 2021, 9:19 a.m. UTC | #1
Hi zuoqilin,

On 17/03/2021 04:08, zuoqilin1@163.com wrote:
> From: zuoqilin <zuoqilin@yulong.com>
> 
> When defining variables and assigning values can be done at the same time.

For future reference: add the name of the driver to the prefix. Saying
'media/pci:' suggests that you patch multiple PCI drivers in that directory.
But 'media/pci/pt1:' indicates that you patch only the pt1 driver.

I've updated the subject, so no need to repost, but remember this for next
time :-)

Regards,

	Hans

> 
> Signed-off-by: zuoqilin <zuoqilin@yulong.com>
> ---
>  drivers/media/pci/pt1/pt1.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/media/pci/pt1/pt1.c b/drivers/media/pci/pt1/pt1.c
> index 72b191c..f2aa368 100644
> --- a/drivers/media/pci/pt1/pt1.c
> +++ b/drivers/media/pci/pt1/pt1.c
> @@ -334,8 +334,7 @@ static int pt1_sync(struct pt1 *pt1)
>  static u64 pt1_identify(struct pt1 *pt1)
>  {
>  	int i;
> -	u64 id;
> -	id = 0;
> +	u64 id = 0;
>  	for (i = 0; i < 57; i++) {
>  		id |= (u64)(pt1_read_reg(pt1, 0) >> 30 & 1) << i;
>  		pt1_write_reg(pt1, 0, 0x00000008);
> @@ -1122,8 +1121,7 @@ static int pt1_i2c_end(struct pt1 *pt1, int addr)
>  
>  static void pt1_i2c_begin(struct pt1 *pt1, int *addrp)
>  {
> -	int addr;
> -	addr = 0;
> +	int addr = 0;
>  
>  	pt1_i2c_emit(pt1, addr,     0, 0, 1, 1, addr /* itself */);
>  	addr = addr + 1;
>

Patch
diff mbox series

diff --git a/drivers/media/pci/pt1/pt1.c b/drivers/media/pci/pt1/pt1.c
index 72b191c..f2aa368 100644
--- a/drivers/media/pci/pt1/pt1.c
+++ b/drivers/media/pci/pt1/pt1.c
@@ -334,8 +334,7 @@  static int pt1_sync(struct pt1 *pt1)
 static u64 pt1_identify(struct pt1 *pt1)
 {
 	int i;
-	u64 id;
-	id = 0;
+	u64 id = 0;
 	for (i = 0; i < 57; i++) {
 		id |= (u64)(pt1_read_reg(pt1, 0) >> 30 & 1) << i;
 		pt1_write_reg(pt1, 0, 0x00000008);
@@ -1122,8 +1121,7 @@  static int pt1_i2c_end(struct pt1 *pt1, int addr)
 
 static void pt1_i2c_begin(struct pt1 *pt1, int *addrp)
 {
-	int addr;
-	addr = 0;
+	int addr = 0;
 
 	pt1_i2c_emit(pt1, addr,     0, 0, 1, 1, addr /* itself */);
 	addr = addr + 1;