From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
stable@vger.kernel.org, Hui Wang <hui.wang@canonical.com>,
Takashi Iwai <tiwai@suse.de>
Subject: [PATCH 5.11 006/120] ALSA: hda: generic: Fix the micmute led init state
Date: Mon, 22 Mar 2021 13:26:29 +0100 [thread overview]
Message-ID: <20210322121929.876223206@linuxfoundation.org> (raw)
In-Reply-To: <20210322121929.669628946@linuxfoundation.org>
From: Hui Wang <hui.wang@canonical.com>
commit 2bf44e0ee95f39cc54ea1b942f0a027e0181ca4e upstream.
Recently we found the micmute led init state is not correct after
freshly installing the ubuntu linux on a Lenovo AIO machine. The
internal mic is not muted, but the micmute led is on and led mode is
'follow mute'. If we mute internal mic, the led is keeping on, then
unmute the internal mic, the led is off. And from then on, the
micmute led will work correctly.
So the micmute led init state is not correct. The led is controlled
by codec gpio (ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY), in the
patch_realtek, the gpio data is set to 0x4 initially and the led is
on with this data. In the hda_generic, the led_value is set to
0 initially, suppose users set the 'capture switch' to on from
user space and the micmute led should change to be off with this
operation, but the check "if (val == spec->micmute_led.led_value)" in
the call_micmute_led_update() will skip the led setting.
To guarantee the led state will be set by the 1st time of changing
"Capture Switch", set -1 to the init led_value.
Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
Link: https://lore.kernel.org/r/20210312041408.3776-1-hui.wang@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
sound/pci/hda/hda_generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/sound/pci/hda/hda_generic.c
+++ b/sound/pci/hda/hda_generic.c
@@ -4065,7 +4065,7 @@ static int add_micmute_led_hook(struct h
spec->micmute_led.led_mode = MICMUTE_LED_FOLLOW_MUTE;
spec->micmute_led.capture = 0;
- spec->micmute_led.led_value = 0;
+ spec->micmute_led.led_value = -1;
spec->micmute_led.old_hook = spec->cap_sync_hook;
spec->cap_sync_hook = update_micmute_led;
if (!snd_hda_gen_add_kctl(spec, NULL, &micmute_led_mode_ctl))
next prev parent reply other threads:[~2021-03-22 12:32 UTC|newest]
Thread overview: 132+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-22 12:26 [PATCH 5.11 000/120] 5.11.9-rc1 review Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 001/120] ASoC: ak4458: Add MODULE_DEVICE_TABLE Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 002/120] ASoC: ak5558: " Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 003/120] spi: cadence: set cqspi to the driver_data field of struct device Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 004/120] ALSA: dice: fix null pointer dereference when node is disconnected Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 005/120] ALSA: hda/realtek: apply pin quirk for XiaomiNotebook Pro Greg Kroah-Hartman
2021-03-22 12:26 ` Greg Kroah-Hartman [this message]
2021-03-22 12:26 ` [PATCH 5.11 007/120] ALSA: hda/realtek: Apply headset-mic quirks for Xiaomi Redmibook Air Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 008/120] ALSA: hda/realtek: fix mute/micmute LEDs for HP 840 G8 Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 009/120] ALSA: hda/realtek: fix mute/micmute LEDs for HP 440 G8 Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 010/120] ALSA: hda/realtek: fix mute/micmute LEDs for HP 850 G8 Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 011/120] Revert "PM: runtime: Update device status before letting suppliers suspend" Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 012/120] s390/vtime: fix increased steal time accounting Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 013/120] s390/pci: refactor zpci_create_device() Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 014/120] s390/pci: remove superfluous zdev->zbus check Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 015/120] s390/pci: fix leak of PCI device structure Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 016/120] zonefs: Fix O_APPEND async write handling Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 017/120] zonefs: prevent use of seq files as swap file Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 018/120] zonefs: fix to update .i_wr_refcnt correctly in zonefs_open_zone() Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 019/120] btrfs: fix race when cloning extent buffer during rewind of an old root Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 020/120] btrfs: fix slab cache flags for free space tree bitmap Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 021/120] vhost-vdpa: fix use-after-free of v->config_ctx Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 022/120] vhost-vdpa: set v->config_ctx to NULL if eventfd_ctx_fdget() fails Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 023/120] drm/amd/display: Copy over soc values before bounding box creation Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 024/120] drm/amd/display: Correct algorithm for reversed gamma Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 025/120] drm/amd/display: Remove MPC gamut remap logic for DCN30 Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 026/120] iommu/amd: Dont call early_amd_iommu_init() when AMD IOMMU is disabled Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 027/120] iommu/amd: Keep track of amd_iommu_irq_remap state Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 028/120] iommu/amd: Move Stoney Ridge check to detect_ivrs() Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 029/120] ASoC: fsl_ssi: Fix TDM slot setup for I2S mode Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 030/120] ASoC: Intel: bytcr_rt5640: Fix HP Pavilion x2 10-p0XX OVCD current threshold Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 031/120] ASoC: SOF: Intel: unregister DMIC device on probe error Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 032/120] ASoC: SOF: intel: fix wrong poll bits in dsp power down Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 033/120] ASoC: qcom: sdm845: Fix array out of bounds access Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 034/120] ASoC: qcom: sdm845: Fix array out of range on rx slim channels Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 035/120] ASoC: codecs: wcd934x: add a sanity check in set channel map Greg Kroah-Hartman
2021-03-22 12:26 ` [PATCH 5.11 036/120] ASoC: qcom: lpass-cpu: Fix lpass dai ids parse Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 037/120] ASoC: simple-card-utils: Do not handle device clock Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 038/120] afs: Fix accessing YFS xattrs on a non-YFS server Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 039/120] afs: Stop listxattr() from listing "afs.*" attributes Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 040/120] ALSA: usb-audio: Fix unintentional sign extension issue Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 041/120] nvme: fix Write Zeroes limitations Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 042/120] nvme-tcp: fix misuse of __smp_processor_id with preemption enabled Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 043/120] nvme-tcp: fix possible hang when failing to set io queues Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 044/120] nvme-tcp: fix a NULL deref when receiving a 0-length r2t PDU Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 045/120] nvmet: dont check iosqes,iocqes for discovery controllers Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 046/120] nfsd: Dont keep looking up unhashed files in the nfsd file cache Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 047/120] nfsd: dont abort copies early Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 048/120] NFSD: Repair misuse of sv_lock in 5.10.16-rt30 Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 049/120] NFSD: fix dest to src mount in inter-server COPY Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 050/120] svcrdma: disable timeouts on rdma backchannel Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 051/120] vfio: IOMMU_API should be selected Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 052/120] vhost_vdpa: fix the missing irq_bypass_unregister_producer() invocation Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 053/120] sunrpc: fix refcount leak for rpc auth modules Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 054/120] i915/perf: Start hrtimer only if sampling the OA buffer Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 055/120] iommu/tegra-smmu: Make tegra_smmu_probe_device() to handle all IOMMU phandles Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 056/120] pstore: Fix warning in pstore_kill_sb() Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 057/120] io_uring: ensure that SQPOLL thread is started for exit Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 058/120] net/qrtr: fix __netdev_alloc_skb call Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 059/120] kbuild: Fix <linux/version.h> for empty SUBLEVEL or PATCHLEVEL again Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 060/120] cifs: warn and fail if trying to use rootfs without the config option Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 061/120] cifs: fix allocation size on newly created files Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 062/120] RISC-V: Fix out-of-bounds accesses in init_resources() Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 063/120] riscv: Correct SPARSEMEM configuration Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 064/120] scsi: lpfc: Fix some error codes in debugfs Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 065/120] scsi: myrs: Fix a double free in myrs_cleanup() Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 066/120] scsi: ufs: ufs-mediatek: Correct operator & -> && Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 067/120] scsi: mpt3sas: Do not use GFP_KERNEL in atomic context Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 068/120] RISC-V: correct enum sbi_ext_rfence_fid Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 069/120] counter: stm32-timer-cnt: Report count function when SLAVE_MODE_DISABLED Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 070/120] ASoC: codecs: lpass-va-macro: mute/unmute all active decimators Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 071/120] ASoC: codecs: lpass-wsa-macro: fix RX MIX input controls Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 072/120] powerpc/vdso32: Add missing _restgpr_31_x to fix build failure Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 073/120] drm/ttm: Warn on pinning without holding a reference Greg Kroah-Hartman
2021-03-25 8:14 ` Christian König
2021-03-25 8:50 ` Greg Kroah-Hartman
2021-03-25 8:51 ` Christian König
2021-03-22 12:27 ` [PATCH 5.11 074/120] drm/ttm: make ttm_bo_unpin more defensive Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 075/120] gpiolib: Assign fwnode to parents if no primary one provided Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 076/120] nvme-rdma: fix possible hang when failing to set io queues Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 077/120] powerpc: Force inlining of cpu_has_feature() to avoid build failure Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 078/120] usb-storage: Add quirk to defeat Kindles automatic unload Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 079/120] usbip: Fix incorrect double assignment to udc->ud.tcp_rx Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 080/120] usb: gadget: configfs: Fix KASAN use-after-free Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 081/120] usb: typec: Remove vdo[3] part of tps6598x_rx_identity_reg struct Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 082/120] usb: typec: tcpm: Invoke power_supply_changed for tcpm-source-psy- Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 083/120] usb: dwc3: gadget: Allow runtime suspend if UDC unbinded Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 084/120] usb: dwc3: gadget: Prevent EP queuing while stopping transfers Greg Kroah-Hartman
2021-04-01 11:55 ` [PATCH] Revert "usb: dwc3: gadget: Prevent EP queuing while stopping transfers" Martin Kepplinger
2021-04-01 13:04 ` Greg KH
2021-04-01 13:11 ` [PATCH v2] " Martin Kepplinger
2021-04-01 14:14 ` Greg KH
2021-04-01 18:09 ` [PATCH] " Wesley Cheng
2021-04-02 9:27 ` Martin Kepplinger
2021-03-22 12:27 ` [PATCH 5.11 085/120] thunderbolt: Initialize HopID IDAs in tb_switch_alloc() Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 086/120] thunderbolt: Increase runtime PM reference count on DP tunnel discovery Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 087/120] iio:adc:stm32-adc: Add HAS_IOMEM dependency Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 088/120] iio:adc:qcom-spmi-vadc: add default scale to LR_MUX2_BAT_ID channel Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 089/120] iio: adis16400: Fix an error code in adis16400_initial_setup() Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 090/120] iio: gyro: mpu3050: Fix error handling in mpu3050_trigger_handler Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 091/120] iio: adc: ab8500-gpadc: Fix off by 10 to 3 Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 092/120] iio: adc: ad7949: fix wrong ADC result due to incorrect bit mask Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 093/120] iio: adc: adi-axi-adc: add proper Kconfig dependencies Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 094/120] iio: hid-sensor-humidity: Fix alignment issue of timestamp channel Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 095/120] iio: hid-sensor-prox: Fix scale not correct issue Greg Kroah-Hartman
2021-03-22 12:27 ` [PATCH 5.11 096/120] iio: hid-sensor-temperature: Fix issues of timestamp channel Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 097/120] counter: stm32-timer-cnt: fix ceiling write max value Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 098/120] counter: stm32-timer-cnt: fix ceiling miss-alignment with reload register Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 099/120] PCI: rpadlpar: Fix potential drc_name corruption in store functions Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 100/120] perf/x86/intel: Fix a crash caused by zero PEBS status Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 101/120] perf/x86/intel: Fix unchecked MSR access error caused by VLBR_EVENT Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 102/120] x86/ioapic: Ignore IRQ2 again Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 103/120] kernel, fs: Introduce and use set_restart_fn() and arch_set_restart_data() Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 104/120] x86: Move TS_COMPAT back to asm/thread_info.h Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 105/120] x86: Introduce TS_COMPAT_RESTART to fix get_nr_restart_syscall() Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 106/120] efivars: respect EFI_UNSUPPORTED return from firmware Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 107/120] ext4: fix error handling in ext4_end_enable_verity() Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 108/120] ext4: find old entry again if failed to rename whiteout Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 109/120] ext4: stop inode update before return Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 110/120] ext4: do not try to set xattr into ea_inode if value is empty Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 111/120] ext4: fix potential error in ext4_do_update_inode Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 112/120] ext4: fix timer use-after-free on failed mount Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 113/120] ext4: fix rename whiteout with fast commit Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 114/120] MAINTAINERS: move some real subsystems off of the staging mailing list Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 115/120] MAINTAINERS: move the staging subsystem to lists.linux.dev Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 116/120] static_call: Fix static_call_update() sanity check Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 117/120] efi: use 32-bit alignment for efi_guid_t literals Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 118/120] firmware/efi: Fix a use after bug in efi_mem_reserve_persistent Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 119/120] genirq: Disable interrupts for force threaded handlers Greg Kroah-Hartman
2021-03-22 12:28 ` [PATCH 5.11 120/120] x86/apic/of: Fix CPU devicetree-node lookups Greg Kroah-Hartman
2021-03-22 19:00 ` [PATCH 5.11 000/120] 5.11.9-rc1 review Naresh Kamboju
2021-03-22 21:50 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210322121929.876223206@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).