[11/17] auxdisplay: ht16k33: Convert to simple i2c probe function
diff mbox series

Message ID 20210322144848.1065067-12-geert@linux-m68k.org
State New, archived
Headers show
Series
  • auxdisplay: ht16k33: Add character display support
Related show

Commit Message

Geert Uytterhoeven March 22, 2021, 2:48 p.m. UTC
ht16k33_probe() does not use the passed i2c_device_id, so the driver can
be converted trivially to the new-style of i2c probing.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 drivers/auxdisplay/ht16k33.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Robin van der Gracht March 23, 2021, 8:31 a.m. UTC | #1
On 2021-03-22 15:48, Geert Uytterhoeven wrote:
> ht16k33_probe() does not use the passed i2c_device_id, so the driver 
> can
> be converted trivially to the new-style of i2c probing.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  drivers/auxdisplay/ht16k33.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/auxdisplay/ht16k33.c 
> b/drivers/auxdisplay/ht16k33.c
> index 13d18f218b4d196e..1b67f38109bddba8 100644
> --- a/drivers/auxdisplay/ht16k33.c
> +++ b/drivers/auxdisplay/ht16k33.c
> @@ -381,8 +381,7 @@ static int ht16k33_keypad_probe(struct i2c_client 
> *client,
>  	return input_register_device(keypad->dev);
>  }
> 
> -static int ht16k33_probe(struct i2c_client *client,
> -				  const struct i2c_device_id *id)
> +static int ht16k33_probe(struct i2c_client *client)
>  {
>  	int err;
>  	uint32_t dft_brightness;
> @@ -523,7 +522,7 @@ static const struct of_device_id ht16k33_of_match[] 
> = {
>  MODULE_DEVICE_TABLE(of, ht16k33_of_match);
> 
>  static struct i2c_driver ht16k33_driver = {
> -	.probe		= ht16k33_probe,
> +	.probe_new	= ht16k33_probe,
>  	.remove		= ht16k33_remove,
>  	.driver		= {
>  		.name		= DRIVER_NAME,

Acked-by: Robin van der Gracht <robin@protonic.nl>

Patch
diff mbox series

diff --git a/drivers/auxdisplay/ht16k33.c b/drivers/auxdisplay/ht16k33.c
index 13d18f218b4d196e..1b67f38109bddba8 100644
--- a/drivers/auxdisplay/ht16k33.c
+++ b/drivers/auxdisplay/ht16k33.c
@@ -381,8 +381,7 @@  static int ht16k33_keypad_probe(struct i2c_client *client,
 	return input_register_device(keypad->dev);
 }
 
-static int ht16k33_probe(struct i2c_client *client,
-				  const struct i2c_device_id *id)
+static int ht16k33_probe(struct i2c_client *client)
 {
 	int err;
 	uint32_t dft_brightness;
@@ -523,7 +522,7 @@  static const struct of_device_id ht16k33_of_match[] = {
 MODULE_DEVICE_TABLE(of, ht16k33_of_match);
 
 static struct i2c_driver ht16k33_driver = {
-	.probe		= ht16k33_probe,
+	.probe_new	= ht16k33_probe,
 	.remove		= ht16k33_remove,
 	.driver		= {
 		.name		= DRIVER_NAME,