From: Yang Li <yang.lee@linux.alibaba.com>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, Yang Li <yang.lee@linux.alibaba.com>
Subject: [PATCH] genirq: Add missing IRQF_ONESHOT
Date: Tue, 23 Mar 2021 17:38:41 +0800 [thread overview]
Message-ID: <1616492321-72383-1-git-send-email-yang.lee@linux.alibaba.com> (raw)
fixed the following coccicheck:
./kernel/irq/manage.c:2193:8-28: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
kernel/irq/manage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 21ea370..a309fd3 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -2191,7 +2191,7 @@ int request_any_context_irq(unsigned int irq, irq_handler_t handler,
if (irq_settings_is_nested_thread(desc)) {
ret = request_threaded_irq(irq, NULL, handler,
- flags, name, dev_id);
+ flags | IRQF_ONESHOT, name, dev_id);
return !ret ? IRQC_IS_NESTED : ret;
}
--
1.8.3.1
next reply other threads:[~2021-03-23 9:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 9:38 Yang Li [this message]
2021-03-25 13:52 ` [PATCH] genirq: Add missing IRQF_ONESHOT Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1616492321-72383-1-git-send-email-yang.lee@linux.alibaba.com \
--to=yang.lee@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).