genirq: Add missing IRQF_ONESHOT
diff mbox series

Message ID 1616492321-72383-1-git-send-email-yang.lee@linux.alibaba.com
State New, archived
Headers show
Series
  • genirq: Add missing IRQF_ONESHOT
Related show

Commit Message

Yang Li March 23, 2021, 9:38 a.m. UTC
fixed the following coccicheck:
./kernel/irq/manage.c:2193:8-28: ERROR: Threaded IRQ with no primary
handler requested without IRQF_ONESHOT

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 kernel/irq/manage.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Gleixner March 25, 2021, 1:52 p.m. UTC | #1
On Tue, Mar 23 2021 at 17:38, Yang Li wrote:
> fixed the following coccicheck:
> ./kernel/irq/manage.c:2193:8-28: ERROR: Threaded IRQ with no primary
> handler requested without IRQF_ONESHOT

This fixes nothing because it's for a nested thread and not relevant to
that check at all.

Thanks,

        tglx

Patch
diff mbox series

diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 21ea370..a309fd3 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -2191,7 +2191,7 @@  int request_any_context_irq(unsigned int irq, irq_handler_t handler,
 
 	if (irq_settings_is_nested_thread(desc)) {
 		ret = request_threaded_irq(irq, NULL, handler,
-					   flags, name, dev_id);
+					   flags | IRQF_ONESHOT, name, dev_id);
 		return !ret ? IRQC_IS_NESTED : ret;
 	}