From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Bob Peterson <rpeterso@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
cluster-devel@redhat.com
Subject: [PATCH 06/18] fs: gfs2: lops: Help out worthy kernel-doc headers and demote others
Date: Fri, 26 Mar 2021 09:11:39 +0000 [thread overview]
Message-ID: <20210326091151.311647-7-lee.jones@linaro.org> (raw)
In-Reply-To: <20210326091151.311647-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
fs/gfs2/lops.c:106: warning: Function parameter or member 'tr' not described in 'gfs2_unpin'
fs/gfs2/lops.c:106: warning: Excess function parameter 'flags' description in 'gfs2_unpin'
fs/gfs2/lops.c:300: warning: Function parameter or member 'biop' not described in 'gfs2_log_get_bio'
fs/gfs2/lops.c:300: warning: Excess function parameter 'bio' description in 'gfs2_log_get_bio'
fs/gfs2/lops.c:333: warning: Function parameter or member 'jd' not described in 'gfs2_log_write'
fs/gfs2/lops.c:428: warning: Function parameter or member 'head' not described in 'gfs2_jhead_pg_srch'
fs/gfs2/lops.c:471: warning: Function parameter or member 'head' not described in 'gfs2_jhead_process_page'
fs/gfs2/lops.c:513: warning: Function parameter or member 'keep_cache' not described in 'gfs2_find_jhead'
fs/gfs2/lops.c:983: warning: Function parameter or member 'sdp' not described in 'databuf_lo_before_commit'
fs/gfs2/lops.c:983: warning: Function parameter or member 'tr' not described in 'databuf_lo_before_commit'
Cc: Bob Peterson <rpeterso@redhat.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/gfs2/lops.c | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/fs/gfs2/lops.c b/fs/gfs2/lops.c
index a82f4747aa8d5..390ac939aa757 100644
--- a/fs/gfs2/lops.c
+++ b/fs/gfs2/lops.c
@@ -92,13 +92,10 @@ static void maybe_release_space(struct gfs2_bufdata *bd)
rgrp_unlock_local(rgd);
}
-/**
+/*
* gfs2_unpin - Unpin a buffer
* @sdp: the filesystem the buffer belongs to
* @bh: The buffer to unpin
- * @ai:
- * @flags: The inode dirty flags
- *
*/
static void gfs2_unpin(struct gfs2_sbd *sdp, struct buffer_head *bh,
@@ -281,7 +278,7 @@ static struct bio *gfs2_log_alloc_bio(struct gfs2_sbd *sdp, u64 blkno,
* gfs2_log_get_bio - Get cached log bio, or allocate a new one
* @sdp: The super block
* @blkno: The device block number we want to write to
- * @bio: The bio to get or allocate
+ * @biop: The bio to get or allocate
* @op: REQ_OP
* @end_io: The bi_end_io callback
* @flush: Always flush the current bio and allocate a new one?
@@ -317,6 +314,7 @@ static struct bio *gfs2_log_get_bio(struct gfs2_sbd *sdp, u64 blkno,
/**
* gfs2_log_write - write to log
* @sdp: the filesystem
+ * @jd: The journal descriptor
* @page: the page to write
* @size: the size of the data to write
* @offset: the offset within the page
@@ -417,6 +415,7 @@ static void gfs2_end_log_read(struct bio *bio)
/**
* gfs2_jhead_pg_srch - Look for the journal head in a given page.
* @jd: The journal descriptor
+ * @head: the head journal to start from
* @page: The page to look in
*
* Returns: 1 if found, 0 otherwise.
@@ -450,6 +449,7 @@ static bool gfs2_jhead_pg_srch(struct gfs2_jdesc *jd,
* gfs2_jhead_process_page - Search/cleanup a page
* @jd: The journal descriptor
* @index: Index of the page to look into
+ * @head: the head journal to start from
* @done: If set, perform only cleanup, else search and set if found.
*
* Find the page with 'index' in the journal's mapping. Search the page for
@@ -502,6 +502,7 @@ static struct bio *gfs2_chain_bio(struct bio *prev, unsigned int nr_iovecs)
* gfs2_find_jhead - find the head of a log
* @jd: The journal descriptor
* @head: The log descriptor for the head of the log is returned here
+ * @keep_cache: If set inode pages will not be truncated
*
* Do a search of a journal by reading it in large chunks using bios and find
* the valid log entry with the highest sequence number. (i.e. the log head)
@@ -974,7 +975,7 @@ static void revoke_lo_after_scan(struct gfs2_jdesc *jd, int error, int pass)
gfs2_revoke_clean(jd);
}
-/**
+/*
* databuf_lo_before_commit - Scan the data buffers, writing as we go
*
*/
--
2.27.0
next prev parent reply other threads:[~2021-03-26 9:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 9:11 [PATCH 00/18] Rid W=1 warnings from GFS2 Lee Jones
2021-03-26 9:11 ` [PATCH 01/18] fs: gfs2: dir: Finish off mostly complete headers demote others Lee Jones
2021-03-26 9:11 ` [PATCH 02/18] fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant ones Lee Jones
2021-03-26 9:11 ` [PATCH 03/18] fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others Lee Jones
2021-03-26 9:11 ` [PATCH 04/18] fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote others Lee Jones
2021-03-26 9:11 ` [PATCH 05/18] fs: gfs2: log: Fix a couple of param descriptions and demote non-conformant headers Lee Jones
2021-03-26 9:11 ` Lee Jones [this message]
2021-03-26 9:11 ` [PATCH 07/18] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones Lee Jones
2021-03-26 9:11 ` [PATCH 08/18] fs: gfs2: aops: Fix a little potential doc-rot Lee Jones
2021-03-26 9:11 ` [PATCH 09/18] fs: gfs2: meta_io: Add missing description for 'rahead' param Lee Jones
2021-03-26 9:11 ` [PATCH 10/18] fs: gfs2: inode: Fix worthy function headers demote others Lee Jones
2021-03-26 9:11 ` [PATCH 11/18] fs: gfs2: file: Strip out superflouous param description and demote kernel-doc abuse Lee Jones
2021-03-26 9:11 ` [PATCH 12/18] fs: gfs2: ops_fstype: Fix a little doc-rot Lee Jones
2021-03-26 9:11 ` [PATCH 13/18] fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad' Lee Jones
2021-03-26 9:11 ` [PATCH 14/18] fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours Lee Jones
2021-03-26 9:11 ` [PATCH 15/18] fs: gfs2: recovery: Provide missing param descriptions and remove one other Lee Jones
2021-03-26 9:11 ` [PATCH 16/18] fs: gfs2: super: Fix kernel-doc issues where feasible demote " Lee Jones
2021-03-26 9:11 ` [PATCH 17/18] fs: gfs2: util: Fix one conformant kernel-doc header and demote a bunch of abuses Lee Jones
2021-03-26 9:11 ` [PATCH 18/18] fs: gfs2: lock_dlm: Demote incomplete kernel-doc header Lee Jones
2021-04-06 9:11 ` [PATCH 00/18] Rid W=1 warnings from GFS2 Lee Jones
2021-04-06 11:44 ` Bob Peterson
2021-04-06 11:54 ` Lee Jones
2021-04-09 20:35 ` Andreas Gruenbacher
2021-04-12 7:37 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326091151.311647-7-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).