From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Bob Peterson <rpeterso@redhat.com>,
Andreas Gruenbacher <agruenba@redhat.com>,
cluster-devel@redhat.com
Subject: [PATCH 15/18] fs: gfs2: recovery: Provide missing param descriptions and remove one other
Date: Fri, 26 Mar 2021 09:11:48 +0000 [thread overview]
Message-ID: <20210326091151.311647-16-lee.jones@linaro.org> (raw)
In-Reply-To: <20210326091151.311647-1-lee.jones@linaro.org>
Fixes the following W=1 kernel build warning(s):
fs/gfs2/recovery.c:169: warning: Function parameter or member 'head' not described in 'get_log_header'
fs/gfs2/recovery.c:169: warning: Excess function parameter 'lh' description in 'get_log_header'
fs/gfs2/recovery.c:199: warning: Function parameter or member 'pass' not described in 'foreach_descriptor'
Cc: Bob Peterson <rpeterso@redhat.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
fs/gfs2/recovery.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/gfs2/recovery.c b/fs/gfs2/recovery.c
index 2821737740055..26004d5431165 100644
--- a/fs/gfs2/recovery.c
+++ b/fs/gfs2/recovery.c
@@ -154,7 +154,7 @@ int __get_log_header(struct gfs2_sbd *sdp, const struct gfs2_log_header *lh,
* get_log_header - read the log header for a given segment
* @jd: the journal
* @blk: the block to look at
- * @lh: the log header to return
+ * @head: the log header to return
*
* Read the log header for a given segement in a given journal. Do a few
* sanity checks on it.
@@ -187,6 +187,7 @@ static int get_log_header(struct gfs2_jdesc *jd, unsigned int blk,
* @jd: the journal
* @start: the first log header in the active region
* @end: the last log header (don't process the contents of this entry))
+ * @pass: iteration number (foreach_descriptor() is called in a for() loop)
*
* Call a given function once for every log descriptor in the active
* portion of the log.
--
2.27.0
next prev parent reply other threads:[~2021-03-26 9:13 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-26 9:11 [PATCH 00/18] Rid W=1 warnings from GFS2 Lee Jones
2021-03-26 9:11 ` [PATCH 01/18] fs: gfs2: dir: Finish off mostly complete headers demote others Lee Jones
2021-03-26 9:11 ` [PATCH 02/18] fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant ones Lee Jones
2021-03-26 9:11 ` [PATCH 03/18] fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others Lee Jones
2021-03-26 9:11 ` [PATCH 04/18] fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote others Lee Jones
2021-03-26 9:11 ` [PATCH 05/18] fs: gfs2: log: Fix a couple of param descriptions and demote non-conformant headers Lee Jones
2021-03-26 9:11 ` [PATCH 06/18] fs: gfs2: lops: Help out worthy kernel-doc headers and demote others Lee Jones
2021-03-26 9:11 ` [PATCH 07/18] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones Lee Jones
2021-03-26 9:11 ` [PATCH 08/18] fs: gfs2: aops: Fix a little potential doc-rot Lee Jones
2021-03-26 9:11 ` [PATCH 09/18] fs: gfs2: meta_io: Add missing description for 'rahead' param Lee Jones
2021-03-26 9:11 ` [PATCH 10/18] fs: gfs2: inode: Fix worthy function headers demote others Lee Jones
2021-03-26 9:11 ` [PATCH 11/18] fs: gfs2: file: Strip out superflouous param description and demote kernel-doc abuse Lee Jones
2021-03-26 9:11 ` [PATCH 12/18] fs: gfs2: ops_fstype: Fix a little doc-rot Lee Jones
2021-03-26 9:11 ` [PATCH 13/18] fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad' Lee Jones
2021-03-26 9:11 ` [PATCH 14/18] fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours Lee Jones
2021-03-26 9:11 ` Lee Jones [this message]
2021-03-26 9:11 ` [PATCH 16/18] fs: gfs2: super: Fix kernel-doc issues where feasible demote one other Lee Jones
2021-03-26 9:11 ` [PATCH 17/18] fs: gfs2: util: Fix one conformant kernel-doc header and demote a bunch of abuses Lee Jones
2021-03-26 9:11 ` [PATCH 18/18] fs: gfs2: lock_dlm: Demote incomplete kernel-doc header Lee Jones
2021-04-06 9:11 ` [PATCH 00/18] Rid W=1 warnings from GFS2 Lee Jones
2021-04-06 11:44 ` Bob Peterson
2021-04-06 11:54 ` Lee Jones
2021-04-09 20:35 ` Andreas Gruenbacher
2021-04-12 7:37 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210326091151.311647-16-lee.jones@linaro.org \
--to=lee.jones@linaro.org \
--cc=agruenba@redhat.com \
--cc=cluster-devel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpeterso@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).