linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org, Bob Peterson <rpeterso@redhat.com>,
	Andreas Gruenbacher <agruenba@redhat.com>,
	cluster-devel@redhat.com
Subject: [PATCH 16/18] fs: gfs2: super: Fix kernel-doc issues where feasible demote one other
Date: Fri, 26 Mar 2021 09:11:49 +0000	[thread overview]
Message-ID: <20210326091151.311647-17-lee.jones@linaro.org> (raw)
In-Reply-To: <20210326091151.311647-1-lee.jones@linaro.org>

Fixes the following W=1 kernel build warning(s):

 fs/gfs2/super.c:397: warning: Excess function parameter 'state' description in 'gfs2_lock_fs_check_clean'
 fs/gfs2/super.c:397: warning: Excess function parameter 't_gh' description in 'gfs2_lock_fs_check_clean'
 fs/gfs2/super.c:709: warning: Function parameter or member 'wait' not described in 'gfs2_sync_fs'
 fs/gfs2/super.c:821: warning: expecting prototype for statfs_fill(). Prototype was for statfs_slow_fill() instead
 fs/gfs2/super.c:916: warning: Function parameter or member 'sc' not described in 'gfs2_statfs_i'
 fs/gfs2/super.c:916: warning: Excess function parameter 'sg' description in 'gfs2_statfs_i'
 fs/gfs2/super.c:948: warning: Function parameter or member 'dentry' not described in 'gfs2_statfs'
 fs/gfs2/super.c:948: warning: Function parameter or member 'buf' not described in 'gfs2_statfs'
 fs/gfs2/super.c:948: warning: Excess function parameter 'sb' description in 'gfs2_statfs'
 fs/gfs2/super.c:948: warning: Excess function parameter 'statfsbuf' description in 'gfs2_statfs'
 fs/gfs2/super.c:1281: warning: Function parameter or member 'gh' not described in 'evict_should_delete'

Cc: Bob Peterson <rpeterso@redhat.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>
Cc: cluster-devel@redhat.com
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
 fs/gfs2/super.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/fs/gfs2/super.c b/fs/gfs2/super.c
index 9e91c9d92bd65..aba117aa433dc 100644
--- a/fs/gfs2/super.c
+++ b/fs/gfs2/super.c
@@ -387,8 +387,6 @@ struct lfcc {
  * gfs2_lock_fs_check_clean - Stop all writes to the FS and check that all
  *                            journals are clean
  * @sdp: the file system
- * @state: the state to put the transaction lock into
- * @t_gh: the hold on the transaction lock
  *
  * Returns: errno
  */
@@ -698,7 +696,7 @@ static void gfs2_put_super(struct super_block *sb)
 	free_sbd(sdp);
 }
 
-/**
+/*
  * gfs2_sync_fs - sync the filesystem
  * @sb: the superblock
  *
@@ -809,7 +807,7 @@ static int gfs2_unfreeze(struct super_block *sb)
 }
 
 /**
- * statfs_fill - fill in the sg for a given RG
+ * statfs_slow_fill - fill in the sg for a given RG
  * @rgd: the RG
  * @sc: the sc structure
  *
@@ -907,7 +905,7 @@ static int gfs2_statfs_slow(struct gfs2_sbd *sdp, struct gfs2_statfs_change_host
 /**
  * gfs2_statfs_i - Do a statfs
  * @sdp: the filesystem
- * @sg: the sg structure
+ * @sc: the sc structure
  *
  * Returns: errno
  */
@@ -938,8 +936,8 @@ static int gfs2_statfs_i(struct gfs2_sbd *sdp, struct gfs2_statfs_change_host *s
 
 /**
  * gfs2_statfs - Gather and return stats about the filesystem
- * @sb: The superblock
- * @statfsbuf: The buffer
+ * @dentry: The name of the link
+ * @buf: The buffer
  *
  * Returns: 0 on success or error code
  */
@@ -1270,6 +1268,7 @@ static bool gfs2_upgrade_iopen_glock(struct inode *inode)
 /**
  * evict_should_delete - determine whether the inode is eligible for deletion
  * @inode: The inode to evict
+ * @gh: the holder structure
  *
  * This function determines whether the evicted inode is eligible to be deleted
  * and locks the inode glock.
-- 
2.27.0


  parent reply	other threads:[~2021-03-26  9:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-26  9:11 [PATCH 00/18] Rid W=1 warnings from GFS2 Lee Jones
2021-03-26  9:11 ` [PATCH 01/18] fs: gfs2: dir: Finish off mostly complete headers demote others Lee Jones
2021-03-26  9:11 ` [PATCH 02/18] fs: gfs2: xattr: Help out some kernel-doc header demote non-conformant ones Lee Jones
2021-03-26  9:11 ` [PATCH 03/18] fs: gfs2: bmap: Demote half-complete kernel-doc headers fix others Lee Jones
2021-03-26  9:11 ` [PATCH 04/18] fs: gfs2: glops: Fix a couple of kernel-doc misdemeanours demote others Lee Jones
2021-03-26  9:11 ` [PATCH 05/18] fs: gfs2: log: Fix a couple of param descriptions and demote non-conformant headers Lee Jones
2021-03-26  9:11 ` [PATCH 06/18] fs: gfs2: lops: Help out worthy kernel-doc headers and demote others Lee Jones
2021-03-26  9:11 ` [PATCH 07/18] fs: gfs2: glock: Fix some deficient kernel-doc headers and demote non-conformant ones Lee Jones
2021-03-26  9:11 ` [PATCH 08/18] fs: gfs2: aops: Fix a little potential doc-rot Lee Jones
2021-03-26  9:11 ` [PATCH 09/18] fs: gfs2: meta_io: Add missing description for 'rahead' param Lee Jones
2021-03-26  9:11 ` [PATCH 10/18] fs: gfs2: inode: Fix worthy function headers demote others Lee Jones
2021-03-26  9:11 ` [PATCH 11/18] fs: gfs2: file: Strip out superflouous param description and demote kernel-doc abuse Lee Jones
2021-03-26  9:11 ` [PATCH 12/18] fs: gfs2: ops_fstype: Fix a little doc-rot Lee Jones
2021-03-26  9:11 ` [PATCH 13/18] fs: gfs2: quota: Fix incorrect param name in 'gfs2_quotad' Lee Jones
2021-03-26  9:11 ` [PATCH 14/18] fs: gfs2: rgrp: Fix a few kernel-doc misdemeanours Lee Jones
2021-03-26  9:11 ` [PATCH 15/18] fs: gfs2: recovery: Provide missing param descriptions and remove one other Lee Jones
2021-03-26  9:11 ` Lee Jones [this message]
2021-03-26  9:11 ` [PATCH 17/18] fs: gfs2: util: Fix one conformant kernel-doc header and demote a bunch of abuses Lee Jones
2021-03-26  9:11 ` [PATCH 18/18] fs: gfs2: lock_dlm: Demote incomplete kernel-doc header Lee Jones
2021-04-06  9:11 ` [PATCH 00/18] Rid W=1 warnings from GFS2 Lee Jones
2021-04-06 11:44   ` Bob Peterson
2021-04-06 11:54     ` Lee Jones
2021-04-09 20:35       ` Andreas Gruenbacher
2021-04-12  7:37         ` Lee Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210326091151.311647-17-lee.jones@linaro.org \
    --to=lee.jones@linaro.org \
    --cc=agruenba@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpeterso@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).