From: Bhaumik Bhatt <bbhatt@codeaurora.org>
To: manivannan.sadhasivam@linaro.org
Cc: linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org,
jhugo@codeaurora.org, linux-kernel@vger.kernel.org,
carl.yin@quectel.com, naveen.kumar@quectel.com,
loic.poulain@linaro.org, abickett@codeaurora.org,
Bhaumik Bhatt <bbhatt@codeaurora.org>
Subject: [PATCH v1 2/7] bus: mhi: core: Wait for ready after an EDL firmware download
Date: Mon, 29 Mar 2021 18:28:19 -0700 [thread overview]
Message-ID: <1617067704-28850-3-git-send-email-bbhatt@codeaurora.org> (raw)
In-Reply-To: <1617067704-28850-1-git-send-email-bbhatt@codeaurora.org>
Currently, the firmware load handler returns after the EDL image
is downloaded. Wait for an MHI READY transition instead as the
specification expects so as to proceed with further bootup such
as device entering Flash Programmer execution environment.
Signed-off-by: Bhaumik Bhatt <bbhatt@codeaurora.org>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/bus/mhi/core/boot.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/bus/mhi/core/boot.c b/drivers/bus/mhi/core/boot.c
index 84c2117..0f0ae88 100644
--- a/drivers/bus/mhi/core/boot.c
+++ b/drivers/bus/mhi/core/boot.c
@@ -418,7 +418,7 @@ void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl)
/* If device is in pass through, do reset to ready state transition */
if (mhi_cntrl->ee == MHI_EE_PTHRU)
- goto fw_load_ee_pthru;
+ goto fw_load_ready_state;
fw_name = (mhi_cntrl->ee == MHI_EE_EDL) ?
mhi_cntrl->edl_image : mhi_cntrl->fw_image;
@@ -460,10 +460,10 @@ void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl)
goto error_fw_load;
}
- /* Exit if EDL image was loaded */
+ /* Wait for ready since EDL image was loaded */
if (fw_name == mhi_cntrl->edl_image) {
release_firmware(firmware);
- return;
+ goto fw_load_ready_state;
}
write_lock_irq(&mhi_cntrl->pm_lock);
@@ -488,7 +488,7 @@ void mhi_fw_load_handler(struct mhi_controller *mhi_cntrl)
release_firmware(firmware);
-fw_load_ee_pthru:
+fw_load_ready_state:
/* Transitioning into MHI RESET->READY state */
ret = mhi_ready_state_transition(mhi_cntrl);
if (ret) {
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2021-03-30 1:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 1:28 [PATCH v1 0/7] MHI Emergency download and flash programmer support Bhaumik Bhatt
2021-03-30 1:28 ` [PATCH v1 1/7] bus: mhi: core: Rely on accurate method to determine EDL mode Bhaumik Bhatt
2021-03-30 8:00 ` Loic Poulain
2021-03-30 1:28 ` Bhaumik Bhatt [this message]
2021-03-30 8:01 ` [PATCH v1 2/7] bus: mhi: core: Wait for ready after an EDL firmware download Loic Poulain
2021-03-30 1:28 ` [PATCH v1 3/7] bus: mhi: core: Handle EDL mode entry appropriately Bhaumik Bhatt
2021-03-30 8:01 ` Loic Poulain
2021-03-31 10:59 ` Manivannan Sadhasivam
2021-03-30 1:28 ` [PATCH v1 4/7] bus: mhi: core: Add support for Flash Programmer execution environment Bhaumik Bhatt
2021-03-30 8:02 ` Loic Poulain
2021-03-31 11:11 ` Manivannan Sadhasivam
2021-03-30 1:28 ` [PATCH v1 5/7] bus: mhi: core: Identify Flash Programmer as a mission mode use case Bhaumik Bhatt
2021-03-30 8:02 ` Loic Poulain
2021-03-30 1:28 ` [PATCH v1 6/7] bus: mhi: core: Wait for MHI READY state in most scenarios Bhaumik Bhatt
2021-03-30 8:03 ` Loic Poulain
2021-03-31 11:13 ` Manivannan Sadhasivam
2021-03-30 1:28 ` [PATCH v1 7/7] bus: mhi: core: Improve state strings for debug messages Bhaumik Bhatt
2021-03-30 8:03 ` Loic Poulain
2021-03-31 11:16 ` [PATCH v1 0/7] MHI Emergency download and flash programmer support Manivannan Sadhasivam
2021-03-31 17:01 ` Bhaumik Bhatt
2021-03-31 11:24 ` Manivannan Sadhasivam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617067704-28850-3-git-send-email-bbhatt@codeaurora.org \
--to=bbhatt@codeaurora.org \
--cc=abickett@codeaurora.org \
--cc=carl.yin@quectel.com \
--cc=hemantk@codeaurora.org \
--cc=jhugo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=naveen.kumar@quectel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).