From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org,
Ravi Kumar Bokka <rbokka@codeaurora.org>,
Douglas Anderson <dianders@chromium.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: [PATCH 03/10] drivers: nvmem: Fix voltage settings for QTI qfprom-efuse
Date: Tue, 30 Mar 2021 12:12:34 +0100 [thread overview]
Message-ID: <20210330111241.19401-4-srinivas.kandagatla@linaro.org> (raw)
In-Reply-To: <20210330111241.19401-1-srinivas.kandagatla@linaro.org>
From: Ravi Kumar Bokka <rbokka@codeaurora.org>
QFPROM controller hardware requires 1.8V min for fuse blowing.
So, this change sets the voltage to 1.8V, required to blow the fuse
for qfprom-efuse controller.
To disable fuse blowing, we set the voltage to 0V since this may
be a shared rail and may be able to run at a lower rate when we're
not blowing fuses.
Fixes: 93b4e49f8c86 ("nvmem: qfprom: Add fuse blowing support")
Reported-by: Douglas Anderson <dianders@chromium.org>
Suggested-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Ravi Kumar Bokka <rbokka@codeaurora.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/nvmem/qfprom.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
index 6cace24dfbf7..100d69d8f2e1 100644
--- a/drivers/nvmem/qfprom.c
+++ b/drivers/nvmem/qfprom.c
@@ -127,6 +127,16 @@ static void qfprom_disable_fuse_blowing(const struct qfprom_priv *priv,
{
int ret;
+ /*
+ * This may be a shared rail and may be able to run at a lower rate
+ * when we're not blowing fuses. At the moment, the regulator framework
+ * applies voltage constraints even on disabled rails, so remove our
+ * constraints and allow the rail to be adjusted by other users.
+ */
+ ret = regulator_set_voltage(priv->vcc, 0, INT_MAX);
+ if (ret)
+ dev_warn(priv->dev, "Failed to set 0 voltage (ignoring)\n");
+
ret = regulator_disable(priv->vcc);
if (ret)
dev_warn(priv->dev, "Failed to disable regulator (ignoring)\n");
@@ -172,6 +182,17 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
goto err_clk_prepared;
}
+ /*
+ * Hardware requires 1.8V min for fuse blowing; this may be
+ * a rail shared do don't specify a max--regulator constraints
+ * will handle.
+ */
+ ret = regulator_set_voltage(priv->vcc, 1800000, INT_MAX);
+ if (ret) {
+ dev_err(priv->dev, "Failed to set 1.8 voltage\n");
+ goto err_clk_rate_set;
+ }
+
ret = regulator_enable(priv->vcc);
if (ret) {
dev_err(priv->dev, "Failed to enable regulator\n");
--
2.21.0
next prev parent reply other threads:[~2021-03-30 11:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 11:12 [PATCH 00/10] nvmem: patches (set 1) for 5.13 Srinivas Kandagatla
2021-03-30 11:12 ` [PATCH 01/10] dt-bindings: nvmem: mediatek: add support for MediaTek mt8192 SoC Srinivas Kandagatla
2021-03-30 11:12 ` [PATCH 02/10] nvmem: convert comma to semicolon Srinivas Kandagatla
2021-03-30 11:12 ` Srinivas Kandagatla [this message]
2021-03-30 11:12 ` [PATCH 04/10] dt-bindings: nvmem: add Broadcom's NVRAM Srinivas Kandagatla
2021-03-30 11:12 ` [PATCH 05/10] nvmem: brcm_nvram: new driver exposing " Srinivas Kandagatla
2021-03-30 11:12 ` [PATCH 06/10] nvmem: core: Add functions to make number reading easy Srinivas Kandagatla
2021-03-30 11:12 ` [PATCH 07/10] nvmem: core: Fix unintentional sign extension issue Srinivas Kandagatla
2021-03-30 11:12 ` [PATCH 08/10] nvmem: rmem: fix undefined reference to memremap Srinivas Kandagatla
2021-03-30 11:12 ` [PATCH 09/10] dt-bindings: nvmem: Add SoC compatible for sc7280 Srinivas Kandagatla
2021-03-30 11:12 ` [PATCH 10/10] nvmem: qfprom: Add support for fuse blowing on sc7280 Srinivas Kandagatla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330111241.19401-4-srinivas.kandagatla@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rbokka@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).