fs/buffer.c: Delete redundant uptodate check for buffer
diff mbox series

Message ID 1617260222-13797-1-git-send-email-zhangshaokun@hisilicon.com
State New, archived
Headers show
Series
  • fs/buffer.c: Delete redundant uptodate check for buffer
Related show

Commit Message

Shaokun Zhang April 1, 2021, 6:57 a.m. UTC
From: Yang Guo <guoyang2@huawei.com>

The buffer uptodate state has been checked in function set_buffer_uptodate,
there is no need use buffer_uptodate before calling set_buffer_uptodate and
delete it.

Cc: Alexander Viro <viro@zeniv.linux.org.uk> 
Signed-off-by: Yang Guo <guoyang2@huawei.com>
Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
---
 fs/buffer.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Comments

Shaokun Zhang April 12, 2021, 1:54 a.m. UTC | #1
+Cc: Andrew Morton

On 2021/4/1 14:57, Shaokun Zhang wrote:
> From: Yang Guo <guoyang2@huawei.com>
> 
> The buffer uptodate state has been checked in function set_buffer_uptodate,
> there is no need use buffer_uptodate before calling set_buffer_uptodate and
> delete it.
> 
> Cc: Alexander Viro <viro@zeniv.linux.org.uk> 
> Signed-off-by: Yang Guo <guoyang2@huawei.com>
> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
> ---
>  fs/buffer.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/buffer.c b/fs/buffer.c
> index 673cfbef9eec..2c0d0b3f3203 100644
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -2055,8 +2055,7 @@ int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
>  		block_end = block_start + blocksize;
>  		if (block_end <= from || block_start >= to) {
>  			if (PageUptodate(page)) {
> -				if (!buffer_uptodate(bh))
> -					set_buffer_uptodate(bh);
> +				set_buffer_uptodate(bh);
>  			}
>  			continue;
>  		}
> @@ -2088,8 +2087,7 @@ int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
>  			}
>  		}
>  		if (PageUptodate(page)) {
> -			if (!buffer_uptodate(bh))
> -				set_buffer_uptodate(bh);
> +			set_buffer_uptodate(bh);
>  			continue; 
>  		}
>  		if (!buffer_uptodate(bh) && !buffer_delay(bh) &&
>
Shaokun Zhang May 7, 2021, 3:44 a.m. UTC | #2
Hi Andrew,

A gentle ping.

Thanks,
Shaokun

On 2021/4/12 9:54, Shaokun Zhang wrote:
> +Cc: Andrew Morton
> 
> On 2021/4/1 14:57, Shaokun Zhang wrote:
>> From: Yang Guo <guoyang2@huawei.com>
>>
>> The buffer uptodate state has been checked in function set_buffer_uptodate,
>> there is no need use buffer_uptodate before calling set_buffer_uptodate and
>> delete it.
>>
>> Cc: Alexander Viro <viro@zeniv.linux.org.uk> 
>> Signed-off-by: Yang Guo <guoyang2@huawei.com>
>> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com>
>> ---
>>  fs/buffer.c | 6 ++----
>>  1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/fs/buffer.c b/fs/buffer.c
>> index 673cfbef9eec..2c0d0b3f3203 100644
>> --- a/fs/buffer.c
>> +++ b/fs/buffer.c
>> @@ -2055,8 +2055,7 @@ int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
>>  		block_end = block_start + blocksize;
>>  		if (block_end <= from || block_start >= to) {
>>  			if (PageUptodate(page)) {
>> -				if (!buffer_uptodate(bh))
>> -					set_buffer_uptodate(bh);
>> +				set_buffer_uptodate(bh);
>>  			}
>>  			continue;
>>  		}
>> @@ -2088,8 +2087,7 @@ int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
>>  			}
>>  		}
>>  		if (PageUptodate(page)) {
>> -			if (!buffer_uptodate(bh))
>> -				set_buffer_uptodate(bh);
>> +			set_buffer_uptodate(bh);
>>  			continue; 
>>  		}
>>  		if (!buffer_uptodate(bh) && !buffer_delay(bh) &&
>>

Patch
diff mbox series

diff --git a/fs/buffer.c b/fs/buffer.c
index 673cfbef9eec..2c0d0b3f3203 100644
--- a/fs/buffer.c
+++ b/fs/buffer.c
@@ -2055,8 +2055,7 @@  int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
 		block_end = block_start + blocksize;
 		if (block_end <= from || block_start >= to) {
 			if (PageUptodate(page)) {
-				if (!buffer_uptodate(bh))
-					set_buffer_uptodate(bh);
+				set_buffer_uptodate(bh);
 			}
 			continue;
 		}
@@ -2088,8 +2087,7 @@  int __block_write_begin_int(struct page *page, loff_t pos, unsigned len,
 			}
 		}
 		if (PageUptodate(page)) {
-			if (!buffer_uptodate(bh))
-				set_buffer_uptodate(bh);
+			set_buffer_uptodate(bh);
 			continue; 
 		}
 		if (!buffer_uptodate(bh) && !buffer_delay(bh) &&