fs/debugfs: Convert to DEFINE_SHOW_ATTRIBUTE
diff mbox series

Message ID 20210402121141.82-1-zuoqilin1@163.com
State New, archived
Headers show
Series
  • fs/debugfs: Convert to DEFINE_SHOW_ATTRIBUTE
Related show

Commit Message

Zuo Qi Lin April 2, 2021, 12:11 p.m. UTC
From: zuoqilin <zuoqilin@yulong.com>

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by: zuoqilin <zuoqilin@yulong.com>
---
 fs/debugfs/file.c | 16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)

Comments

Greg KH April 2, 2021, 12:22 p.m. UTC | #1
On Fri, Apr 02, 2021 at 08:11:41PM +0800, zuoqilin1@163.com wrote:
> From: zuoqilin <zuoqilin@yulong.com>

Please use your full/real name.

thanks,

greg k-h
Zuo Qi Lin April 7, 2021, 2:22 a.m. UTC | #2
On Fri, 2 Apr 2021 14:22:24 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Fri, Apr 02, 2021 at 08:11:41PM +0800, zuoqilin1@163.com wrote:
> > From: zuoqilin <zuoqilin@yulong.com>  
> 
> Please use your full/real name.
> 
> thanks,
> 
> greg k-h

-----------------------------------------------------------
Hi 

My name is Zuo Qilin. I think if the number after my name is causing
you doubts, i am sorry for that, because my name has been registered by
others, so i can only distinguish by adding numbers after my name.

Thanks.
BR.
Greg KH April 7, 2021, 5:05 a.m. UTC | #3
On Wed, Apr 07, 2021 at 10:22:06AM +0800, Zuo Qi Lin wrote:
> On Fri, 2 Apr 2021 14:22:24 +0200
> Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> > On Fri, Apr 02, 2021 at 08:11:41PM +0800, zuoqilin1@163.com wrote:
> > > From: zuoqilin <zuoqilin@yulong.com>  
> > 
> > Please use your full/real name.
> > 
> > thanks,
> > 
> > greg k-h
> 
> -----------------------------------------------------------
> Hi 
> 
> My name is Zuo Qilin.

Great!  Then use that above :)

Also that name does not match your "From: " name in your email, here
either, so please just get them all the same when sending a patch.

thanks,

greg k-h
Zuo Qi Lin April 14, 2021, 1:25 p.m. UTC | #4
On Wed, 7 Apr 2021 07:05:17 +0200
Greg KH <gregkh@linuxfoundation.org> wrote:

> On Wed, Apr 07, 2021 at 10:22:06AM +0800, Zuo Qi Lin wrote:
> > On Fri, 2 Apr 2021 14:22:24 +0200
> > Greg KH <gregkh@linuxfoundation.org> wrote:
> >   
> > > On Fri, Apr 02, 2021 at 08:11:41PM +0800, zuoqilin1@163.com
> > > wrote:  
> > > > From: zuoqilin <zuoqilin@yulong.com>    
> > > 
> > > Please use your full/real name.
> > > 
> > > thanks,
> > > 
> > > greg k-h  
> > 
> > -----------------------------------------------------------
> > Hi 
> > 
> > My name is Zuo Qilin.  
> 
> Great!  Then use that above :)
> 
> Also that name does not match your "From: " name in your email, here
> either, so please just get them all the same when sending a patch.
> 
> thanks,
> 
> greg k-h

-----------------------------------------------------------
Hi 
  I understand what you mean, i also tried some methods, but when using
git send-email. I still can’t change it to my name, it’s still my email
account. Sorry about this, and accept your rejection of my patch.
Thanks!
BR.

Patch
diff mbox series

diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c
index 686e0ad..d670ca3 100644
--- a/fs/debugfs/file.c
+++ b/fs/debugfs/file.c
@@ -1045,7 +1045,7 @@  void debugfs_print_regs32(struct seq_file *s, const struct debugfs_reg32 *regs,
 }
 EXPORT_SYMBOL_GPL(debugfs_print_regs32);
 
-static int debugfs_show_regset32(struct seq_file *s, void *data)
+static int regset32_show(struct seq_file *s, void *data)
 {
 	struct debugfs_regset32 *regset = s->private;
 
@@ -1060,17 +1060,7 @@  static int debugfs_show_regset32(struct seq_file *s, void *data)
 	return 0;
 }
 
-static int debugfs_open_regset32(struct inode *inode, struct file *file)
-{
-	return single_open(file, debugfs_show_regset32, inode->i_private);
-}
-
-static const struct file_operations fops_regset32 = {
-	.open =		debugfs_open_regset32,
-	.read =		seq_read,
-	.llseek =	seq_lseek,
-	.release =	single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(regset32);
 
 /**
  * debugfs_create_regset32 - create a debugfs file that returns register values
@@ -1091,7 +1081,7 @@  void debugfs_create_regset32(const char *name, umode_t mode,
 			     struct dentry *parent,
 			     struct debugfs_regset32 *regset)
 {
-	debugfs_create_file(name, mode, parent, regset, &fops_regset32);
+	debugfs_create_file(name, mode, parent, regset, &regset32_fops);
 }
 EXPORT_SYMBOL_GPL(debugfs_create_regset32);