From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: dan.carpenter@oracle.com, joe@perches.com,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Fabio Aiuto <fabioaiuto83@gmail.com>
Subject: [PATCH 07/10] staging: rtl8723bs: place constant on the right side of the test
Date: Mon, 5 Apr 2021 18:49:54 +0200 [thread overview]
Message-ID: <8a6967abaef8b2edad6dc829dd232a7f048899d2.1617640221.git.fabioaiuto83@gmail.com> (raw)
In-Reply-To: <cover.1617640221.git.fabioaiuto83@gmail.com>
fix following post-hook checkpatch issue:
WARNING: Comparisons should place the constant on the right side of the test
85: FILE: drivers/staging/rtl8723bs/hal/sdio_halinit.c:676:
+ if (_FAIL == ret)
Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index cec72abc983c..5553246fa80b 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -673,7 +673,7 @@ static u32 rtl8723bs_hal_init(struct adapter *padapter)
/* rtw_hal_disable_interrupt(padapter); */
ret = _InitPowerOn_8723BS(padapter);
- if (_FAIL == ret)
+ if (ret == _FAIL)
return _FAIL;
rtw_write8(padapter, REG_EARLY_MODE_CONTROL, 0);
--
2.20.1
next prev parent reply other threads:[~2021-04-05 16:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-05 16:49 [PATCH 00/10] staging: rtl8723bs: completely remove RT_TRACE logs Fabio Aiuto
2021-04-05 16:49 ` [PATCH 01/10] staging: rtl8723bs: remove all RT_TRACE logs in hal/ and os_dep/ Fabio Aiuto
2021-04-05 16:49 ` [PATCH 02/10] staging: rtl8723bs: remove commented out " Fabio Aiuto
2021-04-09 10:12 ` Dan Carpenter
2021-04-09 10:23 ` Fabio Aiuto
2021-04-05 16:49 ` [PATCH 03/10] staging: rtl8723bs: remove RT_TRACE log definitions Fabio Aiuto
2021-04-05 16:49 ` [PATCH 04/10] staging: rtl8723bs: remove empty if, else blocks after RT_TRACE deletion Fabio Aiuto
2021-04-05 16:49 ` [PATCH 05/10] staging: rtl8723bs: remove empty #ifdef " Fabio Aiuto
2021-04-05 16:49 ` [PATCH 06/10] staging: rtl8723bs: remove unnecessary bracks " Fabio Aiuto
2021-04-05 16:49 ` Fabio Aiuto [this message]
2021-04-05 16:49 ` [PATCH 08/10] staging: rtl8723bs: rewrite comparisons to null Fabio Aiuto
2021-04-05 16:49 ` [PATCH 09/10] staging: rtl8723bs: remove empty for cycles Fabio Aiuto
2021-04-05 16:49 ` [PATCH 10/10] staging: rtl8723bs: remove commented code block Fabio Aiuto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a6967abaef8b2edad6dc829dd232a7f048899d2.1617640221.git.fabioaiuto83@gmail.com \
--to=fabioaiuto83@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).