linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabio Aiuto <fabioaiuto83@gmail.com>
To: gregkh@linuxfoundation.org
Cc: dan.carpenter@oracle.com, joe@perches.com,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
	Fabio Aiuto <fabioaiuto83@gmail.com>
Subject: [PATCH 10/10] staging: rtl8723bs: remove commented code block
Date: Mon,  5 Apr 2021 18:49:57 +0200	[thread overview]
Message-ID: <b930cfc476c97f2ae5c5b90c1314a6270d56a539.1617640221.git.fabioaiuto83@gmail.com> (raw)
In-Reply-To: <cover.1617640221.git.fabioaiuto83@gmail.com>

remove commented 5G code block in hal/hal_com_phycfg.c
which contained removed RT_TRACE log

as reported in the driver's TODO file:

    - find and remove remaining code valid only for 5 GHz.
      Most of the obvious ones have been removed,
      but things like channel > 14 still exist.

so just removed obsolete commented code.

Suggested-by: Joe Perches <joe@perches.com>
Signed-off-by: Fabio Aiuto <fabioaiuto83@gmail.com>
---
 .../staging/rtl8723bs/hal/hal_com_phycfg.c    | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
index f52cc4e7a6e6..a7ecdf501a14 100644
--- a/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
+++ b/drivers/staging/rtl8723bs/hal/hal_com_phycfg.c
@@ -1780,25 +1780,6 @@ s8 phy_get_tx_pwr_lmt(struct adapter *adapter, u32 reg_pwr_tbl_sel,
 		DBG_871X("No power limit table of the specified band\n");
 	}
 
-	/*  combine 5G VHT & HT rate */
-	/*  5G 20M and 40M HT and VHT can cross reference */
-	/*
-	if (band_type == BAND_ON_5G && pwr_lmt == MAX_POWER_INDEX) {
-		if (idx_bandwidth == 0 || idx_bandwidth == 1) {
-				 idx_band, idx_bandwidth,
-				 idx_rate_sctn, rf_path));
-			if (idx_rate_sctn == 2)
-				pwr_lmt = hal_data->TxPwrLimit_5G[idx_regulation][idx_bandwidth][4][idx_channel][rf_path];
-			else if (idx_rate_sctn == 4)
-				pwr_lmt = hal_data->TxPwrLimit_5G[idx_regulation][idx_bandwidth][2][idx_channel][rf_path];
-			else if (idx_rate_sctn == 3)
-				pwr_lmt = hal_data->TxPwrLimit_5G[idx_regulation][idx_bandwidth][5][idx_channel][rf_path];
-			else if (idx_rate_sctn == 5)
-				pwr_lmt = hal_data->TxPwrLimit_5G[idx_regulation][idx_bandwidth][3][idx_channel][rf_path];
-		}
-	}
-	*/
-
 	/* DBG_871X("TxPwrLmt[Regulation %d][Band %d][BW %d][RFPath %d][Rate 0x%x][Chnl %d] = %d\n", */
 	/*		idx_regulation, hal_data->CurrentBandType, bandwidth, rf_path, data_rate, channel, pwr_lmt); */
 	return pwr_lmt;
-- 
2.20.1


      parent reply	other threads:[~2021-04-05 16:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-05 16:49 [PATCH 00/10] staging: rtl8723bs: completely remove RT_TRACE logs Fabio Aiuto
2021-04-05 16:49 ` [PATCH 01/10] staging: rtl8723bs: remove all RT_TRACE logs in hal/ and os_dep/ Fabio Aiuto
2021-04-05 16:49 ` [PATCH 02/10] staging: rtl8723bs: remove commented out " Fabio Aiuto
2021-04-09 10:12   ` Dan Carpenter
2021-04-09 10:23     ` Fabio Aiuto
2021-04-05 16:49 ` [PATCH 03/10] staging: rtl8723bs: remove RT_TRACE log definitions Fabio Aiuto
2021-04-05 16:49 ` [PATCH 04/10] staging: rtl8723bs: remove empty if, else blocks after RT_TRACE deletion Fabio Aiuto
2021-04-05 16:49 ` [PATCH 05/10] staging: rtl8723bs: remove empty #ifdef " Fabio Aiuto
2021-04-05 16:49 ` [PATCH 06/10] staging: rtl8723bs: remove unnecessary bracks " Fabio Aiuto
2021-04-05 16:49 ` [PATCH 07/10] staging: rtl8723bs: place constant on the right side of the test Fabio Aiuto
2021-04-05 16:49 ` [PATCH 08/10] staging: rtl8723bs: rewrite comparisons to null Fabio Aiuto
2021-04-05 16:49 ` [PATCH 09/10] staging: rtl8723bs: remove empty for cycles Fabio Aiuto
2021-04-05 16:49 ` Fabio Aiuto [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b930cfc476c97f2ae5c5b90c1314a6270d56a539.1617640221.git.fabioaiuto83@gmail.com \
    --to=fabioaiuto83@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).