[01/10] staging: rtl8188eu: remove unused macros
diff mbox series

Message ID 20210407170531.29356-1-martin@kaiser.cx
State Accepted
Commit 46694b686d4a0360acb7aa4329ff73754049596f
Headers show
Series
  • [01/10] staging: rtl8188eu: remove unused macros
Related show

Commit Message

Martin Kaiser April 7, 2021, 5:05 p.m. UTC
usb_ops_linux.h contains a couple of macros to make functions usable as
urb completion callbacks. Most of them are unused and can be removed.

Signed-off-by: Martin Kaiser <martin@kaiser.cx>
---
 drivers/staging/rtl8188eu/include/usb_ops_linux.h | 8 --------
 1 file changed, 8 deletions(-)

Comments

Greg Kroah-Hartman April 8, 2021, 7:26 a.m. UTC | #1
On Wed, Apr 07, 2021 at 07:05:22PM +0200, Martin Kaiser wrote:
> usb_ops_linux.h contains a couple of macros to make functions usable as
> urb completion callbacks. Most of them are unused and can be removed.
> 
> Signed-off-by: Martin Kaiser <martin@kaiser.cx>
> ---
>  drivers/staging/rtl8188eu/include/usb_ops_linux.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/staging/rtl8188eu/include/usb_ops_linux.h b/drivers/staging/rtl8188eu/include/usb_ops_linux.h
> index 4e0e48cb5c8e..1a0b38de5027 100644
> --- a/drivers/staging/rtl8188eu/include/usb_ops_linux.h
> +++ b/drivers/staging/rtl8188eu/include/usb_ops_linux.h
> @@ -23,18 +23,10 @@
>  #define USB_HIGH_SPEED_BULK_SIZE	512
>  #define USB_FULL_SPEED_BULK_SIZE	64
>  
> -#define _usbctrl_vendorreq_async_callback(urb, regs)	\
> -	_usbctrl_vendorreq_async_callback(urb)
> -#define usb_bulkout_zero_complete(purb, regs)		\
> -	usb_bulkout_zero_complete(purb)
> -#define usb_write_mem_complete(purb, regs)		\
> -	usb_write_mem_complete(purb)
>  #define usb_write_port_complete(purb, regs)		\
>  	usb_write_port_complete(purb)
>  #define usb_read_port_complete(purb, regs)		\
>  	usb_read_port_complete(purb)
> -#define usb_read_interrupt_complete(purb, regs)		\
> -	usb_read_interrupt_complete(purb)

Wow, that's there for a really old kernel version and should not be
needed anymore at all.  I'll take this, but please remove the other ones
here, they are not necessary.

thanks,

greg k-h
Martin Kaiser April 8, 2021, 7:52 p.m. UTC | #2
Thus wrote Greg Kroah-Hartman (gregkh@linuxfoundation.org):

> Wow, that's there for a really old kernel version and should not be
> needed anymore at all.  I'll take this, but please remove the other ones
> here, they are not necessary.

Ok, I see what you mean. New patch is on the way.

Best regards,
Martin

Patch
diff mbox series

diff --git a/drivers/staging/rtl8188eu/include/usb_ops_linux.h b/drivers/staging/rtl8188eu/include/usb_ops_linux.h
index 4e0e48cb5c8e..1a0b38de5027 100644
--- a/drivers/staging/rtl8188eu/include/usb_ops_linux.h
+++ b/drivers/staging/rtl8188eu/include/usb_ops_linux.h
@@ -23,18 +23,10 @@ 
 #define USB_HIGH_SPEED_BULK_SIZE	512
 #define USB_FULL_SPEED_BULK_SIZE	64
 
-#define _usbctrl_vendorreq_async_callback(urb, regs)	\
-	_usbctrl_vendorreq_async_callback(urb)
-#define usb_bulkout_zero_complete(purb, regs)		\
-	usb_bulkout_zero_complete(purb)
-#define usb_write_mem_complete(purb, regs)		\
-	usb_write_mem_complete(purb)
 #define usb_write_port_complete(purb, regs)		\
 	usb_write_port_complete(purb)
 #define usb_read_port_complete(purb, regs)		\
 	usb_read_port_complete(purb)
-#define usb_read_interrupt_complete(purb, regs)		\
-	usb_read_interrupt_complete(purb)
 
 unsigned int ffaddr2pipehdl(struct dvobj_priv *pdvobj, u32 addr);