From: Longfang Liu <liulongfang@huawei.com>
To: <gregkh@linuxfoundation.org>, <mathias.nyman@intel.com>,
<stern@rowland.harvard.edu>, <liudongdong3@huawei.com>
Cc: <linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<liulongfang@huawei.com>, <kong.kongxinwei@hisilicon.com>,
<yisen.zhuang@huawei.com>
Subject: [PATCH v3 2/2] USB:ehci:fix Kunpeng920 ehci hardware problem
Date: Fri, 9 Apr 2021 11:00:15 +0800 [thread overview]
Message-ID: <1617937215-39035-3-git-send-email-liulongfang@huawei.com> (raw)
In-Reply-To: <1617937215-39035-1-git-send-email-liulongfang@huawei.com>
Kunpeng920's EHCI controller does not have SBRN register.
Reading the SBRN register when the controller driver is
initialized will get 0.
When rebooting the EHCI driver, ehci_shutdown() will be called.
if the sbrn flag is 0, ehci_shutdown() will return directly.
The sbrn flag being 0 will cause the EHCI interrupt signal to
not be turned off after reboot. this interrupt that is not closed
will cause an exception to the device sharing the interrupt.
Therefore, the EHCI controller of kunpeng920 needs to be added
to the whitelist without SBRN register.
Signed-off-by: Longfang Liu <liulongfang@huawei.com>
---
drivers/usb/host/ehci-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
index f7f3156..3690e62 100644
--- a/drivers/usb/host/ehci-pci.c
+++ b/drivers/usb/host/ehci-pci.c
@@ -53,6 +53,8 @@ static const struct ehci_nosbrn {
} ehci_nosbrn_table[] = {
/* STMICRO ConneXT has no sbrn register */
{PCI_VENDOR_ID_STMICRO, PCI_DEVICE_ID_STMICRO_USB_HOST},
+ /* HUAWEI Kunpeng920 HiSilicon USB EHCI has no sbrn register */
+ {PCI_VENDOR_ID_HUAWEI, 0xa239},
{},
};
--
2.8.1
prev parent reply other threads:[~2021-04-09 3:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-09 3:00 [PATCH v3 0/2] USB:ehci:fix the no SRBN register problem Longfang Liu
2021-04-09 3:00 ` [PATCH v3 1/2] USB:ehci:Add a whitelist for EHCI controllers Longfang Liu
2021-04-09 6:46 ` Greg KH
2021-04-09 3:00 ` Longfang Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617937215-39035-3-git-send-email-liulongfang@huawei.com \
--to=liulongfang@huawei.com \
--cc=gregkh@linuxfoundation.org \
--cc=kong.kongxinwei@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=mathias.nyman@intel.com \
--cc=stern@rowland.harvard.edu \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).