linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stephen Boyd <swboyd@chromium.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	x86@kernel.org, Jiri Olsa <jolsa@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>,
	Evan Green <evgreen@chromium.org>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Petr Mladek <pmladek@suse.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Matthew Wilcox <willy@infradead.org>
Subject: [PATCH v4 07/13] x86/dumpstack: Use %pSb/%pBb for backtrace printing
Date: Fri,  9 Apr 2021 18:52:54 -0700	[thread overview]
Message-ID: <20210410015300.3764485-8-swboyd@chromium.org> (raw)
In-Reply-To: <20210410015300.3764485-1-swboyd@chromium.org>

Let's use the new printk formats to print the stacktrace entries when
printing a backtrace to the kernel logs. This will include any module's
build ID[1] in it so that offline/crash debugging can easily locate the
debuginfo for a module via something like debuginfod[2].

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: <x86@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Jessica Yu <jeyu@kernel.org>
Cc: Evan Green <evgreen@chromium.org>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Petr Mladek <pmladek@suse.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Matthew Wilcox <willy@infradead.org>
Link: https://fedoraproject.org/wiki/Releases/FeatureBuildId [1]
Link: https://sourceware.org/elfutils/Debuginfod.html [2]
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 arch/x86/kernel/dumpstack.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
index 299c20f0a38b..be2de39bf16f 100644
--- a/arch/x86/kernel/dumpstack.c
+++ b/arch/x86/kernel/dumpstack.c
@@ -69,7 +69,7 @@ static void printk_stack_address(unsigned long address, int reliable,
 				 const char *log_lvl)
 {
 	touch_nmi_watchdog();
-	printk("%s %s%pB\n", log_lvl, reliable ? "" : "? ", (void *)address);
+	printk("%s %s%pBb\n", log_lvl, reliable ? "" : "? ", (void *)address);
 }
 
 static int copy_code(struct pt_regs *regs, u8 *buf, unsigned long src,
@@ -143,9 +143,9 @@ void show_opcodes(struct pt_regs *regs, const char *loglvl)
 void show_ip(struct pt_regs *regs, const char *loglvl)
 {
 #ifdef CONFIG_X86_32
-	printk("%sEIP: %pS\n", loglvl, (void *)regs->ip);
+	printk("%sEIP: %pSb\n", loglvl, (void *)regs->ip);
 #else
-	printk("%sRIP: %04x:%pS\n", loglvl, (int)regs->cs, (void *)regs->ip);
+	printk("%sRIP: %04x:%pSb\n", loglvl, (int)regs->cs, (void *)regs->ip);
 #endif
 	show_opcodes(regs, loglvl);
 }
-- 
https://chromeos.dev


  parent reply	other threads:[~2021-04-10  1:53 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-10  1:52 [PATCH v4 00/13] Add build ID to stacktraces Stephen Boyd
2021-04-10  1:52 ` [PATCH v4 01/13] buildid: Only consider GNU notes for build ID parsing Stephen Boyd
2021-04-13 14:34   ` Petr Mladek
2021-04-10  1:52 ` [PATCH v4 02/13] buildid: Add API to parse build ID out of buffer Stephen Boyd
2021-04-10  1:52 ` [PATCH v4 03/13] buildid: Stash away kernels build ID on init Stephen Boyd
2021-04-10  1:52 ` [PATCH v4 04/13] dump_stack: Add vmlinux build ID to stack traces Stephen Boyd
2021-04-13 14:41   ` Petr Mladek
2021-04-13 20:36     ` Stephen Boyd
2021-04-10  1:52 ` [PATCH v4 05/13] module: Add printk formats to add module build ID to stacktraces Stephen Boyd
2021-04-12 11:58   ` Andy Shevchenko
2021-04-12 19:29     ` Stephen Boyd
2021-04-13 10:56       ` Andy Shevchenko
2021-04-13 15:16         ` Petr Mladek
2021-04-13 20:10           ` Stephen Boyd
2021-04-13 22:36             ` Stephen Boyd
2021-04-13 15:01   ` Petr Mladek
2021-04-13 22:57     ` Stephen Boyd
2021-04-15  8:53       ` Petr Mladek
2021-04-15 13:04   ` Jessica Yu
2021-04-18  1:52     ` Stephen Boyd
2021-04-19 10:34       ` Jessica Yu
2021-04-10  1:52 ` [PATCH v4 06/13] arm64: stacktrace: Use %pSb for backtrace printing Stephen Boyd
2021-04-10  1:52 ` Stephen Boyd [this message]
2021-04-10  1:52 ` [PATCH v4 08/13] scripts/decode_stacktrace.sh: Support debuginfod Stephen Boyd
2021-04-10  1:52 ` [PATCH v4 09/13] scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm Stephen Boyd
2021-04-10  1:52 ` [PATCH v4 10/13] scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path Stephen Boyd
2021-04-10  1:52 ` [PATCH v4 11/13] buildid: Mark some arguments const Stephen Boyd
2021-04-10  1:52 ` [PATCH v4 12/13] buildid: Fix kernel-doc notation Stephen Boyd
2021-04-10  1:53 ` [PATCH v4 13/13] kdump: Use vmlinux_build_id to simplify Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210410015300.3764485-8-swboyd@chromium.org \
    --to=swboyd@chromium.org \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ast@kernel.org \
    --cc=bp@alien8.de \
    --cc=evgreen@chromium.org \
    --cc=hsinyi@chromium.org \
    --cc=jeyu@kernel.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).