From: Odin Ugedal <odin@uged.al>
To: tj@kernel.org, lizefan.x@bytedance.com
Cc: cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
Odin Ugedal <odin@uged.al>
Subject: [PATCH 1/2] cgroup2: cpuset: Disable subset validation on set
Date: Tue, 13 Apr 2021 11:02:34 +0200 [thread overview]
Message-ID: <20210413090235.1903026-2-odin@uged.al> (raw)
In-Reply-To: <20210413090235.1903026-1-odin@uged.al>
Due to how cpuset works in v2, there is no need to check if direct
children are subsets of the new cpuset. In v2, the effective cpuset
of a cgroup is the intersection between the effective value of the parent
and the cpuset.cpus value of the cgroup, with a fallback to the effective
parent value in case the intersection is an empty set.
Therefore, in v2, it is allowed to set cpuset.cpus to a a value that is
not a subset of the parents effective value, resulting in inheriting the
effective cpuset from the parent. Therefore the validation when updating
the parent cpuset (in this case) is not necessary, and can be disabled.
Example:
/sys/fs/cgroup/A (cpus=1-2,cpus.effective=1-2)
/sys/fs/cgroup/A/B (cpus="", cpus.effective=1-2)
Setting cpus to 3-4 is possible for A/B
/sys/fs/cgroup/A (cpus=1-2,cpus.effective=1-2)
/sys/fs/cgroup/A/B (cpus=3-4,cpus.effective=1-2)
Setting cpus to 1 for A would result in an -EBUSY error, but
with this patch it will work as expected:
/sys/fs/cgroup/A (cpus=1, cpus.effective=1)
/sys/fs/cgroup/A/B (cpus=3-4,cpus.effective=1)
This also applies in a similar manner on cpuset.mems.
Signed-off-by: Odin Ugedal <odin@uged.al>
---
kernel/cgroup/cpuset.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 5258b68153e0..f543c4c6084a 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -572,11 +572,13 @@ static int validate_change(struct cpuset *cur, struct cpuset *trial)
rcu_read_lock();
- /* Each of our child cpusets must be a subset of us */
+ /* On legacy hierarchy, each of our child cpusets must be a subset of us */
ret = -EBUSY;
- cpuset_for_each_child(c, css, cur)
- if (!is_cpuset_subset(c, trial))
- goto out;
+ if (!is_in_v2_mode()) {
+ cpuset_for_each_child(c, css, cur)
+ if (!is_cpuset_subset(c, trial))
+ goto out;
+ }
/* Remaining checks don't apply to root cpuset */
ret = 0;
--
2.31.0
next prev parent reply other threads:[~2021-04-13 9:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 9:02 [PATCH 0/2] Relax cpuset validation for cgroup v2 Odin Ugedal
2021-04-13 9:02 ` Odin Ugedal [this message]
2021-04-13 9:02 ` [PATCH 2/2] cgroup2: cpuset: Always allow setting empty cpuset Odin Ugedal
2021-04-13 11:10 ` [PATCH 0/2] Relax cpuset validation for cgroup v2 Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413090235.1903026-2-odin@uged.al \
--to=odin@uged.al \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).