From: Muhammad Usama Anjum <musamaanjum@gmail.com>
To: Steve French <sfrench@samba.org>,
Ronnie Sahlberg <lsahlber@redhat.com>,
"open list:COMMON INTERNET FILE SYSTEM CLIENT (CIFS)"
<linux-cifs@vger.kernel.org>,
"moderated list:COMMON INTERNET FILE SYSTEM CLIENT (CIFS)"
<samba-technical@lists.samba.org>,
open list <linux-kernel@vger.kernel.org>
Cc: musamaanjum@gmail.com, kernel-janitors@vger.kernel.org,
dan.carpenter@oracle.com, colin.king@canonical.com
Subject: [PATCH] cifs: remove unnecessary copies of tcon->crfid.fid
Date: Wed, 14 Apr 2021 04:25:58 +0500 [thread overview]
Message-ID: <20210413232558.GA1136036@LEGION> (raw)
pfid is being set to tcon->crfid.fid and they are copied in each other
multiple times. Remove the memcopy between same pointers.
Addresses-Coverity: ("Overlapped copy")
Fixes: 9e81e8ff74b9 ("cifs: return cached_fid from open_shroot")
Signed-off-by: Muhammad Usama Anjum <musamaanjum@gmail.com>
---
I'm not sure why refcount was being incremented here. This file has been
evoloved so much. Any ideas?
fs/cifs/smb2ops.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c
index 61214b23c57f..6fa35003dcfe 100644
--- a/fs/cifs/smb2ops.c
+++ b/fs/cifs/smb2ops.c
@@ -847,14 +847,6 @@ int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon,
.volatile_fid = pfid->volatile_fid,
};
- /*
- * caller expects this func to set pfid to a valid
- * cached root, so we copy the existing one and get a
- * reference.
- */
- memcpy(pfid, tcon->crfid.fid, sizeof(*pfid));
- kref_get(&tcon->crfid.refcount);
-
mutex_unlock(&tcon->crfid.fid_mutex);
if (rc == 0) {
@@ -885,7 +877,6 @@ int open_cached_dir(unsigned int xid, struct cifs_tcon *tcon,
oparms.fid->mid = le64_to_cpu(o_rsp->sync_hdr.MessageId);
#endif /* CIFS_DEBUG2 */
- memcpy(tcon->crfid.fid, pfid, sizeof(struct cifs_fid));
tcon->crfid.tcon = tcon;
tcon->crfid.is_valid = true;
tcon->crfid.dentry = dentry;
--
2.25.1
next reply other threads:[~2021-04-13 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 23:25 Muhammad Usama Anjum [this message]
2021-04-14 12:00 ` [PATCH] cifs: remove unnecessary copies of tcon->crfid.fid Aurélien Aptel
2021-04-15 14:52 ` Muhammad Usama Anjum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210413232558.GA1136036@LEGION \
--to=musamaanjum@gmail.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lsahlber@redhat.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).